From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 451321C3BFC; Mon, 29 Jun 2026 13:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740282; cv=none; b=pGUmLg4wDwyV5WHvVKvci2pQc7ZUMe069xCijhCSeahkrGUZmEJ+XJ+6GWL8I64wczwc66PqYDpdXGSvJxqHh2bSTv+dkw4X5XA8kD6AC5qLsm0Mn5lI3AuyiMSbvI+DFCGUlIbh0c90wdREdiOEXL5oO/4oYSduh+owJms7fL4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740282; c=relaxed/simple; bh=h0NzO1io+fgYlm1+qBEUP+mMXcgWEx+u2huOZYmnOlY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=PF8UXgzfUgLERELZR0N/Kpb2lB8QqvOHdI+gtCRTxPB566PzwqRhV6bm2FVwFyDjrFCZCznWzX8fDeQ1ktvKtYPLe5nVHt2cJYDtQJNcCH2frJIEXpxf2wuNCf5SOfwOp8v7iSvweZUui1PBP4WpA35NSjKVP9fWKhaSlE+RLpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jduZfLYz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jduZfLYz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C8731F000E9; Mon, 29 Jun 2026 13:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782740280; bh=8UlMaOm8BTmhX7nDTKw745qE/4Yj1dRnU49r449uo+g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=jduZfLYzkwdroju15z+zcLIY6Ezoh9dO5Gedy7AgT17GImt66hAuvSUHo7zV2rUwe Q6tCH8qZDORrCWeranBbZIZkFmVxI+EZJ5G/Fe9XXsN/YfHSQoeilu38DFikksljWr UwixBseP+ubQib89cCfFhu8NpHo0R78OEvM6uXDXMLqyzpfIIYld1PBsjjp8shuGQb ujrpErEV/J7neb0IAqED39lAHP+g0N8JN0zKWFnHK2Mzkz4GDrEn0uU/fB1X87vL+y mm0LSicM20eq8cB/Lhhua8q2uoAeZMq4wsz7FkrMCYXvbI7unDuiaq30E5Hcqz/CA6 E//KGdOXiR2Lg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 5/6] [v5] leds: gpio: make legacy gpiolib interface optional Reply-To: sashiko-reviews@lists.linux.dev To: "Arnd Bergmann" Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, lee@kernel.org In-Reply-To: <20260629130329.1291953-6-arnd@kernel.org> References: <20260629130329.1291953-1-arnd@kernel.org> <20260629130329.1291953-6-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 13:38:00 +0000 Message-Id: <20260629133800.9C8731F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Fatal build error due to missing header file `linux/gpio/legacy.h`. -- commit 2f558c72edeac39e19dec733e556e60219934526 Author: Arnd Bergmann leds: gpio: make legacy gpiolib interface optional This commit splits out the legacy portion of the platform_data handling into a custom helper function guarded by CONFIG_GPIOLIB_LEGACY. The goal is to allow the leds-gpio driver to compile cleanly when the legacy configuration gets turned off for modern platforms. Link: https://lore.kernel.org/all/e9252384-a55c-4a91-9c61-06e05a0b2ce4@app.= fastmail.com/ > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index a3428b22de3a1..740772c2504a1 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -9,8 +9,8 @@ > #include > #include > #include > -#include > #include > +#include [Severity: Low] Does this cause a build failure? It looks like linux/gpio/legacy.h doesn't exist in the kernel source tree, and the legacy GPIO APIs remain conditiona= lly available within include/linux/gpio.h itself. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629130329.1291= 953-1-arnd@kernel.org?part=3D5