From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from endrift.com (endrift.com [173.255.198.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DDDC25A359 for ; Wed, 1 Jul 2026 03:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.255.198.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782875781; cv=none; b=ZJkHYc2roLD4UHGWrjF4bTMn48JWY7d73vnZWM/ML7aEj4OBhQmmD6fKedCw0cqdA3uCPIvdT/Bd8OmwmtE4sY1KRTKqe7aNyd6QVjjaVWVXcxqqQGUJB32HRFyYvnbfJsLRAu8ozR/7eWMOhqpnU41W0xyKbj/p7NtmvL65+4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782875781; c=relaxed/simple; bh=dCCy/FYVsl/uGTxtouBlqncvJsben91O6jQO9FtDKzU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y1uQ/+KI454aYN8uTyVkWg4F0+oRprUirWvnHiPIpQZeuaPvkMR03yBEuaRLo5arMgM626AjntMcqpPI+GRUtzA/jJqbSToAJMTdEUiGvjGO9L74AoqgNwcIVJbk0oOwbmBL2HZrgETwVTXfegNVZwVH6YcKs5XkSgU20vnpNec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=endrift.com; spf=pass smtp.mailfrom=endrift.com; dkim=pass (2048-bit key) header.d=endrift.com header.i=@endrift.com header.b=ckSO7giX; arc=none smtp.client-ip=173.255.198.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=endrift.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=endrift.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=endrift.com header.i=@endrift.com header.b="ckSO7giX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=endrift.com; s=2020; t=1782875779; bh=dCCy/FYVsl/uGTxtouBlqncvJsben91O6jQO9FtDKzU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ckSO7giXPi99Lc5UKUeyJUjHyEgGsCJP8qTYGaE7xYH/W6NGjmeb4yO9YJ6BCYQbf 9huqO8Lh3KpWQDRk8n5tWhhr9OvhwRrIE+ivwEyYnvj7LYPkq8jk6dS1BR4CzGXJC7 7G4FXV6gPik3OvFsiDnc53bSdQfhi3vZ0r/81fBtVlj+GRnk+A7YUnzhSXPbUVPmHO Ni14AT3XX/oMrw8I9C6e70CGXfeK1LiIdbs3crROm5sNUrFNw/u195miYoZa0lu0VR oi3CjDBLuTUAlx+KaIFnLfk5ZQxnAniYLKD7ak0aiYPpYRhOkDTnLsZ8ieF2DEi4gN dcnH/wKKYO2Aw== Received: from microtis.vulpes.eutheria.net (71-212-73-87.tukw.qwest.net [71.212.73.87]) by endrift.com (Postfix) with ESMTPSA id 9EF22A091; Tue, 30 Jun 2026 20:16:18 -0700 (PDT) From: Vicki Pfau To: Dmitry Torokhov , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Cc: Vicki Pfau , Silvan Jegen Subject: [PATCH v8 2/3] HID: nintendo: Add rumble support for Switch 2 controllers Date: Tue, 30 Jun 2026 20:15:10 -0700 Message-ID: <20260701031513.3068035-3-vi@endrift.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701031513.3068035-1-vi@endrift.com> References: <20260701031513.3068035-1-vi@endrift.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This adds rumble support for both the "HD Rumble" linear resonant actuator type as used in the Joy-Cons and Pro Controller, as well as the eccentric rotating mass type used in the GameCube controller. Note that since there's currently no API for exposing full control of LRAs with evdev, it only simulates a basic rumble for now. Signed-off-by: Vicki Pfau --- drivers/hid/Kconfig | 8 +- drivers/hid/hid-nintendo.c | 217 ++++++++++++++++++++++++++++++++++++- 2 files changed, 218 insertions(+), 7 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 19c77c323ec9..851eed76c236 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -859,10 +859,10 @@ config NINTENDO_FF depends on HID_NINTENDO select INPUT_FF_MEMLESS help - Say Y here if you have a Nintendo Switch controller and want to enable - force feedback support for it. This works for both joy-cons, the pro - controller, and the NSO N64 controller. For the pro controller, both - rumble motors can be controlled individually. + Say Y here if you have a Nintendo Switch or Switch 2 controller and want + to enable force feedback support for it. This works for Joy-Cons, the Pro + Controllers, and the NSO N64 and GameCube controller. For the Pro + Controller, both rumble motors can be controlled individually. config HID_NTI tristate "NTI keyboard adapters" diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c index 20e5b18039b8..00ab4bee3dab 100644 --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -2989,6 +2989,7 @@ enum switch2_init_step { NS2_INIT_READ_USER_SECONDARY_CALIB, NS2_INIT_SET_FEATURE_MASK, NS2_INIT_ENABLE_FEATURES, + NS2_INIT_ENABLE_RUMBLE, NS2_INIT_GRIP_BUTTONS, NS2_INIT_REPORT_FORMAT, NS2_INIT_SET_PLAYER_LEDS, @@ -3020,6 +3021,18 @@ struct switch2_stick_calibration { struct switch2_axis_calibration y; }; +struct switch2_hd_rumble { + uint16_t hi_freq : 10; + uint16_t hi_amp : 10; + uint16_t lo_freq : 10; + uint16_t lo_amp : 10; +} __packed; + +struct switch2_erm_rumble { + uint16_t error; + uint16_t amplitude; +}; + struct switch2_controller { struct hid_device *hdev; struct switch2_cfg_intf *cfg; @@ -3043,8 +3056,45 @@ struct switch2_controller { uint32_t player_id; struct led_classdev leds[4]; + +#if IS_ENABLED(CONFIG_NINTENDO_FF) + spinlock_t rumble_lock; + uint8_t rumble_seq; + union { + struct switch2_hd_rumble hd; + struct switch2_erm_rumble sd; + } rumble; + uint64_t last_rumble_work; + struct delayed_work rumble_work; + uint8_t *rumble_buffer; +#endif }; +enum gc_rumble { + GC_RUMBLE_OFF = 0, + GC_RUMBLE_ON = 1, + GC_RUMBLE_STOP = 2, +}; + +/* + * The highest rumble level for "HD Rumble" is strong enough to potentially damage the controller, + * and also leaves your hands feeling like melted jelly, so we set a semi-arbitrary scaling factor + * to artificially limit the maximum for safety and comfort. It is currently unknown if the Switch + * 2 itself does something similar, but it's quite likely. + * + * This value must be between 0 and 1024, otherwise the math below will overflow. + */ +#define RUMBLE_MAX 450u + +/* + * Semi-arbitrary values used to simulate the "rumble" sensation of an eccentric rotating + * mass type haptic motor on the Switch 2 controllers' linear resonant actuator type haptics. + * + * The units used are unknown, but the values must be between 0 and 1023. + */ +#define RUMBLE_HI_FREQ 0x187 +#define RUMBLE_LO_FREQ 0x112 + static DEFINE_MUTEX(switch2_controllers_lock); static LIST_HEAD(switch2_controllers); @@ -3136,7 +3186,7 @@ static const uint8_t switch2_init_cmd_data[] = { static const uint8_t switch2_one_data[] = { 0x01, 0x00, 0x00, 0x00 }; static const uint8_t switch2_feature_mask[] = { - NS2_FEATURE_BUTTONS | NS2_FEATURE_ANALOG | NS2_FEATURE_IMU, + NS2_FEATURE_BUTTONS | NS2_FEATURE_ANALOG | NS2_FEATURE_IMU | NS2_FEATURE_RUMBLE, 0x00, 0x00, 0x00 }; @@ -3197,7 +3247,11 @@ static void switch2_controller_put(struct switch2_controller *ns2) static void switch2_kref_put(struct kref *refcount) { struct switch2_controller *ns2 = container_of(refcount, - struct switch2_controller, refcount); + struct switch2_controller, refcount); + +#if IS_ENABLED(CONFIG_NINTENDO_FF) + cancel_delayed_work_sync(&ns2->rumble_work); +#endif guard(mutex)(&switch2_controllers_lock); list_del_init(&ns2->entry); @@ -3205,6 +3259,125 @@ static void switch2_kref_put(struct kref *refcount) kfree(ns2); } +#if IS_ENABLED(CONFIG_NINTENDO_FF) +static void switch2_encode_rumble(struct switch2_hd_rumble *rumble, uint8_t buffer[5]) +{ + buffer[0] = rumble->hi_freq; + buffer[1] = (rumble->hi_freq >> 8) | (rumble->hi_amp << 2); + buffer[2] = (rumble->hi_amp >> 6) | (rumble->lo_freq << 4); + buffer[3] = (rumble->lo_freq >> 4) | (rumble->lo_amp << 6); + buffer[4] = rumble->lo_amp >> 2; +} + +static int switch2_play_effect(struct input_dev *dev, void *data, struct ff_effect *effect) +{ + struct switch2_controller *ns2 = input_get_drvdata(dev); + unsigned long flags; + + if (effect->type != FF_RUMBLE) + return 0; + + spin_lock_irqsave(&ns2->rumble_lock, flags); + if (ns2->ctlr_type == NS2_CTLR_TYPE_GC) { + ns2->rumble.sd.amplitude = max(effect->u.rumble.strong_magnitude, + (uint16_t) (effect->u.rumble.weak_magnitude >> 1)); + } else { + ns2->rumble.hd.hi_freq = RUMBLE_HI_FREQ; + ns2->rumble.hd.lo_freq = RUMBLE_LO_FREQ; + ns2->rumble.hd.hi_amp = effect->u.rumble.weak_magnitude * RUMBLE_MAX >> 16; + ns2->rumble.hd.lo_amp = effect->u.rumble.strong_magnitude * RUMBLE_MAX >> 16; + } + spin_unlock_irqrestore(&ns2->rumble_lock, flags); + + schedule_delayed_work(&ns2->rumble_work, 0); + + return 0; +} + +static void switch2_rumble_work(struct work_struct *work) +{ + struct switch2_controller *ns2 = container_of(to_delayed_work(work), + struct switch2_controller, rumble_work); + unsigned long flags; + bool active; + int ret = 0; + + spin_lock_irqsave(&ns2->rumble_lock, flags); + ns2->rumble_buffer[0x1] = 0x50 | ns2->rumble_seq; + if (ns2->ctlr_type == NS2_CTLR_TYPE_GC) { + ns2->rumble_buffer[0] = 3; + if (ns2->rumble.sd.amplitude == 0) { + ns2->rumble_buffer[2] = GC_RUMBLE_STOP; + ns2->rumble.sd.error = 0; + active = false; + } else { + if (ns2->rumble.sd.error < ns2->rumble.sd.amplitude) { + ns2->rumble_buffer[2] = GC_RUMBLE_ON; + ns2->rumble.sd.error += U16_MAX - ns2->rumble.sd.amplitude; + } else { + ns2->rumble_buffer[2] = GC_RUMBLE_OFF; + ns2->rumble.sd.error -= ns2->rumble.sd.amplitude; + } + active = true; + } + } else { + ns2->rumble_buffer[0] = 1; + switch2_encode_rumble(&ns2->rumble.hd, &ns2->rumble_buffer[0x2]); + active = ns2->rumble.hd.hi_amp || ns2->rumble.hd.lo_amp; + if (ns2->ctlr_type == NS2_CTLR_TYPE_PRO) { + /* + * The Pro Controller contains separate LRAs on each + * side that can be controlled individually. + */ + ns2->rumble_buffer[0] = 2; + ns2->rumble_buffer[0x11] = 0x50 | ns2->rumble_seq; + switch2_encode_rumble(&ns2->rumble.hd, &ns2->rumble_buffer[0x12]); + } + } + ns2->rumble_seq = (ns2->rumble_seq + 1) & 0xF; + spin_unlock_irqrestore(&ns2->rumble_lock, flags); + + if (active) { + unsigned long interval = msecs_to_jiffies(4); + uint64_t current_jiffies = get_jiffies_64(); + + if (!ns2->last_rumble_work) + ns2->last_rumble_work = current_jiffies; + else + ns2->last_rumble_work += interval; + + /* Reschedule a little early to make sure the buffer never underruns */ + interval += msecs_to_jiffies(2); + if (ns2->last_rumble_work + interval >= current_jiffies) + schedule_delayed_work(&ns2->rumble_work, + ns2->last_rumble_work + interval - current_jiffies); + else + schedule_delayed_work(&ns2->rumble_work, 0); + } else { + ns2->last_rumble_work = 0; + } + + mutex_lock(&ns2->lock); + if (!ns2->hdev) { + cancel_delayed_work(&ns2->rumble_work); + } else { + ret = hid_hw_output_report(ns2->hdev, ns2->rumble_buffer, 64); + /* + * Don't log on ENODEV, ESHUTDOWN, or EPROTO, which can happen + * mid-hotplug. Also cancel any further work on ENODEV or + * ESHUTDOWN as they're clear indications that the endpoint + * is dead. + */ + if (ret == -ENODEV || ret == -ESHUTDOWN) + cancel_delayed_work(&ns2->rumble_work); + else if (ret < 0 && ret != -EPROTO) + hid_warn_ratelimited(ns2->hdev, + "Failed to send output report ret=%d\n", ret); + } + mutex_unlock(&ns2->lock); +} +#endif + static int switch2_set_leds(struct switch2_controller *ns2) { int i; @@ -3275,6 +3448,9 @@ static void switch2_input_deref(struct input_dev *input) { struct switch2_controller *ns2 = input_get_drvdata(input); +#if IS_ENABLED(CONFIG_NINTENDO_FF) + cancel_delayed_work_sync(&ns2->rumble_work); +#endif kref_put(&ns2->refcount, switch2_kref_put); } @@ -3346,6 +3522,20 @@ static int switch2_init_input(struct switch2_controller *ns2) return -EINVAL; } +#if IS_ENABLED(CONFIG_NINTENDO_FF) + ns2->rumble_buffer = devm_kzalloc(&input->dev, 64, GFP_KERNEL); + if (!ns2->rumble_buffer) { + input_free_device(input); + return -ENOMEM; + } + input_set_capability(input, EV_FF, FF_RUMBLE); + ret = input_ff_create_memless(input, NULL, switch2_play_effect); + if (ret) { + input_free_device(input); + return ret; + } +#endif + hid_info(ns2->hdev, "Firmware version %u.%u.%u (type %i)\n", ns2->version.major, ns2->version.minor, ns2->version.patch, ns2->version.ctlr_type); if (ns2->version.dsp_type >= 0) @@ -3749,7 +3939,16 @@ static int switch2_init_controller(struct switch2_controller *ns2) return ns2->cfg->send_command(NS2_CMD_FEATSEL, NS2_SUBCMD_FEATSEL_SET_MASK, switch2_feature_mask, sizeof(switch2_feature_mask), ns2->cfg); case NS2_INIT_ENABLE_FEATURES: - return switch2_features_enable(ns2, NS2_FEATURE_BUTTONS | NS2_FEATURE_ANALOG); + return switch2_features_enable(ns2, NS2_FEATURE_BUTTONS | + NS2_FEATURE_ANALOG | NS2_FEATURE_RUMBLE); + case NS2_INIT_ENABLE_RUMBLE: + /* + * It is unclear what this packet is supposed to be for, but it + * appears to be needed for rumble to work reliably. The reply + * data indicates it might be a query of some sort, but we + * ignore the reply so long as it doesn't return an error. + */ + return ns2->cfg->send_command(0x11, 1, NULL, 0, ns2->cfg); case NS2_INIT_GRIP_BUTTONS: if (!switch2_ctlr_is_joycon(ns2->ctlr_type)) { switch2_init_step_done(ns2, ns2->init_step); @@ -3861,6 +4060,10 @@ int switch2_receive_command(struct switch2_controller *ns2, switch2_init_step_done(ns2, NS2_INIT_GET_FIRMWARE_INFO); } break; + case 0x11: + if (header->subcommand == 1) + switch2_init_step_done(ns2, NS2_INIT_ENABLE_RUMBLE); + break; default: break; } @@ -3979,6 +4182,11 @@ static int switch2_probe(struct hid_device *hdev, const struct hid_device_id *id switch2_leds_create(ns2); +#if IS_ENABLED(CONFIG_NINTENDO_FF) + spin_lock_init(&ns2->rumble_lock); + INIT_DELAYED_WORK(&ns2->rumble_work, switch2_rumble_work); +#endif + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); if (ret) { hid_err(hdev, "hw_start failed %d\n", ret); @@ -4018,6 +4226,9 @@ static void switch2_remove(struct hid_device *hdev) { struct switch2_controller *ns2 = hid_get_drvdata(hdev); +#if IS_ENABLED(CONFIG_NINTENDO_FF) + cancel_delayed_work_sync(&ns2->rumble_work); +#endif hid_hw_close(hdev); hid_hw_stop(hdev); mutex_lock(&ns2->lock); -- 2.54.0