From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5102D3921E6 for ; Sat, 4 Jul 2026 05:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144688; cv=none; b=iwlXeLctJjRa9KKN5DjDuEzlKFevtIYSRrEUNvs12sNXFcAfjBUPWF+++Q3/qmRVAVLxqt7YEBr4dvmtQ6B6jSMxrjbRi/MVu1GXspu8Tkhp48lvllSUeobCEHWLKhVrRwt0K54njQaHUvlKoEwk8VL4CkMnZ+8INFzhcfjXWHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144688; c=relaxed/simple; bh=apjEFUKjRBYrK4iX2Kg45dCDEie0ZHB8HqcgRhupms0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cnpAqveuNgXbtyz2gH0i8puyvOwIyMQTKa5k0NE1gC/GxPq8Yg+oNyOF9PXh1BNdtIiuj0zX+yBOr8QRc90jOjR+ckP5YvBz06FU76rC0/+1vSYolj6UnuvQB/gKhmMpJRh445LfTCKz3dA1KMKxJSq9xG1w4MDClbHFB6l3MYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YKlPgZ6c; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YKlPgZ6c" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-37fc02e660bso942175a91.0 for ; Fri, 03 Jul 2026 22:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783144686; x=1783749486; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EtRA/Iz7xW+gdF1+FPWoWbYlNNq+Ml51Iu6T+Ii+D0A=; b=YKlPgZ6cqpF8rzc1ezjm8eCWjHv7dbCEE300+iGaKGf2bbUCAgMWGgLoZOuLC611St ySAvyK1Xp3d2uMntCSaTvP0YtTf3E68gvnMoy7542rBk/33z1iod0yQFGp25YPhwZVZQ a/lYFH+ZwSCkF3+3idAr/bQ99wEK0/XL4pCyl875uqy6bSQ19ZoCOKzcTMmGcroz+QV6 dAyNqZfvi8DSCx6mkcso29iMt/U1fPr1t2QQqMo/k1rQEUS3peguPLDTkra13H45Mskv g6cf/UMmXw1Qe9ZcrODcZA/o3srioIJrV200a1ZQBPt5+bVf77CQ8EDC0UyDlV3wXmaR 69Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783144686; x=1783749486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EtRA/Iz7xW+gdF1+FPWoWbYlNNq+Ml51Iu6T+Ii+D0A=; b=L4HUOc61r6nt4koXJywH0jJs9HlcOH07ejEa23exv37Aj/C7eIikUhLJ9p5DVhHzOa OS0vV7kKXqslxHIyuniZQI9hXXQhUMMAs7pwhroxoKWi9+K5m1fum+nJGITxMDYYxdFZ 8Hltgfrhlsxn8DKmyC2JP0m/VY3350lddO0Q5E+kL4CMnVExhCyN+FZbq+MTiwO7PnXj eXPbZJm9Ed7LAi0//Xs1LC4Yb8hDTe5u6VV0KeKJyWpgKussnCmfg5mFZC/aaW7hhZ+S HRYgWlcpqfPudzuE6ioE568dEPGnAlOup2lQFQ6j8M7wcd9uLUlzpCCi5WW+KMBfrIxR 58Fw== X-Forwarded-Encrypted: i=1; AHgh+RomSWf6adVQLQPfvwMKeLcbdOwa2n/ef2yTHd4w4zXqQCgKg7uXpavtuSAVIGLw2OQaMmm8KvtT2eFTMg==@vger.kernel.org X-Gm-Message-State: AOJu0YwE2JshYeagnaCCYB0F8K02Rlu49S5HPIrpyuqKNQ2BTn/s3Whh qBLlONY7rCCVs2OrySNtqOti2FSKej/4RUVDu8Fka4QYsL5dkPu7X6Id X-Gm-Gg: AfdE7cmQ6cw87ryym0y+fH/QtFNN4biUdqPazOGiMT/7sOzP8oIG6zT9Q3+RPCggw2t b0s5dwYvKKN4IiOQat8iuwjgo3v0DA4NED9MzdRFQtT12RuQr26G7BJ+kbpb5vdW7hhcJajkB9o EC19F84CW3wzAWd1GJrhMcwDTsDgiNsvOIzQZantE/yvPQvzzn5USsXddoHvSM0CifunrUhfmp9 TXEcrzSXkzWy601AUHL5j8Uw77msVoAG2rMOyzh8PZf731v9R5OVsFf7EcqQLqSrqAyKAMlUccp XQjtsVmc/5y+PQwKacmWW2zjVyJejVNiWj46CcJ2aCqzlDlFZSmaJsBO7bSXUxMfP18FnWDAcOX EXNGuizwDAfwrZ0rqiXG4Gq+gvgzmJm0FkATChQQY4Oc/hPDra/z142VKH4R6LgLj/1p1p4K405 dO1TokeSXbLOTqA07bKHcj4IufoXEegH4jgqB09TIFksD4vF6tZLrgezGA5OxqXsuLnaFx3E7Pm KQ= X-Received: by 2002:a17:90b:3f8b:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-38281185463mr2376208a91.14.1783144686491; Fri, 03 Jul 2026 22:58:06 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:880:86f9:3b00:6746]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b813cd9sm26262412eec.8.2026.07.03.22.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 22:58:05 -0700 (PDT) From: Dmitry Torokhov Date: Fri, 03 Jul 2026 22:57:43 -0700 Subject: [PATCH 20/26] Input: maple_keyb - convert to devm Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260703-b4-maple-cleanup-v1-20-41e424964da5@gmail.com> References: <20260703-b4-maple-cleanup-v1-0-41e424964da5@gmail.com> In-Reply-To: <20260703-b4-maple-cleanup-v1-0-41e424964da5@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz Cc: Florian Fuchs , Adrian McMenamin , linux-kernel@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org X-Mailer: b4 0.16-dev-6911d Convert the driver to use managed resources to simplify resource lifecycle management. This eliminates manual error handling in probe() and removes manual input device unregistration and memory freeing from remove(). Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/maple_keyb.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_keyb.c index aa9a4a80e26f..bd4ce803a13e 100644 --- a/drivers/input/keyboard/maple_keyb.c +++ b/drivers/input/keyboard/maple_keyb.c @@ -155,17 +155,13 @@ static int probe_maple_kbd(struct maple_device *mdev) struct dc_kbd *kbd; struct input_dev *idev; - kbd = kzalloc_obj(*kbd); - if (!kbd) { - error = -ENOMEM; - goto fail; - } + kbd = devm_kzalloc(&mdev->dev, sizeof(*kbd), GFP_KERNEL); + if (!kbd) + return -ENOMEM; - idev = input_allocate_device(); - if (!idev) { - error = -ENOMEM; - goto fail_idev_alloc; - } + idev = devm_input_allocate_device(&mdev->dev); + if (!idev) + return -ENOMEM; kbd->dev = idev; memcpy(kbd->keycode, dc_kbd_keycode, sizeof(kbd->keycode)); @@ -179,7 +175,6 @@ static int probe_maple_kbd(struct maple_device *mdev) idev->keycodesize = sizeof(unsigned short); idev->keycodemax = ARRAY_SIZE(kbd->keycode); idev->id.bustype = BUS_HOST; - idev->dev.parent = &mdev->dev; idev->open = dc_kbd_open; idev->close = dc_kbd_close; @@ -191,15 +186,9 @@ static int probe_maple_kbd(struct maple_device *mdev) error = input_register_device(idev); if (error) - goto fail_register; - return error; - -fail_register: - input_free_device(idev); -fail_idev_alloc: - kfree(kbd); -fail: - return error; + return error; + + return 0; } -- 2.55.0.rc0.799.gd6f94ed593-goog