From: Vadim Klishko <vadim@cirque.corp-partner.google.com>
To: jikos@kernel.org
Cc: bentiss@kernel.org, dianders@chromium.org,
treapking@chromium.org, raoxu@uniontech.com, superm1@kernel.org,
kenkinming2002@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, AJ_Cheng@compal.com,
kevinchou@google.com, andy.hung@cirque.com,
andy.hung@cirque.corp-partner.google.com,
CindyXT_Wang@compal.com, frank.chen@cirque.com,
Vadim Klishko <vadim@cirque.com>
Subject: [PATCH v2] HID: i2c-hid: Add a quirk for a Cirque I2C device.
Date: Tue, 7 Jul 2026 18:31:08 -0600 [thread overview]
Message-ID: <20260708003108.20288-1-vadim@cirque.com> (raw)
In-Reply-To: <20260703144726.14808-1-vadim@cirque.com>
Cirque touchpads with PID D0C1 generate an error when probed
by the I2C HID driver, resulting in no hidraw device created.
Adding I2C_HID_QUIRK_NO_IRQ_AFTER_RESET fixes the issue.
Signed-off-by: Vadim Klishko <vadim@cirque.com>
---
Changes in v2:
- No code changes.
- Added subsystem to the subject line.
- Revised the explanation.
- Link to v1: https://lore.kernel.org/all/20260703144726.14808-1-vadim@cirque.com/
drivers/hid/hid-ids.h | 1 +
drivers/hid/i2c-hid/i2c-hid-core.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 1059922baaac..496589277bd5 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -334,6 +334,7 @@
#define I2C_VENDOR_ID_CIRQUE 0x0488
#define I2C_PRODUCT_ID_CIRQUE_1063 0x1063
+#define I2C_PRODUCT_ID_CIRQUE_D0C1 0xD0C1
#define USB_VENDOR_ID_CJTOUCH 0x24b8
#define USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0020 0x0020
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 3adb16366e93..63004bcbfa71 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -136,6 +136,8 @@ static const struct i2c_hid_quirks {
I2C_HID_QUIRK_BAD_INPUT_SIZE },
{ I2C_VENDOR_ID_CIRQUE, I2C_PRODUCT_ID_CIRQUE_1063,
I2C_HID_QUIRK_NO_SLEEP_ON_SUSPEND },
+ { I2C_VENDOR_ID_CIRQUE, I2C_PRODUCT_ID_CIRQUE_D0C1,
+ I2C_HID_QUIRK_NO_IRQ_AFTER_RESET },
/*
* Without additional power on command, at least some QTEC devices send garbage
*/
--
2.34.1
prev parent reply other threads:[~2026-07-08 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 14:47 [PATCH] Add a quirk for a Cirque I2C device Vadim Klishko
2026-07-08 0:31 ` Vadim Klishko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708003108.20288-1-vadim@cirque.com \
--to=vadim@cirque.corp-partner.google.com \
--cc=AJ_Cheng@compal.com \
--cc=CindyXT_Wang@compal.com \
--cc=andy.hung@cirque.com \
--cc=andy.hung@cirque.corp-partner.google.com \
--cc=bentiss@kernel.org \
--cc=dianders@chromium.org \
--cc=frank.chen@cirque.com \
--cc=jikos@kernel.org \
--cc=kenkinming2002@gmail.com \
--cc=kevinchou@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=superm1@kernel.org \
--cc=treapking@chromium.org \
--cc=vadim@cirque.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox