From: Miles Krause via B4 Relay <devnull+mileskrause5200.gmail.com@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Miles Krause <mileskrause5200@gmail.com>
Subject: [PATCH] Input: qt1050 - name calibration status bit
Date: Fri, 10 Jul 2026 21:09:02 -0400 [thread overview]
Message-ID: <20260710-qt1050-calibration-status-bit-v1-1-e4f7d1d797b6@gmail.com> (raw)
From: Miles Krause <mileskrause5200@gmail.com>
Detection status bit 7 indicates that a calibration cycle is in
progress. Define a name for the bit and use it in the polling
condition instead of an open-coded shift and comparison.
No functional change.
Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Compile-tested on x86_64 with:
make O=out allmodconfig
make O=out W=1 drivers/input/keyboard/qt1050.o
Sparse-tested with:
make O=out-sparse allmodconfig
make O=out-sparse C=1 CHECK=sparse drivers/input/keyboard/qt1050.o
---
drivers/input/keyboard/qt1050.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
index f9f480c91032..2371ac027aab 100644
--- a/drivers/input/keyboard/qt1050.c
+++ b/drivers/input/keyboard/qt1050.c
@@ -27,7 +27,8 @@
#define QT1050_FW_VERSION 0x01
/* Detection status */
-#define QT1050_DET_STATUS 0x02
+#define QT1050_DET_STATUS 0x02
+#define QT1050_DET_STATUS_CALIBRATE BIT(7)
/* Key status */
#define QT1050_KEY_STATUS 0x03
@@ -498,7 +499,8 @@ static int qt1050_probe(struct i2c_client *client)
return err;
}
err = regmap_read_poll_timeout(ts->regmap, QT1050_DET_STATUS, status,
- status >> 7 == 1, 10000, 200000);
+ status & QT1050_DET_STATUS_CALIBRATE,
+ 10000, 200000);
if (err) {
dev_err(dev, "Calibration failed: %d\n", err);
return err;
---
base-commit: c8f174900926d3b58cd048ac33b4cbb3de419bfe
change-id: 20260710-qt1050-calibration-status-bit-0b2e479ffd4b
Best regards,
--
Miles Krause <mileskrause5200@gmail.com>
next reply other threads:[~2026-07-11 1:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 1:09 Miles Krause via B4 Relay [this message]
2026-07-11 1:19 ` [PATCH] Input: qt1050 - name calibration status bit sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710-qt1050-calibration-status-bit-v1-1-e4f7d1d797b6@gmail.com \
--to=devnull+mileskrause5200.gmail.com@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mileskrause5200@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox