From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1B963BBFB3; Fri, 10 Jul 2026 21:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718914; cv=none; b=LII1pecItFSec2yk4pqT/dFyEDnmJ/UqL5rDm2JVs9HbUF7kF2BPBkfBbGgOJ1LFPCujBHmQj+nHwr+QkKMNgtj312fxY6uE9HrQCsbM0/AmHEXX1tan/NOgS4qGlnZfHE6KEXwATQFF36zMD3zCPhUcXl717/KpLmJnP8q1Hks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718914; c=relaxed/simple; bh=UEriDjcVIZMjDfM6l4Pq1kVK76YVfwC4g5Lv+iuLTm8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=o53YY667QB7tI8bTekU8fsycE4ESU2KMeTWfhhjZg/TDKOU2KPgd1Bsva1Q2KWqcIcjwv5QW11ZC5tsbNgGu69vqRC6GeVJLB67ZZ4dHR81SnFacdZ6cOm3dWLYlq4oHwjC3puQDNB5uAVJjci2FkhzWvzWBp7P3akEBO12u53A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e9BFdyNr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e9BFdyNr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 573251F00A3A; Fri, 10 Jul 2026 21:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783718913; bh=sZbIHxZdHMUwSUkMQi5RMlFurBlSnpGea15ztHC/eOU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e9BFdyNrgK+jsJpBldZxxlEEdxUeBHlmr8mWldf3Ygr7mQbGq8ka4PNnlLruLDtMl 2CJdgxowQX1tF0YZoKh+2/REbSxkHN5tdeMKfy3vl9SQX8BywTi094jISJW8msWdx0 dJoQnSC/qIGeAfdUxwIAoC9xJoAFHKzj23bcDhnp7aIR4d/AJgqttMpfsZZxrr+bon konhyJGq77vg4DKDaOkwFTD6vstpYJ4rc9+NE6T4uTjAExMwPrS3ZDd7FQHZzmpdj+ AXBdJP7AUO/VK1YbiK4LzOZlRWs6GalmCPLxIzSih1IoAUm7UuNVFbp2W5wTs85SBm iYqmUTnNunaDg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 5/6] [v6] x86/olpc: select GPIOLIB_LEGACY Reply-To: sashiko-reviews@lists.linux.dev To: "Arnd Bergmann" Cc: linux-input@vger.kernel.org, linux-leds@vger.kernel.org, lee@kernel.org, dmitry.torokhov@gmail.com In-Reply-To: <20260710211854.1371746-6-arnd@kernel.org> References: <20260710211854.1371746-1-arnd@kernel.org> <20260710211854.1371746-6-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 10 Jul 2026 21:28:32 +0000 Message-Id: <20260710212833.573251F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Replacing `#include ` with `#include ` causes a fatal compile error because the new header file does not ex= ist in the kernel tree. -- --- Patch [5]: [PATCH 5/6] [v6] x86/olpc: select GPIOLIB_LEGACY --- commit dfd246b7263a8d5eeb27b20b07f4d9310db7a8d6 Author: Arnd Bergmann x86/olpc: select GPIOLIB_LEGACY This commit selects CONFIG_GPIOLIB_LEGACY for the OLPC platform to resolve implicit function declaration errors for legacy GPIO functions. It also updates the audio driver Kconfig to depend on GPIOLIB_LEGACY or !OLPC. > diff --git a/arch/x86/platform/olpc/olpc-xo1-sci.c b/arch/x86/platform/ol= pc/olpc-xo1-sci.c > index 30751b42d54ef..a5b47960ba32e 100644 > --- a/arch/x86/platform/olpc/olpc-xo1-sci.c > +++ b/arch/x86/platform/olpc/olpc-xo1-sci.c > @@ -9,7 +9,7 @@ > =20 > #include > #include > -#include > +#include [Severity: Low] Does this header actually exist in the kernel tree? Compiling this file with CONFIG_OLPC enabled appears to result in a fatal No such file or directory error because include/linux/gpio/legacy.h is missing. > #include > #include [ ... ] > diff --git a/sound/pci/cs5535audio/cs5535audio_olpc.c b/sound/pci/cs5535a= udio/cs5535audio_olpc.c > index 122170a410d9e..cfdcc5bf4341e 100644 > --- a/sound/pci/cs5535audio/cs5535audio_olpc.c > +++ b/sound/pci/cs5535audio/cs5535audio_olpc.c > @@ -9,7 +9,7 @@ > #include > #include > #include > -#include > +#include [Severity: Low] Similarly, will this cause a build failure here for the same missing header reason? > =20 > #include --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260710211854.1371= 746-1-arnd@kernel.org?part=3D5