Linux Input/HID development
 help / color / mirror / Atom feed
From: Andre Eikmeyer <dev@deq.rocks>
To: sashiko-reviews@lists.linux.dev
Cc: Andre Eikmeyer <dev@deq.rocks>,
	linux-input@vger.kernel.org, jikos@kernel.org,
	bentiss@kernel.org, gargaditya08@live.com,
	dmitry.torokhov@gmail.com
Subject: Re: [PATCH 2/2] HID: apple: use the standard keyboard backlight LED name
Date: Sat, 18 Jul 2026 17:00:52 +0200	[thread overview]
Message-ID: <20260718150106.7774-2-dev@deq.rocks> (raw)
In-Reply-To: <20260718123641.DA2FF1F000E9@smtp.kernel.org>

Thanks. This is a valid pre-existing issue.

The multi-byte fields in these raw HID reports are little-endian. The
backlight configuration values should be converted with le16_to_cpu(), and
the brightness and transition rate should be written with cpu_to_le16().

This predates the LED naming change, so I will address it in a separate
patch rather than mix it into this one.


  reply	other threads:[~2026-07-18 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 12:15 [PATCH 1/2] HID: apple: preserve keyboard backlight across T2 resume Andre Eikmeyer
2026-07-18 12:15 ` [PATCH 2/2] HID: apple: use the standard keyboard backlight LED name Andre Eikmeyer
2026-07-18 12:36   ` sashiko-bot
2026-07-18 15:00     ` Andre Eikmeyer [this message]
2026-07-18 12:35 ` [PATCH 1/2] HID: apple: preserve keyboard backlight across T2 resume sashiko-bot
2026-07-18 15:00   ` Andre Eikmeyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718150106.7774-2-dev@deq.rocks \
    --to=dev@deq.rocks \
    --cc=bentiss@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gargaditya08@live.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox