From: Rob Herring <robh@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Eduard Bostina <egbostina@gmail.com>,
conor+dt@kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, lee@kernel.org,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH v3 3/4] dt-bindings: input: Convert TI TPS65217 power button to DT schema
Date: Tue, 21 Jul 2026 10:02:47 -0500 [thread overview]
Message-ID: <20260721150247.GA3820183-robh@kernel.org> (raw)
In-Reply-To: <20260721113408.655C01F000E9@smtp.kernel.org>
On Tue, Jul 21, 2026 at 11:34:07AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] Missing NULL check on `dev_get_regmap` can lead to a kernel panic in the IRQ handler.
> - [High] The driver incorrectly masks `platform_get_irq()` error codes with `-EINVAL`, breaking probe deferral.
> --
Why is sashiko pointing out driver issues on a DT binding patch? This
series doesn't even touch the driver. This seems to be a re-occurring
problem.
Rob
next prev parent reply other threads:[~2026-07-21 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 11:21 [PATCH v3 0/4] dt-bindings: Convert TI TPS65217 to DT schema Eduard Bostina
2026-07-21 11:21 ` [PATCH v3 1/4] ARM: dts: ti: am335x-guardian: Drop unused isink-en property Eduard Bostina
2026-07-21 11:24 ` sashiko-bot
2026-07-21 11:21 ` [PATCH v3 2/4] ARM: dts: Rename the TPS65217 regulator nodes Eduard Bostina
2026-07-21 11:26 ` sashiko-bot
2026-07-21 11:21 ` [PATCH v3 3/4] dt-bindings: input: Convert TI TPS65217 power button to DT schema Eduard Bostina
2026-07-21 11:34 ` sashiko-bot
2026-07-21 15:02 ` Rob Herring [this message]
2026-07-21 11:21 ` [PATCH v3 4/4] dt-bindings: leds: backlight: Convert TPS65217 " Eduard Bostina
2026-07-21 11:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721150247.GA3820183-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=egbostina@gmail.com \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox