Re: [PATCH 2/2] iio: gyro: hid-sensor-gyro-3d: Use dev_err_probe()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The patch drops the `return` statement when handling failures from `gyro_3d_parse_report()`, causing the probe function to continue instead of aborting.
--

--- Patch [2]: [PATCH 2/2] iio: gyro: hid-sensor-gyro-3d: Use dev_err_probe() ---
commit 9e2d893e70018e9931c8153d83e07fffde994281
Author: Sanjay Chitroda <sanjayembeddedse@gmail.com>

iio: gyro: hid-sensor-gyro-3d: Use dev_err_probe()

This commit replaces dev_err() calls with dev_err_probe() during the driver
probe to simplify error code handling and nicely manage deferred probes.

> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> index bcf53e2677015..48540c9a097c5 100644
> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
[ ... ]
> @@ -297,10 +296,8 @@ static int hid_gyro_3d_probe(struct platform_device *pdev)
>  	ret = gyro_3d_parse_report(pdev, hsdev,
>  				   (struct iio_chan_spec *)indio_dev->channels,
>  				   HID_USAGE_SENSOR_GYRO_3D, gyro_state);
> -	if (ret) {
> -		dev_err(&pdev->dev, "failed to setup attributes\n");
> -		return ret;
> -	}
> +	if (ret)
> +		dev_err_probe(dev, ret, "failed to setup attributes\n");

[Severity: High]
Does this accidentally drop the return statement?

If gyro_3d_parse_report() fails, hid_gyro_3d_probe() will now continue
executing instead of aborting. This could lead to an incompletely initialized
IIO device being registered.

Should this also be returning dev_err_probe(dev, ret, ...), similar to the
previous error handling block in this function?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-24-july-hid-gyro-dev-log-clenaup-v1-0-0c932b77104a@gmail.com?part=2