Linux Input/HID development
 help / color / mirror / Atom feed
From: Zhefu Zhang <a723356@gmail.com>
To: Andrew Zhou <zhoulol888@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhefu Zhang <a723356@gmail.com>
Subject: Re: [PATCH] Input: i8042 - add Xiaomi Book Pro 14 to dumbkbd quirk list
Date: Sat,  1 Aug 2026 22:30:12 +1200	[thread overview]
Message-ID: <20260801103012.4142-1-a723356@gmail.com> (raw)
In-Reply-To: <20260718122437.11112-1-zhoulol888@gmail.com>

Hi Andrew,

I have the same machine and sent an alternative fix today, "Input: atkbd -
skip deactivate for Xiaomi Book Pro 14's internal keyboard".

On this machine atkbd deactivates the keyboard at the end of atkbd_probe();
the EC acknowledges the ATKBD_CMD_ENABLE issued afterwards but never resumes
scanning, so no key is ever reported. Setting the existing
atkbd_deactivate_fixup quirk avoids the deactivation and the internal
keyboard works.

Compared to SERIO_QUIRK_DUMBKBD this also keeps the keyboard LED working:
with dumbkbd the driver never writes to the keyboard at all, so the Caps Lock
LED is not available.

Tested on Xiaomi Book Pro 14, board TM2424.

Thanks,
Zhefu Zhang

  parent reply	other threads:[~2026-08-01 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 12:24 [PATCH] Input: i8042 - add Xiaomi Book Pro 14 to dumbkbd quirk list Andrew Zhou
2026-08-01  8:24 ` Andrew Zhou
2026-08-01 10:30 ` Zhefu Zhang [this message]
2026-08-01 11:17   ` Andrew Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260801103012.4142-1-a723356@gmail.com \
    --to=a723356@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhoulol888@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox