Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: DevExalt <exalt.dev.team@gmail.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v6] HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531)
Date: Sun, 02 Aug 2026 11:58:11 +0000	[thread overview]
Message-ID: <20260802115811.E18D01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260802115009.90840-1-exalt.dev.team@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add specific device IDs and remove quirks, but the patch does not modify any device ID tables or quirks file.
--

--- Patch [1]: [PATCH v6] HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531) ---
commit 2283951914fe82c9f82d572a2c1e9090262e500b
Author: Baraa Atta (Dev Exalt) <exalt.dev.team@gmail.com>

HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531)

Add support in the Logitech HID++ driver for the HID++ Multi-Platform
feature (0x4531), which enables HID++ devices to adjust their behavior
based on the host operating system.

> This patch:
>  * Adds device IDs for MX Keys S (046d) and Casa Keys (046d).

[Severity: Medium]
The commit message claims to add specific device IDs for MX Keys S and Casa
Keys, and the v6 changelog mentions removing them from hid-quirks.c, but the
patch diff does not modify any device ID tables or quirks files. Were these
changes accidentally dropped during a rebase or intended for a separate patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802115009.90840-1-exalt.dev.team@gmail.com?part=1

  reply	other threads:[~2026-08-02 11:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  8:08 [PATCH v2] HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531) DevExalt
2026-06-25  8:18 ` sashiko-bot
2026-06-30  9:48 ` [PATCH v3] " DevExalt
2026-06-30 10:13   ` sashiko-bot
2026-07-01  6:30 ` [PATCH v4] " DevExalt
2026-07-01  6:43   ` sashiko-bot
2026-07-01  7:37 ` [PATCH v5] " DevExalt
2026-07-15 14:01   ` dev exalt
2026-07-27 14:04   ` Bastien Nocera
2026-07-29 15:02   ` Bastien Nocera
2026-08-02 11:50 ` [PATCH v6] " DevExalt
2026-08-02 11:58   ` sashiko-bot [this message]
2026-08-02 12:01 ` [PATCH v7] " DevExalt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260802115811.E18D01F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=exalt.dev.team@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox