Linux Input/HID development
 help / color / mirror / Atom feed
From: Alec Hall <signshop.alec@gmail.com>
To: jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, pepemontfort@gmail.com,
	Alec Hall <signshop.alec@gmail.com>
Subject: Re: [PATCH 0/3] HID: Apple Magic Keyboard/Trackpad battery over Bluetooth
Date: Mon,  3 Aug 2026 01:17:06 -0400	[thread overview]
Message-ID: <20260803051707.53252-1-signshop.alec@gmail.com> (raw)
In-Reply-To: <20260714101235.99447-1-signshop.alec@gmail.com>

Gentle ping on this series, posted three weeks ago. No rush intended -- I
am mostly checking it has not fallen through a crack, and asking whether
anything is wanted from me before it can be looked at.

Some context that has accumulated on the list since, in case it affects
how you would like to sequence things:

Jose Villaseñor Montfort has three fixes in flight touching the same
driver and the generic battery path. I have reviewed and tested all
three on a Magic Keyboard and a Magic Trackpad 2 over both USB and
Bluetooth:

  HID: magicmouse: prevent unbounded recursion in magicmouse_raw_event()
    https://lore.kernel.org/linux-input/20260715053526.574725-1-pepemontfort@gmail.com/
  HID: magicmouse: avoid NULL pointer deref when there is no input device
    https://lore.kernel.org/linux-input/20260728184059.688513-1-pepemontfort@gmail.com/
  HID: magicmouse: do not keep a stale msc->input if no input is claimed
    https://lore.kernel.org/linux-input/20260729041557.1185819-1-pepemontfort@gmail.com/

Patch 3/3 of this series touches the top of magicmouse_raw_event(), which
the recursion fix splits into a wrapper and an inner function. Whichever
lands first, the other is a one-hunk rebase; I have both applied together
here and can respin this series on top of his at any point -- just say
which order you would prefer, and I will send a v2 rather than leave you
to resolve it.

There is also a generic fix from him for the battery query path:

  HID: input: read battery capacity from its actual report offset
    https://lore.kernel.org/linux-input/20260728201309.776026-1-pepemontfort@gmail.com/

That one is complementary to this series rather than overlapping: it
corrects where hidinput_query_battery_capacity() reads the capacity from,
while this series changes which devices get a solicited fetch at all.
Worth noting it also improves the behaviour of this series -- until the
first battery report is parsed, capacity reads go through that query
path, so on my trackpad the power supply reads the flags byte for about
a minute after a Bluetooth reconnect before settling on the real value.

Happy to send a v2 with any changes you would like. Thanks for your time.

Alec

      parent reply	other threads:[~2026-08-03  5:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 10:12 [PATCH 0/3] HID: Apple Magic Keyboard/Trackpad battery over Bluetooth Alec Hall
2026-07-14 10:12 ` [PATCH 1/3] HID: apple: report Magic Keyboard " Alec Hall
2026-07-14 10:12 ` [PATCH 2/3] HID: magicmouse: report " Alec Hall
2026-07-14 10:12 ` [PATCH 3/3] HID: magicmouse: report charge status " Alec Hall
2026-07-14 10:25   ` sashiko-bot
2026-07-14 17:17     ` Alec Hall
2026-07-15  6:20   ` Jose Villaseñor Montfort
2026-07-15 19:22     ` Alec Hall
2026-07-15 20:03   ` Jose Villaseñor Montfort
2026-07-15 22:18     ` Alec Hall
2026-08-03  5:17 ` Alec Hall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803051707.53252-1-signshop.alec@gmail.com \
    --to=signshop.alec@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pepemontfort@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox