From: Chen Changcheng <chenchangcheng@kylinos.cn>
To: Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <bentiss@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ccc194101@163.com, Chen Changcheng <chenchangcheng@kylinos.cn>
Subject: [PATCH 0/2] HID: alps: fix DualPoint Stick input device lifecycle
Date: Fri, 14 Aug 2026 15:06:19 +0800 [thread overview]
Message-ID: <20260814070621.68557-1-chenchangcheng@kylinos.cn> (raw)
This series fixes two issues in the hid-alps driver related to the
separate input device ("DualPoint Stick", input2) that is allocated in
alps_input_configured() but not registered in hdev->inputs:
Patch 1: input2 is never unregistered on remove.
The driver struct has no .remove handler, and input2 is not
tracked in hdev->inputs, so the default remove path
(hid_hw_stop -> hidinput_disconnect) skips it. Result: every
device removal leaks one struct input_dev.
Patch 2: data->input2 is stored before registration, and on
registration failure the dangling pointer is read by
u1_raw_event() (URBs are already active because
alps_input_configured() calls hid_hw_open() before
allocating input2) -> use-after-free.
Both patches apply against linux.git master at 7.2-rc7.
---
Chen Changcheng (2):
HID: alps: unregister DualPoint Stick input device on remove
HID: alps: fix use-after-free on input2 registration failure
drivers/hid/hid-alps.c | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
Thanks,
Chen Changcheng
--
2.25.1
next reply other threads:[~2026-08-14 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 7:06 Chen Changcheng [this message]
2026-08-14 7:06 ` [PATCH 1/2] HID: alps: unregister DualPoint Stick input device on remove Chen Changcheng
2026-08-14 7:23 ` sashiko-bot
2026-08-14 7:06 ` [PATCH 2/2] HID: alps: fix use-after-free on input2 registration failure Chen Changcheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814070621.68557-1-chenchangcheng@kylinos.cn \
--to=chenchangcheng@kylinos.cn \
--cc=bentiss@kernel.org \
--cc=ccc194101@163.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox