Re: [PATCH v4 07/12] Input: xbox_gip - Add security implementation from xone

[Eric Biggers <ebiggers@kernel.org>]

On Fri, Aug 21, 2026 at 07:11:31PM -0700, Vicki Pfau wrote:
> +int gip_security_start_handshake(struct gip_security *security)
> +{
> +	struct shash_desc *shash_transcript, *shash_prf;
> +
> +	if (!security->shash_transcript) {
> +		shash_transcript = gip_security_alloc_shash("sha256");
> +		if (IS_ERR(shash_transcript))
> +			return PTR_ERR(shash_transcript);
> +
> +		security->shash_transcript = shash_transcript;
> +	}
> +
> +	if (!security->shash_prf) {
> +		shash_prf = gip_security_alloc_shash("hmac(sha256)");
> +		if (IS_ERR(shash_prf)) {
> +			crypto_free_shash(shash_transcript->tfm);
> +			kfree(shash_transcript);
> +			security->shash_transcript = NULL;
> +			return PTR_ERR(shash_prf);
> +		}
> +
> +		security->shash_prf = shash_prf;
> +	}

There's no need to use crypto_shash.  Just call the SHA-256 and
HMAC-SHA256 functions (<crypto/sha2.h>) directly.

- Eric