From: Ricardo Ribalda <ribalda@chromium.org>
To: "Derek J. Clark" <derekjohn.clark@gmail.com>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH] HID: Merge duplicated documentation for Lenovo Legion
Date: Mon, 31 Aug 2026 11:12:11 +0000 [thread overview]
Message-ID: <20260831-lenovo-go-v1-1-e9526e88ee09@chromium.org> (raw)
Lenovo Legion Go and Lenovo Legion Go S share some definitions. Merge them in
sysfs-driver-hid-lenovo-go to avoid this warning:
WARNING] /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode is defined 2 times: ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:364; ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:234
[WARNING] /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode_index is defined 2 times: ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:373; ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:243
[WARNING] /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled is defined 2 times: ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:636; ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:252
[WARNING] /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled_index is defined 2 times: ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:645; ./Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:261
Cc: stable@vger.kernel.org
Fixes: 168c91839139 ("HID: Add documentation for Lenovo Legion Go drivers")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
.../ABI/testing/sysfs-driver-hid-lenovo-go | 11 +++----
.../ABI/testing/sysfs-driver-hid-lenovo-go-s | 35 ----------------------
2 files changed, 6 insertions(+), 40 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go b/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go
index c8221373ef76..f3ba3504939d 100644
--- a/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go
+++ b/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go
@@ -364,11 +364,12 @@ Description: This displays the available options for the mode attribute.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode
Date: April 2026
Contact: linux-input@vger.kernel.org
-Description: This controls the behavior of built in chord combinations.
+Description: This controls the behavior of built-in chord combinations.
+ For the Legion Go S, this controls the touchpad's operating mode.
Values are windows or linux.
- Applies to Lenovo Legion Go and Go 2 line of handheld devices.
+ Applies to Lenovo Legion Go, Go 2, and Go S line of handheld devices.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode_index
Date: April 2026
@@ -377,7 +378,7 @@ Description: This displays the available options for the os_mode attribute.
Values are windows or linux.
- Applies to Lenovo Legion Go and Go 2 line of handheld devices.
+ Applies to Lenovo Legion Go, Go 2, and Go S line of handheld devices.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/product_version
Date: April 2026
@@ -640,7 +641,7 @@ Description: This controls enabling or disabling the touchpad.
Values are true, false.
- Applies to Lenovo Legion Go and Go 2 line of handheld devices.
+ Applies to Lenovo Legion Go, Go 2, and Go S line of handheld devices.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled_index
Date: April 2026
@@ -649,7 +650,7 @@ Description: This displays the available options for the touchpad/enabled attrib
Values are true, false.
- Applies to Lenovo Legion Go and Go 2 line of handheld devices.
+ Applies to Lenovo Legion Go, Go 2, and Go S line of handheld devices.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/vibration_enabled
Date: April 2026
diff --git a/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s b/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s
index 4d317074bb7e..218164cfe544 100644
--- a/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s
+++ b/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s
@@ -231,41 +231,6 @@ Description: This displays the available options for the mouse/step attribute.
Applies to Lenovo Legion Go S line of handheld devices.
-What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode
-Date: April 2026
-Contact: linux-input@vger.kernel.org
-Description: This controls which value is used for the touchpads operating mode.
-
- Values are windows or linux.
-
- Applies to Lenovo Legion Go S line of handheld devices.
-
-What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode_index
-Date: April 2026
-Contact: linux-input@vger.kernel.org
-Description: This displays the available options for the os_mode attribute.
-
- Values are windows or linux.
-
- Applies to Lenovo Legion Go S line of handheld devices.
-
-What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled
-Date: April 2026
-Contact: linux-input@vger.kernel.org
-Description: This controls enabling or disabling the built-in touchpad.
-
- Values are true or false.
-
- Applies to Lenovo Legion Go S line of handheld devices.
-
-What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled_index
-Date: April 2026
-Contact: linux-input@vger.kernel.org
-Description: This displays the available options for the touchpad/enabled attribute.
-
- Values are true or false.
-
- Applies to Lenovo Legion Go S line of handheld devices.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/linux_mode
Date: April 2026
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260831-lenovo-go-7b4ec4bf0cd5
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
reply other threads:[~2026-08-31 11:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831-lenovo-go-v1-1-e9526e88ee09@chromium.org \
--to=ribalda@chromium.org \
--cc=derekjohn.clark@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox