From: sashiko-bot@kernel.org
To: "Breno Rodrigues Alves" <breno3011alves@gmail.com>
Cc: dmitry.torokhov@gmail.com, linux-pci@vger.kernel.org,
media-ci@linuxtv.org, linux-input@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] Kconfig: purge twenty-nine legacy ghost options
Date: Fri, 04 Sep 2026 23:26:34 +0000 [thread overview]
Message-ID: <20260904232634.D84541F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904231240.87106-1-breno3011alves@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing USB_CONFIGFS_F_TCM prevents building the TCM target fabric function for ConfigFS gadgets.
--
commit a0c8218d80f352a73463cc7e47871658dffb0211
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>
Kconfig: purge twenty-nine legacy ghost options
This commit removes several Kconfig options that were deemed unused, obsolete,
or replaced by other options. Among the removed options is
USB_CONFIGFS_F_TCM.
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 76521555e3c14..f05eb1bb7b6c0 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -492,20 +492,6 @@ config USB_CONFIGFS_F_PRINTER
> For more information, see Documentation/usb/gadget_printer.rst
> which includes sample code for accessing the device file.
>
> -config USB_CONFIGFS_F_TCM
> - bool "USB Gadget Target Fabric"
> - depends on TARGET_CORE
> - depends on USB_CONFIGFS
> - select USB_LIBCOMPOSITE
> - select USB_F_TCM
> - help
> - This fabric is a USB gadget component. Two USB protocols are
> - supported that is BBB or BOT (Bulk Only Transport) and UAS
> - (USB Attached SCSI). BOT is advertised on alternative
> - interface 0 (primary) and UAS is on alternative interface 1.
> - Both protocols can work on USB2.0 and USB3.0.
> - UAS utilizes the USB 3.0 feature called streams support.
> -
[Severity: High]
Does removing this option prevent building the TCM target fabric function for
ConfigFS gadgets?
The commit message states "the real fabric always built via USB_F_TCM", but
USB_F_TCM is defined in drivers/usb/gadget/Kconfig as:
config USB_F_TCM
tristate
Since it has no prompt string, it cannot be selected by the user manually.
With USB_CONFIGFS_F_TCM removed, the only remaining configuration path that
selects USB_F_TCM is USB_GADGET_TARGET in drivers/usb/gadget/legacy/Kconfig.
If a user configures a kernel to use USB gadgets via ConfigFS and disables
legacy gadgets, it appears they can no longer enable the TCM target fabric.
Will this silently drop TCM gadget support for ConfigFS users?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904231240.87106-1-breno3011alves@gmail.com?part=1
next prev parent reply other threads:[~2026-09-04 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 23:12 [PATCH] Kconfig: purge twenty-nine legacy ghost options Breno Rodrigues Alves
2026-09-04 23:26 ` sashiko-bot [this message]
2026-09-05 9:46 ` Arnd Bergmann
2026-09-05 11:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904232634.D84541F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=breno3011alves@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox