Re: [PATCH v6 02/12] Input: xpad - Remove Xbox One support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `flags` field in `struct xpad_device` is now unused and should be removed.
- [Low] Documentation Typo: 'Protocl' instead of 'Protocol'.
--

commit 30879d88695dc1f5b4aa4e33ed67c80e554e4b56
Author: Vicki Pfau <vi@endrift.com>

Input: xpad - Remove Xbox One support

This commit removes Xbox One controller support from the xpad driver.
It notes that this functionality is fully superseded by the xbox_gip driver,
which specializes in the Xbox One Gaming Input Protocol.

> diff --git a/Documentation/input/devices/xpad.rst b/Documentation/input/devices/xpad.rst
> index a480bc781565e..fd2afdd7b4059 100644
> --- a/Documentation/input/devices/xpad.rst
> +++ b/Documentation/input/devices/xpad.rst
> @@ -2,19 +2,19 @@
>  xpad - Linux USB driver for Xbox compatible controllers
>  =======================================================
>  
> -This driver exposes all first-party and third-party Xbox compatible
> -controllers. It has a long history and has enjoyed considerable usage
> -as Windows' xinput library caused most PC games to focus on Xbox
> -controller compatibility.
> +This driver exposes all first-party and third-party Xbox and Xbox 360
> +compatible controllers. It has a long history and has enjoyed considerable
> +usage as Windows' xinput library caused most PC games to focus on Xbox
> +controller compatibility. Xbox One/Series controller support has been
> +superseded by the xbox_gip driver, which specializes in the Gaming Input
> +Protocl that is introduced on the Xbox One.

[Severity: Low]
This isn't a bug, but there's a typo in the documentation: Protocl instead of
Protocol.

> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index feb8f368f834e..206007e0cafb6 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
[ ... ]
> @@ -2080,18 +1462,13 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
>  	xpad->mapping = xpad_device[i].mapping;
>  	xpad->xtype = xpad_device[i].xtype;
>  	xpad->name = xpad_device[i].name;
> -	if (xpad_device[i].flags & FLAG_DELAY_INIT)
> -		xpad->delay_init = true;
>  
> -	xpad->packet_type = PKT_XB;
>  	INIT_WORK(&xpad->work, xpad_presence_work);

[Severity: Low]
Since the only flag (FLAG_DELAY_INIT) and its usage here in xpad_probe() have
been removed, is it intended to leave the flags field inside the definition
of struct xpad_device?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908032145.2118234-1-vi@endrift.com?part=2