From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Garcia <miguelgarciaroman8@gmail.com>
Cc: stable@vger.kernel.org, dmitry.torokhov@gmail.com,
pengpeng@iscas.ac.cn, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6.6.y] Input: aiptek - validate raw macro indices before updating state
Date: Tue, 8 Sep 2026 12:51:44 +0200 [thread overview]
Message-ID: <2026090833-mutt-whiny-242e@gregkh> (raw)
In-Reply-To: <20260907185001.1567957-1-miguelgarciaroman8@gmail.com>
On Mon, Sep 07, 2026 at 08:50:01PM +0200, Miguel Garcia wrote:
> From: Pengpeng Hou <pengpeng@iscas.ac.cn>
>
> aiptek_irq() derives macro key indices directly from tablet reports and
> then uses them to index macroKeyEvents[]. Report types 4 and 5 also save
> the derived value in aiptek->lastMacro and later use that state to
> release the previous key.
>
> Validate the raw macro index once before it enters that state machine, so
> lastMacro only ever stores an in-range macro key. Keep direct bounds
> checks for report type 6, which reads the macro number from the packet
> body and uses it immediately.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> Link: https://patch.msgid.link/20260329001711.88076-1-pengpeng@iscas.ac.cn
> [dtor: fix macro fallback in report 5s to use -1]
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> (cherry picked from commit 95dffe32a66cbed07fbfa7afed39d56d5014e04f)
> Signed-off-by: Miguel Garcia <miguelgarciaroman8@gmail.com>
> ---
> drivers/input/tablet/aiptek.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
What about 6.12.y and 6.18.y?
thanks,
greg k-h
next prev parent reply other threads:[~2026-09-08 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 18:50 [PATCH 6.6.y] Input: aiptek - validate raw macro indices before updating state Miguel Garcia
2026-09-07 19:02 ` sashiko-bot
2026-09-08 10:51 ` Greg KH [this message]
2026-09-09 10:28 ` Miguel García Román
2026-09-09 10:29 ` [PATCH 6.12.y] " Miguel García Román
2026-09-09 10:51 ` sashiko-bot
2026-09-09 10:29 ` [PATCH 6.18.y] " Miguel García Román
2026-09-08 22:39 ` [PATCH 6.6.y] " Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090833-mutt-whiny-242e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguelgarciaroman8@gmail.com \
--cc=pengpeng@iscas.ac.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox