Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-input@vger.kernel.org,
	lee@kernel.org, conor+dt@kernel.org,
	linux-watchdog@vger.kernel.org, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, robh@kernel.org, mfd@lists.linux.dev,
	dmitry.torokhov@gmail.com, linux-hwmon@vger.kernel.org,
	linux-rtc@vger.kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	media-ci@linuxtv.org
Subject: Re: [PATCH 11/14] mfd: remove unused wm8350 driver
Date: Wed, 09 Sep 2026 13:41:02 +0000	[thread overview]
Message-ID: <20260909134103.157A01F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260909132153.1596191-12-arnd@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale documentation references to the removed wm8350 driver.
--

commit 180d02f3fe78e14ad7acf9b29e2590c4c4ee3a29
Author: Arnd Bergmann <arnd@arndb.de>

mfd: remove unused wm8350 driver

This commit removes the wm8350 driver entirely, as it relied on platform
data probing for development boards that have been dropped from the kernel.
It removes the core driver along with its hwmon, gpio, led, power,
regulator, rtc, watchdog, and sound codec components.

> mfd: remove unused wm8350 driver
> 
> This driver was used on the i.MX31 ADS reference board from Freescale
> and the smdk6410 reference board from Samsung. Both used platform_data
> based driver probing and are now gone from the kernel.
> 
> Since probing with devicetree has never been supported by wm8350,
> it is clear that nothing can use the driver on an upstream kernel,
> and it is unlikely that anyone is still interested in a devicetree
> conversion, so remove it.

[Severity: Low]
Since the wm8350 driver is being completely removed here, should we also
update the documentation files that still reference it as a working example? 

Currently, there are a few places left behind that point developers to the
removed driver code. For instance, in Documentation/scheduler/completion.rst
referencing wait_for_completion_interruptible_timeout:

    why (e.g. see drivers/mfd/wm8350-core.c wm8350_read_auxadc())::

And its Chinese translation in
Documentation/translations/zh_CN/scheduler/completion.rst:

    (例如,见drivers/mfd/wm8350-core.c wm8350_read_auxadc()::

Additionally, Documentation/sound/soc/jack.rst points to the removed codec:

    CODEC integrated jack detection can be see in the WM8350 driver.

Would it make sense to update these documents to point to a different,
active driver as an example to avoid confusing developers who might try
to look up the removed files?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=11

  parent reply	other threads:[~2026-09-09 13:41 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 13:21 [PATCH 00/14] mfd: unused driver purge Arnd Bergmann
2026-09-09 13:21 ` [PATCH 01/14] mfd: remove unused 88pm80x driver Arnd Bergmann
2026-09-09 13:37   ` sashiko-bot
2026-09-09 13:44   ` Alexandre Belloni
2026-09-11  7:24   ` Krzysztof Kozlowski
2026-09-09 13:21 ` [PATCH 02/14] mfd: remove unused rdc321x southbridge support Arnd Bergmann
2026-09-09 13:39   ` sashiko-bot
2026-09-09 20:28     ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 03/14] mfd: remove unused si476x driver Arnd Bergmann
2026-09-09 13:38   ` sashiko-bot
2026-09-09 13:21 ` [PATCH 04/14] mfd: remove unused wm8400 driver Arnd Bergmann
2026-09-09 13:27   ` Mark Brown
2026-09-09 13:33   ` sashiko-bot
2026-09-09 14:38   ` Charles Keepax
2026-09-09 13:21 ` [PATCH 05/14] mfd: remove unused adp5520 driver Arnd Bergmann
2026-09-09 13:37   ` sashiko-bot
2026-09-09 20:21     ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 06/14] mfd: remove unused da903x driver Arnd Bergmann
2026-09-09 13:39   ` sashiko-bot
2026-09-09 20:17     ` Arnd Bergmann
2026-09-09 15:46   ` Sebastian Reichel
2026-09-09 13:21 ` [PATCH 07/14] mfd: remove unused lp8788 driver Arnd Bergmann
2026-09-09 13:39   ` sashiko-bot
2026-09-09 20:14     ` Arnd Bergmann
2026-09-09 13:47   ` Alexandre Belloni
2026-09-09 15:46   ` Sebastian Reichel
2026-09-09 13:21 ` [PATCH 08/14] mfd: remove unused aat2870 driver Arnd Bergmann
2026-09-09 13:30   ` sashiko-bot
2026-09-09 13:21 ` [PATCH 09/14] mfd: remove unused lm3533 driver Arnd Bergmann
2026-09-09 13:35   ` sashiko-bot
2026-09-09 13:44   ` Johan Hovold
2026-09-09 14:47     ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 10/14] mfd: remove unused rc5t583 driver Arnd Bergmann
2026-09-09 13:39   ` sashiko-bot
2026-09-09 20:49     ` Arnd Bergmann
2026-09-09 13:48   ` Alexandre Belloni
2026-09-09 13:21 ` [PATCH 11/14] mfd: remove unused wm8350 driver Arnd Bergmann
2026-09-09 13:26   ` Mark Brown
2026-09-09 13:41   ` sashiko-bot [this message]
2026-09-09 14:39   ` Charles Keepax
2026-09-09 15:47   ` Sebastian Reichel
2026-09-09 13:21 ` [PATCH 12/14] mfd: remove unused mcp-sa11x0/ucb1x00 driver Arnd Bergmann
2026-09-09 13:48   ` sashiko-bot
2026-09-09 20:53     ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 13/14] mfd: remove unused menelaus driver Arnd Bergmann
2026-09-09 13:49   ` sashiko-bot
2026-09-09 20:46     ` Arnd Bergmann
2026-09-09 13:51   ` Alexandre Belloni
2026-09-09 13:21 ` [PATCH 14/14] mfd: remove unused iPaq micro driver Arnd Bergmann
2026-09-09 13:43   ` sashiko-bot
2026-09-09 20:58     ` Arnd Bergmann
2026-09-09 14:03 ` [PATCH 00/14] mfd: unused driver purge Bartosz Golaszewski
2026-09-09 17:26 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909134103.157A01F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lee@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox