From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f42.google.com (mail-oo2-f42.google.com [74.125.231.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F8E39A04D for ; Thu, 10 Sep 2026 03:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789010496; cv=none; b=K3IpIxpAgzXxrXuH62ow6NB9xMM+VI3ZTHhsEUF6wzCo/SkdnD6MBYTSoOvrJWBMUP9AiZR2Avk3aG8fkj1hjVGtEjMIMqnR0MDlxx7vfaQpoBliLGosgZEL+seRJRKfQ0U5bimQl7xXH82JdbIf7L20kWqpULh8LX08A1Po5TA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789010496; c=relaxed/simple; bh=Um74UX+MRF/9P0ke3riKZo7+21YZ3eMyq0VMLteOHVg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mbr0gB7FHatNHMwBmD5a9VwAE45mKsC4wf7JOBpWHZFk+IZ8ZT0LMSO99BW2rJoTwezRtby1+nEJet8eIE/yiIURhXMMG1Pc9ngxOJIsYTlL/O52i0LcPfwJpkcaVr9qXCl/DdQX3KO4HQvID/CIDnP9ZuA4SlBGVg27LZWn0rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j6RAp1Z4; arc=none smtp.client-ip=74.125.231.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j6RAp1Z4" Received: by mail-oo2-f42.google.com with SMTP id 46e09a7af769-801cb343a92so174937a34.1 for ; Wed, 09 Sep 2026 20:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789010493; x=1789615293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xO5C08EX71sX1hq1xlgBn85VpHzDdFalT8bt09irpJA=; b=j6RAp1Z413y0sYYZnJYJImC5XAQayzqOCxKJmSimUC43MB114oNgbG+w82A55PB5K5 GIwQ+2oyC+fWrGmVrVc7v0OcNZ1N9ZjObmwdLmdHpK6gFv1kIkl9No2O089wsA6ISert tSNOCGD0f5Ey6Z67MPY74/n9WveNoQmY6460smH8oSKBeD8JzAEsomQIGglMSjbo5Sdm KRV/k4WbVEUjz9sQjqBJuWOFpfa9SB+2xsKf8U+lxg+DEadiRdl/SL03NnbzI6C6Yw8O rOtkM7OoOfDuAbqv5wAWK34kPFUw2tIlD2WILyUyC5u9E9BwhmBhoS3cI04UmXbs8sf1 KSLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789010493; x=1789615293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xO5C08EX71sX1hq1xlgBn85VpHzDdFalT8bt09irpJA=; b=J/JeWm7arLQTD9xjO7NMRXYYC065mChy606gU81KqetgnNgN3PpJSD3WCxLskbnasX aYCVDeLIawIC/PisoYs/wK5YKcB0Fu3h2m7GWuncVv8xwv6tvGd7ulH62rAhdUWgGURL dR4EXB24vmGU7zBUVIDotYJBSI45XUjhT/XWXJWHFSPzjnTYNDdCMBzaRYbxRTT5p7r8 +W2F2vmGz2TD1TcRXlqpjBPyQ4fl9949uU4igslrs4ZV8850UZWlkoM/OYmcrke2cSDv aDNzpsW+OvJA+U6/ZmSBmX5YsIyV1Th8ODj86bQ+Dbv3eE4ZmJ1LPuE/aWhJ42T1aNEY oCxQ== X-Gm-Message-State: AFuF++lB+XjqOUF0hvycCmwFuj7YjEhM2aqDV7TvND7bBLK/TbdLsjKE 2zYTC5UCdffgUEBZkb/b86sJW6lQ7Z4TWzDAzz34mIJAQJAsuX9U61Io X-Gm-Gg: AYBFou1Uh4Kt4QBhPOYF0H+mejgl6u/BHMunXHGjYOkaR1Cej+PDfTqf5OyzVr1WOJr K8selTkywaziRnHggQO0hkbdkQwv2nNFEWD/4GnFQk8+8w3lerK4NMz2RE64Dmdn5FXzhJBrx5n NgbUgQWw+MPni148t9emcqNSI9bfbqwf96GTe6cjSTOXn551sQNfiF6jfofZRnCliYijg4s86A7 fGktEgcE3bii+dpqAX0Y0zRc/L1DVhjvIQ+Ku87b56oS1ehYU2DVFlR6mDdvm0uGO3WNZyJ4sl4 hwrFfoqWhSYD3i4btnUEBlVUCXnWryDwmi/Rtgp/+l+35ZuMImicQBaYmHkNHi5kECOLjnCJP9c g9kZyIT8h7OVDJaDSX2/im4xma6XHGX6QtQY2huRUobc+EMwVmeYNdAwwLFKPJ2arcfKgnTG/Pr GU+TEKKW58HvbqcyXTj80eMFl0QQ24IU6mrATvU99tDpHzmM+JEx5OuxYXFzcH2sOlG9eLhyU6m kjwgWdE3vNIOI2+aFStIuoDdTS7Zt4Evh7igteMwRi/Ru2dXTS5XW+9/owpKByn2A== X-Received: by 2002:a05:6830:7316:b0:7e9:bbf5:1079 with SMTP id 46e09a7af769-7fb7d276778mr17530457a34.2.1789010493406; Wed, 09 Sep 2026 20:21:33 -0700 (PDT) Received: from localhost ([76.187.192.44]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f9f6da9a49sm19758315a34.13.2026.09.09.20.21.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 09 Sep 2026 20:21:33 -0700 (PDT) From: Andrei Aldea To: Jiri Kosina , Benjamin Tissoires , "Derek J. Clark" Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Pavel Machek , linux-leds@vger.kernel.org Subject: [PATCH 06/15] HID: hid-oxp: serialize complete RGB updates Date: Wed, 9 Sep 2026 22:21:06 -0500 Message-ID: <20260910032115.28669-7-andrei1998@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260910032115.28669-1-andrei1998@gmail.com> References: <20260910032115.28669-1-andrei1998@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The transport mutex protects one report at a time, but changing an RGB effect requires a status command followed by a color or effect command. Serialize whole RGB transactions so sysfs and delayed brightness work do not interleave these command sequences. Fixes: 84910c459d65 ("HID: hid-oxp: Add OneXPlayer configuration driver") Assisted-by: LLM Reviewed-by: Derek J. Clark Signed-off-by: Andrei Aldea --- drivers/hid/hid-oxp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/hid/hid-oxp.c b/drivers/hid/hid-oxp.c index bee1317..8d07816 100644 --- a/drivers/hid/hid-oxp.c +++ b/drivers/hid/hid-oxp.c @@ -181,6 +181,7 @@ static struct oxp_hid_cfg { struct led_classdev_mc *led_mc; struct hid_device *hdev; struct mutex cfg_mutex; /*ensure single synchronous output report*/ + struct mutex rgb_mutex; /*serialize complete RGB transactions*/ u8 rgb_brightness; u8 gamepad_mode; u8 rumble_intensity; @@ -1074,6 +1075,8 @@ static ssize_t oxp_rgb_status_show(void) u16 up = get_usage_page(drvdata.hdev); u8 *data; + guard(mutex)(&drvdata.rgb_mutex); + switch (up) { case GEN1_USAGE_PAGE: data = (u8[1]) { OXP_GET_PROPERTY }; @@ -1191,6 +1194,8 @@ static ssize_t enabled_store(struct device *dev, struct device_attribute *attr, return ret; val = ret; + guard(mutex)(&drvdata.rgb_mutex); + ret = oxp_rgb_status_store(val, drvdata.rgb_speed, drvdata.rgb_brightness); if (ret) @@ -1244,6 +1249,8 @@ static ssize_t effect_store(struct device *dev, struct device_attribute *attr, val = ret; + guard(mutex)(&drvdata.rgb_mutex); + ret = oxp_rgb_status_store(drvdata.rgb_en, drvdata.rgb_speed, drvdata.rgb_brightness); if (ret) @@ -1302,6 +1309,8 @@ static ssize_t speed_store(struct device *dev, struct device_attribute *attr, if (val > 9) return -EINVAL; + guard(mutex)(&drvdata.rgb_mutex); + ret = oxp_rgb_status_store(drvdata.rgb_en, val, drvdata.rgb_brightness); if (ret) return ret; @@ -1340,6 +1349,8 @@ static void oxp_rgb_queue_fn(struct work_struct *work) u8 val = 4 * brightness / max_brightness; int ret; + guard(mutex)(&drvdata.rgb_mutex); + if (drvdata.rgb_brightness != val) { ret = oxp_rgb_status_store(drvdata.rgb_en, drvdata.rgb_speed, val); if (ret) @@ -1470,6 +1481,7 @@ static int oxp_cfg_probe(struct hid_device *hdev, u16 up) hid_set_drvdata(hdev, &drvdata); mutex_init(&drvdata.cfg_mutex); + mutex_init(&drvdata.rgb_mutex); drvdata.hdev = hdev; if (up == GEN2_USAGE_PAGE && oxp_hybrid_mcu_device())