Re: [PATCH v3 2/3] Input: Add driver for ESWIN EPH8621 touchscreen IC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] power: regulator imbalance on resume failure
--

commit 84d6ec94a7b38cd8d1245f0f98657e92de7d8440
Author: Luca Weiss <luca.weiss@fairphone.com>

    Input: Add driver for ESWIN EPH8621 touchscreen IC
    
    Add a driver for the ESWIN EPH8621 touchscreens, connected via SPI.

> diff --git a/drivers/input/touchscreen/eswin_eph8621.c b/drivers/input/touchscreen/eswin_eph8621.c
> new file mode 100644
> index 0000000000000..766b113b3288d
> --- /dev/null
> +++ b/drivers/input/touchscreen/eswin_eph8621.c
[ ... ]
> +static void eswin_power_off(struct eswin_touch *ts)
> +{
> +	gpiod_set_value_cansleep(ts->reset_gpio, 1);
> +	regulator_bulk_disable(ARRAY_SIZE(ts->supplies), ts->supplies);
> +}
> +
> +static void eswin_power_off_act(void *data)
> +{
> +	struct eswin_touch *ts = data;
> +
> +	eswin_power_off(ts);
> +}
[ ... ]
> +static int eswin_resume(struct device *dev)
> +{
> +	struct spi_device *spi = to_spi_device(dev);
> +	struct eswin_touch *ts = spi_get_drvdata(spi);
> +	int error;
> +
> +	error = eswin_power_on(ts);
> +	if (error)
> +		return error;
                ^^^^^^^^^^^^

[Severity: Medium]
If eswin_power_on() fails during system resume, the regulators remain
disabled.

Since the devres cleanup action (eswin_power_off_act) runs unconditionally
when the driver unbinds, devres will eventually call eswin_power_off().

Could this attempt to disable the already-disabled regulators and trigger
a regulator disable count underflow warning?

> +
> +	enable_irq(spi->irq);
> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-eswin-eph8621-v3-0-514eb1f622c0@fairphone.com?part=2