Re: [PATCH v2 07/10] HID: apple: Add support for DockChannel HID keyboards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] hid-apple: custom match callback ignores HID_QUIRK_IGNORE_SPECIAL_DRIVER
--

commit f42c7195001b107355d17e77d99321b92d3f7aad
Author: Michael Reeves <michael.reeves077@gmail.com>
Subject: HID: apple: Add support for DockChannel HID keyboards

This commit adds support for DockChannel HID keyboards to the hid-apple
driver. It introduces a custom match callback to register devices based
on their host bus and specific HID group. The keyboard is then mapped
to the modern Magic Keyboard function-key table.

> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
[ ... ]
> @@ -1019,6 +1029,17 @@ static void apple_remove(struct hid_device *hdev)
>  	hid_hw_stop(hdev);
>  }
>  
> +static bool apple_match(struct hid_device *hdev, bool ignore_special_driver)
> +{
> +	if (ignore_special_driver)
> +		return false;
> +
> +	if (hdev->group == HID_GROUP_APPLE_DOCKCHANNEL)
> +		return apple_is_dockchannel_keyboard(hdev);
> +
> +	return true;

[Severity: Medium]
Does this code need to explicitly check for the device-specific quirk
hdev->quirks & HID_QUIRK_IGNORE_SPECIAL_DRIVER before returning true?

Returning true unconditionally for other Apple devices bypasses the HID
core's default safety enforcement. The hid-apple driver will bind to matching
Apple devices even if a user or a HID-BPF program has set the
HID_QUIRK_IGNORE_SPECIAL_DRIVER quirk.

This breaks driver fallback to hid-generic and prevents HID-BPF from taking
over the device via the standard quirk override mechanism.

> +}
> +
[ ... ]
> @@ -1248,6 +1272,7 @@ MODULE_DEVICE_TABLE(hid, apple_devices);
>  static struct hid_driver apple_driver = {
>  	.name = "apple",
>  	.id_table = apple_devices,
> +	.match = apple_match,
>  	.report_fixup = apple_report_fixup,
>  	.probe = apple_probe,
>  	.remove = apple_remove,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-apple-mtp-keyboard-final-v2-0-a5c685e50b60@gmail.com?part=7