From: Jonathan Cameron <jic23@kernel.org>
To: "Zhang, Lixu" <lixu.zhang@intel.com>
Cc: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>,
Yibo Tan <lhfff@tju.edu.cn>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] HID: sensor-hub: synchronize multi-value read cancellation
Date: Mon, 21 Sep 2026 03:08:20 +0100 [thread overview]
Message-ID: <20260921030820.3ef1a6bd@jic23-hlaptop> (raw)
In-Reply-To: <SJ0PR11MB56133EB59F6A661ECE3820D593B82@SJ0PR11MB5613.namprd11.prod.outlook.com>
On Thu, 17 Sep 2026 01:16:09 +0000
"Zhang, Lixu" <lixu.zhang@intel.com> wrote:
> >-----Original Message-----
> >From: Zhang, Lixu
> >Sent: Friday, September 11, 2026 1:17 PM
> >To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>; Yibo Tan
> ><lhfff@tju.edu.cn>; Jiri Kosina <jikos@kernel.org>; Jonathan Cameron
> ><jic23@kernel.org>; Benjamin Tissoires <bentiss@kernel.org>
> >Cc: Shevchenko, Andriy <andriy.shevchenko@intel.com>; linux-
> >input@vger.kernel.org; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
> >Subject: RE: [PATCH v1] HID: sensor-hub: synchronize multi-value read
> >cancellation
> >
> >>-----Original Message-----
> >>From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
> >>Sent: Friday, September 11, 2026 2:29 AM
> >>To: Yibo Tan <lhfff@tju.edu.cn>; Jiri Kosina <jikos@kernel.org>;
> >>Jonathan Cameron <jic23@kernel.org>; Benjamin Tissoires
> >><bentiss@kernel.org>
> >>Cc: Zhang, Lixu <lixu.zhang@intel.com>; Shevchenko, Andriy
> >><andriy.shevchenko@intel.com>; linux-input@vger.kernel.org; linux-
> >>iio@vger.kernel.org; linux-kernel@vger.kernel.org
> >>Subject: Re: [PATCH v1] HID: sensor-hub: synchronize multi-value read
> >>cancellation
> >>
> >>On Thu, 2026-09-10 at 19:23 +0800, Yibo Tan wrote:
> >>> sensor_hub_input_attr_read_values() publishes a caller-owned buffer
> >>> to the raw-event path. If its interruptible wait times out or is
> >>> interrupted, it clears pending.status without taking data->lock and
> >>> returns.
> >>>
> >>
> >>Hi Lixu,
> >>
> >>Please give me quick test. Change itself looks good, not sure if we
> >>need something more.
> >Hi Srinivas,
> >
> >The machine is currently running other tests. Once they are done next week, I
> >will run a quick test on this change and get back to you with feedback.
>
> Tested-by: Zhang Lixu <lixu.zhang@intel.com>
>
> I did some basic validation on a real HID sensor hub / rotation sensor system and did not see a regression from this patch.
>
Great. Thanks!
Yibo Tan, please can you spin a v2 addressing the other feedback.
thanks,
Jonathan
> Thanks,
> Lixu
>
> >
> >Thanks,
> >Lixu
> >
> >>
> >>Thanks,
> >>Srinivas
> >
>
prev parent reply other threads:[~2026-09-21 2:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 11:23 [PATCH v1] HID: sensor-hub: synchronize multi-value read cancellation Yibo Tan
2026-09-10 11:35 ` sashiko-bot
2026-09-10 15:32 ` Andy Shevchenko
2026-09-10 18:28 ` srinivas pandruvada
2026-09-11 5:16 ` Zhang, Lixu
2026-09-17 1:16 ` Zhang, Lixu
2026-09-21 2:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921030820.3ef1a6bd@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=lhfff@tju.edu.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox