Re: [PATCH 1/2] Write shared touch initial status only once

[Lee Jones <lee@kernel.org>]

> Do you have any questions about my patches, especially this first one?
> I added it to make the assignment consistent with your patch. Since
> the is_soft_touch_switch can only be set by pad, we would only get to
> this assignment once. It won't be assigned more than once with the
> current firmware logic. If you don't see an issue with the patch, can
> you give it an acked-by?
> 
> The second patch adds the softkey touch switch back, which is
> important. I hope my fix can be merged upstream along with your
> patchset. Otherwise we break userland.

Honestly, you know this driver much better than I do.

The change looks sound to my uninformed eyes though.

Bear in mind that the subject line does not match the style expected of
the subsystem - or anywhere else for that matter.  =:-)

> On Tue, Sep 15, 2026 at 7:03 PM Ping Cheng <pinglinux@gmail.com> wrote:
> >
> > From: Ping Cheng <ping.cheng@wacom.com>
> >
> > To match the same logic as with other shared data during registeration,

Spell check.

> > use WRITE_ONCE for is_touch_on too.
> >
> > Cc: stable@vger.kernel.org

Fixes:

With those fixed:

Reviewed-by: Lee Jones <lee@kernel.org>

> > Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
> > ---
> >  drivers/hid/wacom_sys.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> > index 8dc7aa1c0a26..33fa491fba92 100644
> > --- a/drivers/hid/wacom_sys.c
> > +++ b/drivers/hid/wacom_sys.c
> > @@ -2386,7 +2386,7 @@ static void wacom_set_shared_values(struct wacom_wac *wacom_wac)
> >                  * match historic default.
> >                  */
> >                 if (wacom_wac->is_soft_touch_switch)
> > -                       wacom_wac->shared->is_touch_on = true;
> > +                       WRITE_ONCE(wacom_wac->shared->is_touch_on, true);
> >         }
> >
> >         if (wacom_wac->features.device_type & WACOM_DEVICETYPE_TOUCH) {
> > --
> > 2.55.0
> >

-- 
Lee Jones