Re: [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] input: xpad: out-of-order xpad_device array entry
--

commit db3ad191bb5f3c117f65ad725be0401f7c92d4d6
Author: Bihaan Sen <stevewholikesthings@gmail.com>

Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox

This commit adds a new VID/PID pair (0x2dc8/0x201e) to the xpad_device
table for a later hardware revision of the 8BitDo Pro 2 Wired Controller,
ensuring it is named correctly instead of defaulting to "Generic X-Box pad".

> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index feb8f368f834e..e7af88bfb8da5 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -371,6 +371,7 @@ static const struct xpad_device {
>  	{ 0x294b, 0x3404, "Snakebyte GAMEPAD RGB X", 0, XTYPE_XBOXONE },
>  	{ 0x2993, 0x2001, "TECNO Pocket Go", 0, XTYPE_XBOX360 },
>  	{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
> +	{ 0x2dc8, 0x201e, "8BitDo Pro 2 Wired Controller for Xbox", 0, XTYPE_XBOXONE },
>  	{ 0x2dc8, 0x200f, "8BitDo Ultimate 3-mode Controller for Xbox", MAP_SHARE_BUTTON, XTYPE_XBOXONE },

[Severity: Low]
Is this entry slightly out of order? The xpad_device array is typically kept
sorted numerically by Vendor ID and then Product ID. Since the Product ID
0x201e is greater than 0x200f, should this new entry be placed after it
instead?

>  	{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless / Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
>  	{ 0x2dc8, 0x3109, "8BitDo Ultimate Wireless Bluetooth", 0, XTYPE_XBOX360 },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925092439.79904-1-stevewholikesthings@gmail.com?part=1