Re: [PATCH -next v2 4/4] HID: amd_sfh: Use report type from request node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] amd_sfh: incomplete cleanup of report_type array in amdtp_cl_data
--

commit 8029dfd0564b3015a23fe39f335b6a6e8b4706ba
Author: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

HID: amd_sfh: Use report type from request node

Use report type from request node while sending feature and input reports
to HID core. The cli_data report type array is never assigned and
feature reports are sent as input reports.

Closes: https://github.com/ublue-os/bazzite/issues/5796

> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_client.c b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
> index ae6add0b9ce3f..a68b275f0456b 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_client.c
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
> @@ -95,7 +95,7 @@ void amd_sfh_work(struct work_struct *work)
>  						    cli_data->feature_report[current_index]);
>  		if (report_size)
>  			hid_input_report(cli_data->hid_sensor_hubs[current_index],
> -					 cli_data->report_type[current_index],
> +					 node_type,

[Severity: Low]
This isn't a bug, but since this patch removes the usage of the report_type
array, should its declaration also be removed from struct amdtp_cl_data?

drivers/hid/amd-sfh-hid/amd_sfh_hid.h:amdtp_cl_data {
    ...
	u32 sensor_requested_cnt[MAX_HID_DEVICES];
	u8 report_type[MAX_HID_DEVICES];
	u8 report_id[MAX_HID_DEVICES];
    ...
};

Leaving the declaration wastes a small amount of memory and adds clutter as
dead code.

>  					 cli_data->feature_report[current_index], report_size, 0);
>  		else
>  			pr_err("AMDSFH: Invalid report size\n");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006103754.3614316-1-Basavaraj.Natikar@amd.com?part=4