From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B2047D461 for ; Tue, 13 Oct 2026 03:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791862956; cv=none; b=HqHptxiZwyDdzDnkOH6sN+GHUOEAeSYKi7OOYmJ8jLIZnGvtJsohtVyotjK9G7uQmO6bYzsukalZRnzk/RHUrtOtt93wJfPBYJeRKVwg7RHeFGp/R0bwZG5A/y1KfBKnfugCFG1o5p1P8RmZJqiaEv0OHucmJl3mm+24wEXUVK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791862956; c=relaxed/simple; bh=5l5rOMnqmUZDSkzkbMpjGa6wwNxhDpOe/T3B2RXhwgg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ELzR4ldNUJl84wggRD8yE/LdRCAcygjKM/xklTJOI/9BxXKsb6C2Eql8LyC3Lh9xSoOyUTEGtwFNnLdoRpUI8cQKV9GvIQgwd9k+pB8Vq+NDW+4xkAcIfOhNDYv0//Qznt8u/2jGn/agO/77gVB7Hzj2n8g0x9mlYFcUI+ix43I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bN8cZ3XX; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bN8cZ3XX" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-3514b90bb89so4717728eec.1 for ; Mon, 12 Oct 2026 20:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791862954; x=1792467754; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aCIUa8Lo33J/2KwMBZsXqmYyUZJ5D4WgEyODRjSabeQ=; b=bN8cZ3XXUjO+Xw9MdiwVS/x5yAB69JEB0TBQZsIGDrtSdrtm31DcqanyfySbykwo2K ika/pCp3f/tHexISEQSf2Z1vR0lKpGakOmJJ4SAKmYqLvnahkDmWdvUTijHUiemb0RS6 +dilucNpiFBVWT1sDgj/ltUCQ5Htq6FJGNOkBtS/c/vRcny/Fx19p3nPr7pBOaLxosTI gitEA1bAEdb/Dav6hlliSUzsAhmGQyOyr3neIPJcLnatoKHLrkfAFKKC3RDLVeql+I0A EqI/ezsAuOJ0d0tfLmHhB6Tis9SoJJRl/45x5rf+BHrSvLponjhygrm3dwjp8BCfDGZ2 +VCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791862954; x=1792467754; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aCIUa8Lo33J/2KwMBZsXqmYyUZJ5D4WgEyODRjSabeQ=; b=cWjLD55CSZffdDhEq07L4CWwLXUzWxgwFerVoIr7VeWJG/KD1SuNSYLxUGSXmWGd7G 0dFkwQEB57r3mPEncN2KduKiTck9hNi7Kmd9LLLDfGOBZEZayZa2H+ZjwbzoLMggL6H6 tF7YBKXHOgc1vTYguyOVBYTZg4CyQEx0uo8dshCrnxwtmrSw+d+suot/DMCvWdUx95zC SDF8Q7nCQOSW6u2Ks4ckazDbbTYtgVg73xsCxAJRrfv8+8yzfJYq1p3g0E1O3vhHI+m2 SfYfxLRDuAwgbtfI7evxmT50xx0dAvqkiyCB3Tzj4BgtiHkBhp3ho9CWwVZdSz15+w8C Kmyg== X-Forwarded-Encrypted: i=1; AKwUvBzRuEu81XRHFM2PKjE7m/m/clNUoEKor8E5iyh/+vXq97bZJM+9bc1LZBGp+DafFDVD7U7hjkm+tbZaaQ==@vger.kernel.org X-Gm-Message-State: AFq9FYKNO8Oy/m6wC1/qQIL3NgrdX9VnIlsIs85N7ICAJPIGPrVCfvQZ zTO4IMN+eJlH3MDtebSVlqRbbAKBLRIUvGmDsLaV/4eV40OAvGE0CSDM X-Gm-Gg: AYBFou2p185UlnD05P24CGalElCIwswA9COkGjWtKX8FUZ+3hbYG+A3fLV7bSzYB/BB EgeJAOV+HIkvdIvdGXbLHRH1sDWLkPi6PGPNczq64LsU3GJoiue0uNm9n/pWb0hEozddULJgVEE xQhbZN8CiYAG8AkpvYGwPysCJGPmlTCHjVKtBpKAArihoDvX4IeqDurvdBAvXLElR8JDDwsaZrF w+FkR5FR7OMKGmUIyZSLRSN/0uU4vcpdM9uu4Pdcn1KHSA/GFMlRp4fn8D1ttbMpgSn2/0QPEYV 1Pv+0gZ2LKWg02mao87d0L5S+6MZR11KK7Q9UcJ1UNyENMVy2KnIwCPwCQK9cyFv52wV6ovRKVC ZheuCnY8uT0hXZxr5adJsLJqVN1H3/9LrCd0kIiULIRnuFs3k7NFvUWstW9JlllIFhMhLRJ7o2Q vjzxpsy6OBMRn2np2T87g/un2t1I4VLLBFuEZaVP2eW1lykSAqJw0qwWUrDaUzb3Xt1d/qa7Epn C0/k1yeRIB0ZaR17vKw2xLbLs/P0u+4CMjy0Brmfd09LrcDzumnFrCCxbcw0bg= X-Received: by 2002:a05:7300:6d23:b0:35c:6ffd:e91b with SMTP id 5a478bee46e88-35c6ffdf3b6mr1436443eec.40.1791862953821; Mon, 12 Oct 2026 20:42:33 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:679a:f35b:7c29:e0f2]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537cb68e56sm35268677eec.29.2026.10.12.20.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 20:42:33 -0700 (PDT) From: Dmitry Torokhov Date: Mon, 12 Oct 2026 20:42:22 -0700 Subject: [PATCH 6/9] HID: goodix-spi: Drop redundant report ID validation Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261012-hid-core-report-validation-v1-6-e0dd5cb60b2e@gmail.com> References: <20261012-hid-core-report-validation-v1-0-e0dd5cb60b2e@gmail.com> In-Reply-To: <20261012-hid-core-report-validation-v1-0-e0dd5cb60b2e@gmail.com> To: Marcel Holtmann , Luiz Augusto von Dentz , David Rheinsberg , Frank Praznik , Jiri Kosina , Benjamin Tissoires , Even Xu , Xinpeng Sun , Roderick Colenbrander Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Shashikirana H K X-Mailer: b4 0.17-dev-e56a4 Now that the core HID request handling validates returned report IDs for report retrieval requests centrally, the report ID check in the Goodix SPI transport driver is redundant. Drop it. Assisted-by: LLM Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-goodix-spi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-goodix-spi.c b/drivers/hid/hid-goodix-spi.c index 03d549efbdce..81603581ae40 100644 --- a/drivers/hid/hid-goodix-spi.c +++ b/drivers/hid/hid-goodix-spi.c @@ -461,11 +461,6 @@ static int goodix_hid_get_raw_report(struct hid_device *hid, return error; } - if (buf[0] != reportnum) { - dev_err(ts->dev, "incorrect report (%d vs %d expected)", - buf[0], reportnum); - return -EINVAL; - } return len; } -- 2.56.0.385.gd3acb90ef8-goog