Linux Input/HID development
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Andrej Scek <scek.andrej@gmail.com>
Cc: linux-input@vger.kernel.org,
	Basavaraj Natikar <basavaraj.natikar@amd.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	srinivas.pandruvada@linux.intel.com,
	Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [REGRESSION] amd_sfh: accelerometer broken since 6.19 ("Event data for report 1 was too short (15 vs 14)")
Date: Wed, 14 Oct 2026 14:50:30 +0100	[thread overview]
Message-ID: <20261014135030.GA839238@google.com> (raw)
In-Reply-To: <20261009114925.GB199624@google.com>

On Fri, 09 Oct 2026, Lee Jones wrote:

> On Fri, 02 Oct 2026, Andrej Scek wrote:
> 
> > Update: this looks like it is caused by
> > 
> >   0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus memset()")
> > 
> > which was backported to the 6.18.y and 6.19.y stable trees on 2026-04-11.
> > 6.18.16 predates that backport and works; 6.19.12 and 7.2.8 contain it and
> > fail. The AMD SFH sends 14-byte reports where the descriptor declares 15, and
> > those are now rejected instead of zero-padded. (This corrects my earlier note
> > that hid-core had no relevant changes; I had only checked v6.18..v6.19.)
> > 
> > The same symptom on another AMD SFH device (Legion Go S, "18 vs 14"):
> > https://github.com/ublue-os/bazzite/issues/5796
> > 
> > So AMD SFH (hid-amdsfh 1022:0001) probably needs to be covered by whatever
> > short-report quirk/fix is adopted for this.
> > 
> > #regzbot introduced: 0a3fe972a7cb
> 
> This is on my radar.  Leave it with me.

stable/linux-5.10.y:
59bfdb41a34c HID: pass the buffer size to hid_report_raw_event [5.10.259]
QUEUED: HID: core: introduce hid_safe_input_report()
QUEUED: HID: uhid: convert to hid_safe_input_report()

stable/linux-5.15.y:
a4d6cb7cf45b HID: pass the buffer size to hid_report_raw_event [5.15.210]
QUEUED: HID: core: introduce hid_safe_input_report()
QUEUED: HID: uhid: convert to hid_safe_input_report()

stable/linux-6.1.y:
121dc93ae1fc HID: pass the buffer size to hid_report_raw_event [6.1.176]
QUEUED: HID: core: introduce hid_safe_input_report()
QUEUED: HID: uhid: convert to hid_safe_input_report()

stable/linux-6.6.y:
9e36568e67f8 HID: pass the buffer size to hid_report_raw_event [6.6.143]
QUEUED: HID: core: introduce hid_safe_input_report()
QUEUED: HID: uhid: convert to hid_safe_input_report()

-- 
Lee Jones

      reply	other threads:[~2026-10-14 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 15:03 [REGRESSION] amd_sfh: accelerometer broken since 6.19 ("Event data for report 1 was too short (15 vs 14)") Andrej Scek
2026-10-02 15:20 ` Andrej Scek
2026-10-09 11:49   ` Lee Jones
2026-10-14 13:50     ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014135030.GA839238@google.com \
    --to=lee@kernel.org \
    --cc=basavaraj.natikar@amd.com \
    --cc=bentiss@kernel.org \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=scek.andrej@gmail.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox