From: wyibo6109@gmail.com
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Yibo Wang <wyibo6109@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard
Date: Thu, 15 Oct 2026 06:08:00 -0500 [thread overview]
Message-ID: <20261015110807.203881-1-wyibo6109@gmail.com> (raw)
In-Reply-To: <20261015-melodic-cooperative-chital-afa0fd@quoll>
From: Yibo Wang <wyibo6109@gmail.com>
Hi Krzysztof,
On Wed, Oct 14, 2026 at ... Krzysztof Kozlowski wrote:
> I don't think we are describing here the MCU, but the keyboard, thus
> it's physical geometry is fixed.
Agreed - the node binds the keyboard, and a keyboard's geometry is
fixed with the hardware. That is exactly why v3 does not describe it
in DT at all: the touchpad geometry and the product names are
per-compatible constants in the driver's match data. I also reworded
the binding to describe the keyboard (built around the Tinno MCU)
rather than the MCU itself, and the touchscreen properties remain only
as an optional override for the unlikely case of a variant.
The rewording will be folded into v4, which follows as a reply to
the v3 cover letter.
Best regards,
Yibo
next prev parent reply other threads:[~2026-10-15 11:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 12:20 [PATCH 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-09 12:20 ` [PATCH 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard binding wyibo6109
2026-10-09 12:28 ` sashiko-bot
2026-10-09 13:22 ` Krzysztof Kozlowski
2026-10-09 12:20 ` [PATCH 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-09 12:38 ` sashiko-bot
2026-10-10 14:38 ` [PATCH v2 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-10 14:38 ` [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard wyibo6109
2026-10-10 14:47 ` sashiko-bot
2026-10-12 6:24 ` Krzysztof Kozlowski
2026-10-14 13:47 ` wyibo6109
2026-10-15 8:52 ` Krzysztof Kozlowski
2026-10-15 11:08 ` wyibo6109 [this message]
2026-10-10 14:38 ` [PATCH v2 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-10 14:48 ` sashiko-bot
2026-10-14 13:52 ` [PATCH v3 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-14 13:52 ` [PATCH v3 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard wyibo6109
2026-10-15 8:50 ` Krzysztof Kozlowski
2026-10-14 13:52 ` [PATCH v3 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-14 14:03 ` sashiko-bot
2026-10-15 11:08 ` [PATCH v4 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-15 11:08 ` [PATCH v4 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard wyibo6109
2026-10-15 11:08 ` [PATCH v4 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-15 11:19 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015110807.203881-1-wyibo6109@gmail.com \
--to=wyibo6109@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox