From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-223.mta0.migadu.com [91.218.175.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF5333CBE80 for ; Sat, 17 Oct 2026 18:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792260971; cv=none; b=YAtseLfD4ocxZJvVAjCg6EVBvXMMCIIEvg789ieW5QN7tUUxv5vQYxML9Zbq1oSSxup+o/wbGk5E5Ekrf0voO0jpnsM+ytRf/uYjndwSXb1DdPnDakZrJe0RyXrT2IkonL1Jlj6WS1FJmubO/w3or6qezSAmZpyz1axApxEmYNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792260971; c=relaxed/simple; bh=u65lHJDL+0q4VKvqkDxHlXF48gNkyNZVcTAacW9VEtA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PA5i2kQ9UtHUVM0XSiHAgsHTf6aHI/oU84TYwAC7B2Yn0x8utA3G9G4OzYZcD9tDoqn6HpU2cueLBgI/BU/L1vziTQj2pHfaTi1+CCqsPWQ4C4WTLbXXaXDNP3Kb07NbbBdc4f2K51QcoKA3eDjjRYIAufmn2PASfxmxhbOR5p0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Oet/VQr0; arc=none smtp.client-ip=91.218.175.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Oet/VQr0" X-Envelope-To: linux-input@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=u65lHJDL+0q4VKvqkDxHlXF48gNkyNZVcTAacW9VEtA=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792260967; v=1; x=1792865767; b=Oet/VQr0/iiNhSO8SPJdZQcJF8ZjaJBCKCrpJXFQ34pOf+Ws64p4v6LwK7had+bqnGcATX+n iDV7ILQrGahq9/J9EdRu7h5zBMGsFp8UNc363PUvUsdPwP2dbZIOP91Bkf4dnpw8pfk4QavizNl kumtxaE/5RzZOHGykPdCVzRk= X-Envelope-To: linux-input@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 96e4f88ee9d46017; Sat, 17 Oct 2026 18:16:07 +0000 X-Mizu-Trace-ID: 96e4f88ee9d46017 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: linux-input@vger.kernel.org, kernel@lists.opengamingcollective.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schyboll" , "Denis Benato" , Denis Benato Subject: [PATCH v10 05/11] HID: asus: add triggers inner and outer range configuration Date: Sat, 17 Oct 2026 18:15:14 +0000 Message-ID: <20261017181520.70206-6-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261017181520.70206-1-denis.benato@linux.dev> References: <20261017181520.70206-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ROG Ally devices allows configuring inner and outer ranges for triggers buttons on the back: allow userspace to configure the sensitivity by exposing sysfs attributes. Assisted-by: opencode:glm-5.2 Signed-off-by: Denis Benato Signed-off-by: Luke Jones --- drivers/hid/hid-asus.c | 393 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 393 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 5a3308fb6609..5411cc0a7fb3 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -1390,6 +1390,357 @@ static struct device_attribute dev_attr_right_joystick_outer_threshold = static struct device_attribute dev_attr_right_joystick_outer_threshold_range = __ATTR(outer_threshold_range, 0444, right_joystick_outer_threshold_range_show, NULL); +/** + * ally_set_trigger_ranges() - Generic function to set triggers ranges + * @ally: ally handheld structure + * @hdev: HID device + * @left_it: lower limit of the left trigger range (0-50) + * @left_ot: upper limit of the left trigger range (70-100) + * @right_it: lower limit of the right trigger range (0-50) + * @right_ot: upper limit of the right trigger range (70-100) + * + * This function sends the command to set both inner and outer threshold + * for the left and right triggers. + * + * Return: 0 on success, negative errno on failure + */ +static int ally_set_trigger_ranges(struct ally_handheld *ally, + struct hid_device *hdev, + u8 left_it, u8 left_ot, u8 right_it, u8 right_ot) +{ + const u8 payload[] = { left_it, left_ot, right_it, right_ot }; + int ret; + + u8 *buf __free(kfree) = ally_alloc_cmd(CMD_SET_TRIGGER_RANGE, payload, sizeof(payload)); + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(ally, hdev, buf, ROG_ALLY_REPORT_SIZE); + if (ret < 0) { + hid_err(hdev, "Failed to set trigger ranges: %d\n", ret); + return ret; + } + + return 0; +} + +static ssize_t left_trigger_range_lower_limit_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%u\n", cfg->left_trigger_min); +} + +static ssize_t left_trigger_range_lower_limit_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 50) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + ret = ally_set_trigger_ranges(ally, hdev, + value, + cfg->left_trigger_max, + cfg->right_trigger_min, + cfg->right_trigger_max); + if (ret) + return ret; + + cfg->left_trigger_min = value; + + sysfs_notify(&dev->kobj, "left_trigger", "range_lower_limit"); + + return count; +} + +static ssize_t left_trigger_range_lower_limit_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "0 50\n"); +} + +static ssize_t right_trigger_range_upper_limit_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%u\n", cfg->right_trigger_max); +} + +static ssize_t right_trigger_range_upper_limit_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value < 70 || value > 100) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + ret = ally_set_trigger_ranges(ally, hdev, + cfg->left_trigger_min, + cfg->left_trigger_max, + cfg->right_trigger_min, + value); + if (ret) + return ret; + + cfg->right_trigger_max = value; + + sysfs_notify(&dev->kobj, "right_trigger", "range_upper_limit"); + + return count; +} + +static ssize_t right_trigger_range_upper_limit_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "70 100\n"); +} + +static ssize_t right_trigger_range_lower_limit_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%u\n", cfg->right_trigger_min); +} + +static ssize_t right_trigger_range_lower_limit_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 50) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + ret = ally_set_trigger_ranges(ally, hdev, + cfg->left_trigger_min, + cfg->left_trigger_max, + value, + cfg->right_trigger_max); + if (ret) + return ret; + + cfg->right_trigger_min = value; + + sysfs_notify(&dev->kobj, "right_trigger", "range_lower_limit"); + + return count; +} + +static ssize_t right_trigger_range_lower_limit_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "0 50\n"); +} + +static ssize_t left_trigger_range_upper_limit_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + return sysfs_emit(buf, "%u\n", cfg->left_trigger_max); +} + +static ssize_t left_trigger_range_upper_limit_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value < 70 || value > 100) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->user_cal_support) + return -EOPNOTSUPP; + + ret = ally_set_trigger_ranges(ally, hdev, + cfg->left_trigger_min, + value, + cfg->right_trigger_min, + cfg->right_trigger_max); + if (ret) + return ret; + + cfg->left_trigger_max = value; + + sysfs_notify(&dev->kobj, "left_trigger", "range_upper_limit"); + + return count; +} + +static ssize_t left_trigger_range_upper_limit_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "70 100\n"); +} + +static struct device_attribute dev_attr_left_trigger_range_lower_limit = + __ATTR(range_lower_limit, 0644, left_trigger_range_lower_limit_show, + left_trigger_range_lower_limit_store); + +static struct device_attribute dev_attr_left_trigger_range_lower_limit_range = + __ATTR(range_lower_limit_range, 0444, left_trigger_range_lower_limit_range_show, NULL); + +static struct device_attribute dev_attr_left_trigger_range_upper_limit = + __ATTR(range_upper_limit, 0644, left_trigger_range_upper_limit_show, + left_trigger_range_upper_limit_store); + +static struct device_attribute dev_attr_left_trigger_range_upper_limit_range = + __ATTR(range_upper_limit_range, 0444, left_trigger_range_upper_limit_range_show, NULL); + +static struct device_attribute dev_attr_right_trigger_range_lower_limit = + __ATTR(range_lower_limit, 0644, right_trigger_range_lower_limit_show, + right_trigger_range_lower_limit_store); + +static struct device_attribute dev_attr_right_trigger_range_lower_limit_range = + __ATTR(range_lower_limit_range, 0444, right_trigger_range_lower_limit_range_show, NULL); + +static struct device_attribute dev_attr_right_trigger_range_upper_limit = + __ATTR(range_upper_limit, 0644, right_trigger_range_upper_limit_show, + right_trigger_range_upper_limit_store); + +static struct device_attribute dev_attr_right_trigger_range_upper_limit_range = + __ATTR(range_upper_limit_range, 0444, right_trigger_range_upper_limit_range_show, NULL); + static struct attribute *ally_config_attrs[] = { &dev_attr_xbox_controller.attr, NULL @@ -1423,6 +1774,22 @@ static struct attribute *right_joystick_axis_attrs[] = { NULL }; +static struct attribute *left_trigger_attrs[] = { + &dev_attr_left_trigger_range_lower_limit.attr, + &dev_attr_left_trigger_range_upper_limit.attr, + &dev_attr_left_trigger_range_lower_limit_range.attr, + &dev_attr_left_trigger_range_upper_limit_range.attr, + NULL +}; + +static struct attribute *right_trigger_attrs[] = { + &dev_attr_right_trigger_range_lower_limit.attr, + &dev_attr_right_trigger_range_upper_limit.attr, + &dev_attr_right_trigger_range_lower_limit_range.attr, + &dev_attr_right_trigger_range_upper_limit_range.attr, + NULL +}; + static const struct attribute_group ally_attr_groups[] = { { .attrs = ally_config_attrs, @@ -1454,9 +1821,21 @@ static const struct attribute_group ally_right_joystick_axis_group = { .attrs = right_joystick_axis_attrs, }; +static const struct attribute_group ally_left_trigger_group = { + .name = "left_trigger", + .attrs = left_trigger_attrs, +}; + +static const struct attribute_group ally_right_trigger_group = { + .name = "right_trigger", + .attrs = right_trigger_attrs, +}; + static const struct attribute_group *const ally_cal_attr_groups[] = { &ally_left_joystick_axis_group, &ally_right_joystick_axis_group, + &ally_left_trigger_group, + &ally_right_trigger_group, }; /** @@ -1501,6 +1880,10 @@ static struct ally_config *ally_config_create(struct hid_device *hdev, struct al cfg->left_outer_threshold = 90; cfg->right_deadzone = 10; cfg->right_outer_threshold = 90; + cfg->left_trigger_min = 0; + cfg->left_trigger_max = 100; + cfg->right_trigger_min = 0; + cfg->right_trigger_max = 100; cfg->vibration_intensity_left = 100; cfg->vibration_intensity_right = 100; } @@ -1888,6 +2271,16 @@ static int hid_asus_ally_init(struct hid_device *hdev, struct ally_handheld *all hid_warn(hdev, "Failed to restore joystick thresholds: %d\n", ret); + + ret = ally_set_trigger_ranges(ally, hdev, + cfg->left_trigger_min, + cfg->left_trigger_max, + cfg->right_trigger_min, + cfg->right_trigger_max); + if (ret < 0) + hid_warn(hdev, + "Failed to restore trigger ranges: %d\n", + ret); } return 0; -- 2.47.3