From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C5D3F107E for ; Sun, 18 Oct 2026 21:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792359492; cv=none; b=l7yGdRHVOOeTpGFLShA9E4E8B6mN8KrykeBs5iWXXo94ajp54zlWqtuPHYiTjFnZSoDCieXZ/WKgUi8WkfQe7r3SDv2xcrLy+Y5smpIdr0p7CM3+tPHX1mNcOn+135vnidRrMs8b0BQVbkwkPVQqzvR08PqpaaGVJdI61dNctNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792359492; c=relaxed/simple; bh=e8wtLcepGB7m1WkPi16XBbmRmlD4CHncDaB4ghzbtZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rxTLkC3l30t8Ytm7TN/27TBvGwezrSaSJuKf3041GfVBu20d9/RJo4qw1kDxkw6p5iY8hAUW4jGlJxmU6odng8WfUc7R4ieUGMq3oO4edOIZ2nPi5n5f8Rt1dzYhULmDCtt52Lo38jDUiQAg0M8N+dvgOQ6u+Wv5HRDjtH3r12U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JaTVsTvQ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaTVsTvQ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a1ddc7c9beso5346835e9.1 for ; Sun, 18 Oct 2026 14:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792359489; x=1792964289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vAVYSc6bOeEhdjTuKd9lteCMjpiUz07VUT/q4gCOyPM=; b=JaTVsTvQULi/hn3sAYWpXKGTmeeDv6MstbUF0xY10bLosks7XXcsysCHNNaivTfz9n uNQlnSHrukHjQVv9ZHkeruS/6FMH+Ha2X8VfG/OU27d+MNeLaVGsySWmQEOgOIL9vr+W sMuHoAqfDwOruTQoOTyoaowYNntFP8dh94tbZnhXbfywWKoxUDROL8B7I8xFTb+Ctpk9 /sLeGF8anhxSiFsfxj/wQvAE/2YJmt4WhsC+QbB5MYKXotIKCu1TI/X71Gittdrmzo1C MwyIxLX7WA2otdS11Mf7mTnERerV0Pehz02NvJrOu66xAezIq1sgYxoUwPuB7KmIKrEv pyGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792359489; x=1792964289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vAVYSc6bOeEhdjTuKd9lteCMjpiUz07VUT/q4gCOyPM=; b=ck1baX4VqCpJaciuxhM/XGjXr+BDW8/I5lUdM2ZN4TPPgP5fL1x5LAHqOpBNJCtbJ8 d69iaAh9B8ouwpFv5sbZN3JPWkqLOxQJSr/ld3711A5YPuoTLdzPnCjewozGs/9NCOi5 GVFMkPBGFvlRr1crmE0z92OeB3iRATDQJKI6gI+/5wWDt+wnk/fHhYq2+UQsFWX0DDPs fWzqywsW8xEqGYwHRYwHwvJDmBjyEoDoOu+fbqZQhgiw5EZp1Rxmx0p+7DH1KTxshEa5 Dw4M4cnwC2jYoy5V5UVC051wvuebuvTifmchg5OU1RXzIO+y8m8PYBhjB9kZl4JMWVC0 REhA== X-Gm-Message-State: AFq9FYIcjw004NusJxJY/Nj21J8aFxK+kP1XUx+Y/zDM23xnpqIH0oIY PFzbDGgXMRN0GCOO8nawCI/bO5meOG3QYJvmm/mxc6pwTujLzC2htPc= X-Gm-Gg: AYBFou05jdY54gwKMIwrsXiIuJrlnHc92iCEYVgju4YpCGMftSS2wDexqLS6OjBcSsf 7nvalpxmOsPzkYnu09f5xgtLQ+jazRp3PmbbQS+PuXIlK85mUdkqFV1DwZuy4+9PvXZ7jNV6RQ1 YD4LGkcntgEPhKf6kbptim6sM1IONu+p6frKdHXn1scr4C0zA8ij2/aHh6Xe1twVZzUDdTrkT9P nyDv7uC2oehEfbOe+jxjOb5wmJr+L00qq0ke8I3KT6mXuKWrePInrvItSvAfrTxKVJuwdjRmFHF heCxRH5Tk7D2cV56PgXet7aOG3t/H9LoEjrwZqkSLjp2TfsJ8vZVXqkFKCfEBp3IuAlOwZqUEX1 JHBQAbYHiHYz7j8t7dWQgUHLSL5rrssdvilR3NzDEhTAiPzVnLAVO4Td2dRtusvNOOuvtfc8LGF gdMhufXMV8LkvdQs+rauhCn/VLhwBLUjJN+VRniBsO X-Received: by 2002:a05:600c:4e8a:b0:49f:cbf3:551c with SMTP id 5b1f17b1804b1-4a1d75f8399mr129264985e9.12.1792359489145; Sun, 18 Oct 2026 14:38:09 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd500e75sm18597841f8f.42.2026.10.18.14.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 14:38:07 -0700 (PDT) From: Tristan Madani To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, Marcus Folkesson , Masaki Ota , Rahul Rameshbabu , Johannes Roith , "Daniel M . Lambea" , "Derek J . Clark" , Zhouwang Huang , David Barksdale , Don Prince , Clemens Ladisch , Tristan Madani , stable@vger.kernel.org Subject: [PATCH 3/8] HID: mcp2200: validate report size in raw_event callback Date: Sun, 18 Oct 2026 21:37:48 +0000 Message-ID: <20261018213754.1951187-4-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261018213754.1951187-1-tristmd@gmail.com> References: <20261018213754.1951187-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani mcp2200_raw_event() casts the report data to struct mcp_read_all_resp and accesses fields up to io_port_val_bmap (offset 10) without checking the buffer size. A device sending a short report could cause out-of-bounds memory access because hid-core invokes raw_event before it validates the report length in hid_report_raw_event(). Add a size check before the struct cast. Fixes: 740329d7120f ("HID: mcp2200: added driver for GPIOs of MCP2200") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- drivers/hid/hid-mcp2200.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-mcp2200.c b/drivers/hid/hid-mcp2200.c index dafdd5b4a0797..78a08d4d8f0d0 100644 --- a/drivers/hid/hid-mcp2200.c +++ b/drivers/hid/hid-mcp2200.c @@ -299,6 +299,9 @@ static int mcp2200_raw_event(struct hid_device *hdev, struct hid_report *report, struct mcp2200 *mcp = hid_get_drvdata(hdev); struct mcp_read_all_resp *all_resp; + if (size < sizeof(struct mcp_read_all_resp)) + return 0; + switch (data[0]) { case READ_ALL: all_resp = (struct mcp_read_all_resp *) data; -- 2.47.3