From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9DB4E01E7 for ; Sun, 18 Oct 2026 22:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792361031; cv=none; b=NMwDMCzLk0KcEcW529eJMztaMvAPWB7g42J2kwNjuG+zWEroQj2QTiCPGlrqlkFBOF929q10zMb/bmh64gTqbgR6GzrUx9/z9yuZef+cywVNdCms1cB5BkLq3RJqaLSeSn26W2UnLXYlfoNBXSqkAa4OctAtf2x0oY1iakAcVAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792361031; c=relaxed/simple; bh=e8wtLcepGB7m1WkPi16XBbmRmlD4CHncDaB4ghzbtZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nwvhzxVGBS+f5stOynnYZtMPfloyec7mF7lLa1goLeH1eC9RDE2hMVW97oIqjJAad59+nZHATD/zwz31gEJLLkoaxMgNHzMvWb4Gh+uY6BO+zcNYX8PWjLgFU+4B9pD+ZAUNCxCGLhzYBI47/jHqUjUhrKLra33OTGH5zHIxueA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NBBVvWaE; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NBBVvWaE" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-48e0d885929so931019f8f.3 for ; Sun, 18 Oct 2026 15:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792361029; x=1792965829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vAVYSc6bOeEhdjTuKd9lteCMjpiUz07VUT/q4gCOyPM=; b=NBBVvWaEm8EhWFtYDWlV5avkG/3Wvcifz2oI8e+ZTJFdYBR0PyQfD2pFkENpiEPRad PYTs5Xfwp+toItQ3X+n+zKsrQP5GAq9rrtRqfbNCcByv4pXjmuSQ4Ww5foXyLljhycop K5OvMlhVlWwxc48fMwhfYX8tjOn+GcURRON6ei48hhMkjg3ZhrY4isXaqnU6oFPbydvA caNPaUvakir+uzI2HseXgzwbF6SK4psjGYYDoKnulB1V59fheIfV7Dr4mTF1SViZmBPk 4UWD82y/0Bi9wjhvltnRr+LCYbmezET+xlZ4Kg807Rj1FM++ZgZ8litOk7rXmWbugzt/ Pnwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792361029; x=1792965829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vAVYSc6bOeEhdjTuKd9lteCMjpiUz07VUT/q4gCOyPM=; b=zLaEZ9ZU20NVQs6NjBCpV5W4XB6RBHx1R/Gxv5S9YsExOifKx54dzoTkdWoNuEtr5b ZzvLUlHlv9FFWc138bMABMBxw7uekKQ3GLT4UFGS5y/BS7vfjcdnlegFZjIInZmv9dPw cE1Bly4Ciz9F7GYqsmy4FqAtZU4I7U41mT8wIuUMdzmxBGqnxjSOIGYdDWTC+3E1acW2 ZkZXUom8cjz7r2Fb0rSjokQpS1lCpsUmzvZqse6KcMmdk43JcoyyN5XvgLS/6Qwvn6a8 0eh269B47HYBDscGa0DOftVuuZzkENcbo8xRnSxIS25wXAX6/J0EmJue1k/1p5TU1g1O R27w== X-Gm-Message-State: AFq9FYJ2xrOKDix1N51vlP+c0UofGkqTfJjDXZwOxzSimvvEiMTbrrUC W9/EJv1VcKHOboQG3Gm4e814+vWSjVGrzNLvBQMmz+Gzqi7tdeFkMJbxeyrW X-Gm-Gg: AYBFou2N3jIrx9PCiC+wcjBjw6MZglPMislAy9k8Olj+MJ5XF5XaE9IpZ4QVPkiRTwt 2/5SeE/+3IlZECNdp0RK52o6M2QYONNu0oH0fsqKPVZEHRe7Xzql7SOrcXYlCtMXJ3Wy6PkH24z HQ/XELWz6eGR4uW3/0JrlkZXbXyaOPu3nNsBfOZ3pDqK10Fq5A9IU2qT531d8/6yPC8B0lXR3k1 Ffu17ajUA6XU2aUcr9RKvlcU11GiSUs3671Whpf5j6DKMSouDZs2WOdvlwoJSlznONNMX+4vzXy 0BPaYtiurK3KWpV1zHIu4WfF78SKiP7o0WMzEl08bvyauLUUalkxV/+yF6faxhwIMt0jZ3Y/gra WyImRAwKzTBcB2LE580j9z4G0qGQOqlxAu+ghaTplJJjFoe8+8bEi8LwVunDZA+bJygg5kF/WiS lADqGVVrsWiE42pRGcJDzX9y52OKsixYvgLKTYk18= X-Received: by 2002:a05:600c:3f06:b0:4a1:7ba9:da2c with SMTP id 5b1f17b1804b1-4a1d760f7b9mr124413365e9.25.1792361028681; Sun, 18 Oct 2026 15:03:48 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1bd91c55bsm278731975e9.0.2026.10.18.15.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 15:03:48 -0700 (PDT) From: Tristan Madani To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, Marcus Folkesson , "Derek J . Clark" , Dmitry Torokhov , Tristan Madani , stable@vger.kernel.org Subject: [PATCH v2 3/8] HID: mcp2200: validate report size in raw_event callback Date: Sun, 18 Oct 2026 22:03:39 +0000 Message-ID: <20261018220344.1987142-4-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261018220344.1987142-1-tristmd@gmail.com> References: <20261018220344.1987142-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani mcp2200_raw_event() casts the report data to struct mcp_read_all_resp and accesses fields up to io_port_val_bmap (offset 10) without checking the buffer size. A device sending a short report could cause out-of-bounds memory access because hid-core invokes raw_event before it validates the report length in hid_report_raw_event(). Add a size check before the struct cast. Fixes: 740329d7120f ("HID: mcp2200: added driver for GPIOs of MCP2200") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- drivers/hid/hid-mcp2200.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-mcp2200.c b/drivers/hid/hid-mcp2200.c index dafdd5b4a0797..78a08d4d8f0d0 100644 --- a/drivers/hid/hid-mcp2200.c +++ b/drivers/hid/hid-mcp2200.c @@ -299,6 +299,9 @@ static int mcp2200_raw_event(struct hid_device *hdev, struct hid_report *report, struct mcp2200 *mcp = hid_get_drvdata(hdev); struct mcp_read_all_resp *all_resp; + if (size < sizeof(struct mcp_read_all_resp)) + return 0; + switch (data[0]) { case READ_ALL: all_resp = (struct mcp_read_all_resp *) data; -- 2.47.3