From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6EE94C6507 for ; Mon, 19 Oct 2026 10:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792404274; cv=none; b=SuQ+V8khRk8LwWBsA4yX4ufEW/TSH9bfOE4kALBsNv53jVGcY/WSao0HGh7fL0l44ww88IpAAAI7hhWhIkK7ybhWdNEUuv1OgGdOvEY43C1K0Y2ypO4O15jmmBr421wAg97jJCqePPk9Vb+FEw6QiFsKGo7enkHeSPsH13/mlKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792404274; c=relaxed/simple; bh=xKSwHjV9MWBrneCHrpcmIAXnVMD3k1CV+xjupjlFHNI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YvWlBuFr1hSlcZf9r3AmHmWufr8Che0JEt4wjt46OuSYn2HncnJL1qgs44J9FQdpsJ9xniXqNt1R246NtHU8KSz3xXY/i8QMFAuoPckaNMlS7CevHpGoOXOFV7ytSdsFzUE7OP0IfKkqfyXUqDGjZQXsZXdLxJEk3Qi0NjaiH68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CB8SDKbs; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CB8SDKbs" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-48dfaa3fa12so1878501f8f.0 for ; Mon, 19 Oct 2026 03:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792404270; x=1793009070; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=l1Lm639PRB96zSSZefHtpXtgtHCr2Dn1S/rpSpKuqg0=; b=CB8SDKbsxESQFRdIbCzfd27LDNEV7b3XfwPOA5zyuKwoO65CdMI410bbZQTAwbN2uA 45EO/H70E6xkZ0lZcAnO0jWhyB2eUdT57YLqIikWe4UmTViA2+p/NWCaUfIzOzxFQVXh AuaoBje+9mSvV9gHpnS/lF0CcALnallcCUuDh0339COhL0ZkVVIT4cdavMxihxqkvpv0 6x/C5qhkanjJEkgecwUkS2vQcl48/Qea9RUQrnQbt2U2Bg4jDyaVhjFdMlQLXk9bMYNA BWMzgWDhybFao1luaImXISKIafOKGX5/ifJzj/yTzj/bPLqkBDF5mfHJy2+hJ57nP+Wy /LDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792404270; x=1793009070; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l1Lm639PRB96zSSZefHtpXtgtHCr2Dn1S/rpSpKuqg0=; b=H7ijZ48wxiXf7aRxFLLdKv96UfLoOJi/rJv1JfcI+De9d/ObQSB677mD0KQPv1oa3L yEyu3icDZpLVA0Z44h5sggcHrB94X4Ej+sr8JPp/3y7cTcQN2unLFja+rmbw2Kn13atr TTUr/bdqN8IW1WbzUlxK2AJLPLlIKbZOmBinnLFegf0eExDN1HyIEHDFlU8bL1u0bd0/ y3aqhCL328Tx8FD8O81pJACJ6B0aLJHrHes/R/kC9NM3ptzZ6OhbQw5yjf6hMclimbHe 8AmFgo86lHkhSzp9NsprrxZB7eJt404N9KifrTU+pbXDhZuizTRUyvk5+Sgdp2vRJWJz cHgQ== X-Forwarded-Encrypted: i=1; AKwUvBx1cFVp5EqBjMyL0+ygwQprJapOX6lCUDBO99lVwVMDflALCoGXAlsnlwYReQPqHPBu2R07TgvJ6vSMCA==@vger.kernel.org X-Gm-Message-State: AFq9FYIsD+kTACJREzw3PHFTQNYCT9Cdy2yhaoi9GPOX3uqwAJvrt+En CQ/zuQHNtuoHk0nG+cBDptaLgpeD6qC8f9In8gN1HmYc6KcIodLXsW0r X-Gm-Gg: AYBFou0Q6P0WBy1HpCzHEsvrfAwcttL4Q31wongyU4ZT8Kg/zEasKqXlIetOQV070Bp W+nnx80kylSDVe0r7KqllLdjTfq1vFq2aYczim4JpUyCDXTIMbczZrKg/ZR2pDnClL0ucqNw76l 6NRBGOtFi4idmVjOx3Co3NkDxkFUzaI70mRo7a286uKGTx3wn3LSUMhypuFsYfdlk2654pnz/FN mo+wRDmiY9v0Dx9bqg9bZoehODZYS1+kbZ0uEtuQBwS+NhHzbf/1X3mTFxx5J4KeY+SbhbFqiBG KsE9Gm+vHSPrEecw+mZdQfmbk6ALVjIJinMpWaCfN+wGFgXY+Y9FsLfXNytCxR1wBqFBVC+vjr3 6ztTst3Sk/h9xd571QL+tp8bk5Anh9GQSiVNdb+GggS94kG4if9wBS8fiLjE6zEtL7NN6VJYY5o uCWtnpHdeZ4FfPoqmC/j+fjEWn7+stROxjL9/psV0DeSh4Wgrc63A9AQlatEYEyD2ESMiM3eqTk sW8U8Y3mumVo5M433U= X-Received: by 2002:a05:600c:4e42:b0:4a1:de8a:6046 with SMTP id 5b1f17b1804b1-4a1de8a6456mr102702195e9.3.1792404269498; Mon, 19 Oct 2026 03:04:29 -0700 (PDT) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1df164777sm177811485e9.5.2026.10.19.03.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 03:04:27 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Florian Krischer Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, mfd@lists.linux.dev, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v12 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Date: Mon, 19 Oct 2026 13:04:03 +0300 Message-ID: <20261019100406.103687-5-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261019100406.103687-1-clamor95@gmail.com> References: <20261019100406.103687-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Michał Mirosław Add support for multimedia top button row of ASUS Transformer's Mobile Dock keyboard. Driver is made that function keys (F1-F12) are used by default which suits average Linux use better and with pressing ScreenLock + AltGr function keys layout is switched to multimedia keys. Only Dock keyboard input events are tracked for AltGr pressing. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Michał Mirosław Signed-off-by: Svyatoslav Ryhel --- drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + .../input/keyboard/asus-transformer-ec-keys.c | 212 ++++++++++++++++++ 3 files changed, 223 insertions(+) create mode 100644 drivers/input/keyboard/asus-transformer-ec-keys.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index d8c64f333462c..728bc068667e7 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -89,6 +89,16 @@ config KEYBOARD_APPLESPI To compile this driver as a module, choose M here: the module will be called applespi. +config KEYBOARD_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Mobile Dock multimedia keys" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use multimedia keys present on Asus + Transformer's Mobile Dock. + + To compile this driver as a module, choose M here: the + module will be called asus-transformer-ec-keys. + config KEYBOARD_ATARI tristate "Atari keyboard" depends on ATARI diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index 60bb7baf802f7..0d81096887ada 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -11,6 +11,7 @@ obj-$(CONFIG_KEYBOARD_ADP5585) += adp5585-keys.o obj-$(CONFIG_KEYBOARD_ADP5588) += adp5588-keys.o obj-$(CONFIG_KEYBOARD_AMIGA) += amikbd.o obj-$(CONFIG_KEYBOARD_APPLESPI) += applespi.o +obj-$(CONFIG_KEYBOARD_ASUS_TRANSFORMER_EC) += asus-transformer-ec-keys.o obj-$(CONFIG_KEYBOARD_ATARI) += atakbd.o obj-$(CONFIG_KEYBOARD_ATKBD) += atkbd.o obj-$(CONFIG_KEYBOARD_BCM) += bcm-keypad.o diff --git a/drivers/input/keyboard/asus-transformer-ec-keys.c b/drivers/input/keyboard/asus-transformer-ec-keys.c new file mode 100644 index 0000000000000..ca54c4640b8ad --- /dev/null +++ b/drivers/input/keyboard/asus-transformer-ec-keys.c @@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_EXT_KEY_CODES 0x20 + +struct asus_ec_keys_data { + struct notifier_block nb; + struct asusec_core *ec; + struct input_dev *xidev; + unsigned short keymap[ASUSEC_EXT_KEY_CODES * 2]; + bool special_key_mode; +}; + +static const unsigned short asus_ec_dock_ext_keys[] = { + /* Function keys [0x00 - 0x19] */ + [0x01] = KEY_DELETE, + [0x02] = KEY_F1, + [0x03] = KEY_F2, + [0x04] = KEY_F3, + [0x05] = KEY_F4, + [0x06] = KEY_F5, + [0x07] = KEY_F6, + [0x08] = KEY_F7, + [0x10] = KEY_F8, + [0x11] = KEY_F9, + [0x12] = KEY_F10, + [0x13] = KEY_F11, + [0x14] = KEY_F12, + [0x15] = KEY_MUTE, + [0x16] = KEY_VOLUMEDOWN, + [0x17] = KEY_VOLUMEUP, + /* Multimedia keys [0x20 - 0x39] */ + [0x21] = KEY_SCREENLOCK, + [0x22] = KEY_WLAN, + [0x23] = KEY_BLUETOOTH, + [0x24] = KEY_TOUCHPAD_TOGGLE, + [0x25] = KEY_BRIGHTNESSDOWN, + [0x26] = KEY_BRIGHTNESSUP, + [0x27] = KEY_BRIGHTNESS_AUTO, + [0x28] = KEY_PRINT, + [0x30] = KEY_WWW, + [0x31] = KEY_CONFIG, + [0x32] = KEY_PREVIOUSSONG, + [0x33] = KEY_PLAYPAUSE, + [0x34] = KEY_NEXTSONG, + [0x35] = KEY_MUTE, + [0x36] = KEY_VOLUMEDOWN, + [0x37] = KEY_VOLUMEUP, +}; + +static void asus_ec_keys_report_key(struct input_dev *dev, unsigned int code, + unsigned int key, bool value) +{ + input_event(dev, EV_MSC, MSC_SCAN, code); + input_report_key(dev, key, value); + input_sync(dev); +} + +static int asus_ec_keys_process_key(struct input_dev *dev, u8 code) +{ + struct asus_ec_keys_data *priv = dev_get_drvdata(dev->dev.parent); + unsigned int key = 0; + + if (code == 0) + return NOTIFY_DONE; + + if (priv->ec->right_alt_pressed) { + priv->ec->special_combo_triggered = true; + + /* Flip special key mode state when pressing SCREEN LOCK + R ALT */ + if (code == 1) { + priv->special_key_mode = !priv->special_key_mode; + return NOTIFY_OK; + } + } + + /* + * Relocate code to second "page" if pressed state XOR's mode state + * This way special key will invert the current mode + */ + if (priv->special_key_mode ^ priv->ec->right_alt_pressed) + code += ASUSEC_EXT_KEY_CODES; + + if (code < dev->keycodemax) { + unsigned short *map = dev->keycode; + + key = map[code]; + } + + if (!key) + key = KEY_UNKNOWN; + + asus_ec_keys_report_key(dev, code, key, 1); + asus_ec_keys_report_key(dev, code, key, 0); + + return NOTIFY_OK; +} + +static int asus_ec_keys_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_keys_data *priv = + container_of(nb, struct asus_ec_keys_data, nb); + u8 *data = data_; + + if (action & ASUSEC_SMI_MASK) + return NOTIFY_DONE; + + if (action & ASUSEC_SCI_MASK) + return asus_ec_keys_process_key(priv->xidev, data[2]); + + return NOTIFY_DONE; +} + +static void asus_ec_keys_setup_keymap(struct asus_ec_keys_data *priv) +{ + struct input_dev *dev = priv->xidev; + unsigned int i; + + BUILD_BUG_ON(ARRAY_SIZE(priv->keymap) < ARRAY_SIZE(asus_ec_dock_ext_keys)); + + dev->keycode = priv->keymap; + dev->keycodesize = sizeof(*priv->keymap); + dev->keycodemax = ARRAY_SIZE(priv->keymap); + + input_set_capability(dev, EV_MSC, MSC_SCAN); + input_set_capability(dev, EV_KEY, KEY_UNKNOWN); + + for (i = 0; i < ARRAY_SIZE(asus_ec_dock_ext_keys); i++) { + unsigned int code = asus_ec_dock_ext_keys[i]; + + if (!code) + continue; + + __set_bit(code, dev->keybit); + priv->keymap[i] = code; + } +} + +static int asus_ec_keys_probe(struct platform_device *pdev) +{ + struct i2c_client *parent = to_i2c_client(pdev->dev.parent); + struct asusec_core *ec = dev_get_drvdata(pdev->dev.parent); + struct device *dev = &pdev->dev; + struct asus_ec_keys_data *priv; + int error; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec = ec; + + priv->xidev = devm_input_allocate_device(dev); + if (!priv->xidev) + return -ENOMEM; + + priv->xidev->name = devm_kasprintf(dev, GFP_KERNEL, "%s Keyboard Ext", + ec->model); + priv->xidev->phys = devm_kasprintf(dev, GFP_KERNEL, "i2c-%u-%04x", + i2c_adapter_id(parent->adapter), + parent->addr); + + if (!priv->xidev->name || !priv->xidev->phys) + return -ENOMEM; + + asus_ec_keys_setup_keymap(priv); + + error = input_register_device(priv->xidev); + if (error) + return dev_err_probe(dev, error, + "failed to register extension keys\n"); + + priv->nb.notifier_call = asus_ec_keys_notify; + + error = blocking_notifier_chain_register(&ec->notify_list, &priv->nb); + if (error) + return error; + + ec->ext_keys_enabled = true; + + return 0; +} + +static void asus_ec_keys_remove(struct platform_device *pdev) +{ + struct asus_ec_keys_data *priv = platform_get_drvdata(pdev); + struct asusec_core *ec = priv->ec; + + ec->ext_keys_enabled = false; + blocking_notifier_chain_unregister(&ec->notify_list, &priv->nb); +} + +static struct platform_driver asus_ec_keys_driver = { + .driver.name = "asus-transformer-ec-keys", + .probe = asus_ec_keys_probe, + .remove = asus_ec_keys_remove, +}; +module_platform_driver(asus_ec_keys_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-keys"); +MODULE_AUTHOR("Michał Mirosław "); +MODULE_DESCRIPTION("ASUS Transformer's multimedia keys driver"); +MODULE_LICENSE("GPL"); -- 2.53.0