Linux Input/HID development
 help / color / mirror / Atom feed
From: Paolo Pisati <p.pisati@gmail.com>
To: Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <bentiss@kernel.org>
Cc: "Paolo Pisati" <p.pisati@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Denis Benato" <denis.benato@linux.dev>,
	"Rebecca Mara Müller" <rebecca.mara@posteo.de>,
	"Luke Jones" <luke@ljones.dev>,
	"Joshua Leivenzon" <hacker1024@users.sourceforge.net>,
	"Ivan Levchenko" <me@livan.pro>,
	"Nathan Chancellor" <nathan@kernel.org>
Subject: [PATCH v4 7/7] HID: asus: Keep the Zenbook Duo input device names
Date: Tue, 20 Oct 2026 11:24:17 +0200	[thread overview]
Message-ID: <20261020092423.36380-8-p.pisati@gmail.com> (raw)
In-Reply-To: <20261020092423.36380-1-p.pisati@gmail.com>

hid-asus renames the input devices of the keyboards it handles to
"Asus Keyboard", except for the ROG N-Key ones, which keep the names
the devices report. New devices are not renamed any more, so skip the
rename for the Zenbook Duo keyboards too: their input devices keep the
"ASUS Zenbook Duo Keyboard" names they get without this driver.

Suggested-by: Denis Benato <denis.benato@linux.dev>
Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
---
 drivers/hid/hid-asus.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 6ee2ecca864d..69894de8f6ce 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -1712,10 +1712,10 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
 		hid_warn(hdev, "Failed to initialize backlight.\n");
 
 	/*
-	 * For ROG keyboards, skip rename for consistency and ->input check as
-	 * some devices do not have inputs.
+	 * For ROG and Zenbook Duo keyboards, skip rename for consistency and
+	 * ->input check as some devices do not have inputs.
 	 */
-	if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD)
+	if (drvdata->quirks & (QUIRK_ROG_NKEY_KEYBOARD | QUIRK_ZENBOOK_DUO_KEYBOARD))
 		return 0;
 
 	/*
-- 
2.43.0


      parent reply	other threads:[~2026-10-20  9:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  9:24 [PATCH v4 0/7] HID: asus: ASUS Zenbook Duo keyboard support Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 1/7] HID: asus: Fix up Zenbook Duo report descriptors Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 2/7] HID: asus: Add missing Zenbook Duo hotkeys Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 3/7] HID: asus: Force hid-input to bind to the Zenbook Duo hotkey interface Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 4/7] HID: asus: Cycle the platform profile from the Zenbook Duo profile key Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 5/7] HID: asus: Do not send feature reports larger than declared Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 6/7] HID: asus: add prod-id, quirk for Zenbook Duo keyboard Paolo Pisati
2026-10-20  9:24 ` Paolo Pisati [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020092423.36380-8-p.pisati@gmail.com \
    --to=p.pisati@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=denis.benato@linux.dev \
    --cc=hacker1024@users.sourceforge.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=me@livan.pro \
    --cc=nathan@kernel.org \
    --cc=rebecca.mara@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox