From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793399828; b=oJBdB4J9MFeigZYCNw6kuJo6cvP0aCHYgmDqxspaxA8OhamxUsdTtEDwlnFSxZLaD4Pr 0M9/T1X9cNZLikalPPl38XFao3ZZY4BdneXkE9huDs5G9qjGHtfPx9ChtERyn+RIyQKGe 5lNZZhj7vrvT9nZaUCq7HahvZoA/XkZzhywWcYG5JL/v0M45/7W14LMPWPz+y4y5XfaoH 3h5/Uu4LtWwjRX4mw1Bi8NgnqMY5dK1S0SyqGOGQCWbj2cE0/1nGTS3a5QizsKwFPENdb IrJMWEsdFyhQw9RcNt809devAypkfgCFmC1uNVLH9fkwCaNzHF5dq+dlLIeTm4/ugxQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793399828; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=JTE/z18z9ZA/r3X5bUnDyeVPzt0i08fqynrLX8skefw=; b=tVVQix/jWsBv+pFz5IfRdcZw7kiWhKWqUvpIBz59GqU1mkkQc63c+EYjMmLWPgfeM75L ZkbsfBLMruQwtbshVxCp018Dpuk1twlwqzw+RmH214+I9NkUCeKubPc5XsaxdRIkVTptR 9jD708nwfT7HhuCbEP/IqndfQ0feH/Fyczwymk7jYJU7A6rx3SLfXGngnW+JH8bfM4EF/ vPVCBoJdyNo/lx3e7xOOe2Sr9uLRh30IlrxAdEnu2A1jv9g1eU7GPb7E+Sxwb5IqbyJ7I sdB6zo0VbP5dP78RhU04gpJwzoHZ+Uh0FXc5R//w7fbFPdT+MTkbblgv/UK7sRy6foA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=t3w6AXSB; arc=none smtp.remote-ip=209.85.221.52 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A55606A332 for ; Fri, 30 Oct 2026 22:37:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 43A55606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=t3w6AXSB Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48af4d4e61fso700991f8f.2 for ; Fri, 30 Oct 2026 15:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793399827; x=1794004627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JTE/z18z9ZA/r3X5bUnDyeVPzt0i08fqynrLX8skefw=; b=t3w6AXSByaT6gcCicsKZNzDXGesNxngeLdT2vwwdzCcCs1IR7xtfpKb+GpOJq9U5wX 2JLGFeE4OwjdVSbsSn3mbifgPb9u7qbZELJMKiwpxU3IBl0Z2nM6A0DU/LHUP95h4HJK QmGtmN1xuDh4QNHFWnGItjr7LsLrrSqwP0lGdJS8WCngYbAMMBaLDWXOweAyFrg0aqro HSPj56YRd4WL/oeZZlMChJM6vYlLe8I2xj/6TWuiIRwtgEu+RdoV1eF5jXFlp7vbNpH/ +QOEztPSmZp7tGfgw7PczW8kCvE+I/V4oBKbxqO38fgaLfUsjgtfLbqsxVViVIRZBAQm dVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793399827; x=1794004627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JTE/z18z9ZA/r3X5bUnDyeVPzt0i08fqynrLX8skefw=; b=yOMv3kG38rZ1THJE12MuN/GeoLzIWzcWRR0xsi7MJfiLtAUccwUBEyuRoFq/0NLkXe B7C8JVNVhmnLgRPghMmJxamifmvDVmISkcrxZnnuQIl8fA62rgxF6c7P+PbsMKMXUanU +xtaQot8j5Z4wz0vjzttsgY5OzgaGo+b4H9Uj8O3JQuZMIm8TnNbEQyWu8mbp7maUl3J JXlNisiYWuE69sUF/2pOcp/T0lCNA1170P1j8eyYc+8XY4Wg7Teilg7SfopkAWZ7vwL2 waQ5LWsddOWkjd4HBfpWQXdJJD3CI/DDvOVtrIq5NlZ5ztochMUnFNtHjFNdvlGXLvd/ fO/A== X-Forwarded-Encrypted: i=1; AKwUvBwcHwIohsE173r32EPVLYi/fxnT4zFHfOZa6LtWGwwN6Bo5vZ8yuzs86tbj09xDDEVvIufppunmCY+v4Q==@vger.kernel.org X-Gm-Message-State: AFq9FYLUOfYnMvdlfnkZTE7cBK5/Rvd6l19reVzMvQjFiznkfL4WeGjB VnldC41uzISPjYBHWtQVCzbU7gZSsWK7jIhfm6YdoxiwJxVLS+PFZeEp X-Gm-Gg: AYBFou1byLIkGLdIbPuXcb2tTxWXJflkggQn1UMfqNw5C1TN2gEGsRwWz6HSmwsuF1/ cJJNLavlL79MgH1/dr3nW2d4VJ52iEz5I6VgK7OnAR5bPXnA7g8SDUyCFL8NFNYa1+GAriFizDJ vNGhWtwznchnweZdClaJfTgr2JC9fCspm5TvgPB+LvNvzmdjlsM4PbKPms/U480cjWCR1z9o/Nr eQUS1qxTT6zh9RNn2ZJeR56Eod0DGxlQMedRQgJabKwSkXIh16IwTmAzPENeB4E5i+kdicLkLp7 uKX5zq+2z8SvHcEXnfmZ2FTAvMCy8WjPAm/hWn6r4/FxbXqcAeG9UMgDlaEJJI8Mu02DGQa8v9K 26uSmEja71nuv2ZSyeU6u0ktB/YD8UJp/gfh0ybSZqkbh3BCVeIS3MwnwFKBw4LepXhZfmgc2fr in5MZPxBrd1VKlAO7XMCCkOduSBE3Q+tIb0e8L5Aj+9H/Ek2VfLsXOL/e2tC//Rax5nFhvYcp76 If9aWxD/bj1+cInX4vO3H0UMZY43IzStmy/+ei2wbSIbYLn8FcTu0kQi5WJZhVrxJQGa7uu4E/e iAKVUncg2c2N/X6IkGjmjHZUYzMVLemgNNHsT9px1ig3P5zI4g== X-Received: by 2002:a05:6000:2886:b0:48b:1119:5756 with SMTP id ffacd0b85a97d-48e6e2f6739mr8445762f8f.17.1793399826540; Fri, 30 Oct 2026 15:37:06 -0700 (PDT) Received: from m2.. ([37.142.145.227]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48e71b959c1sm5457300f8f.45.2026.10.30.15.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2026 15:37:06 -0700 (PDT) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v2 04/15] HID: ft260: i2c: reduce driver module loading time Date: Sat, 31 Oct 2026 00:36:26 +0200 Message-ID: <20261030223637.86907-5-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261030223637.86907-1-michael.zaidman@gmail.com> References: <20261030223637.86907-1-michael.zaidman@gmail.com> X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The HWMON class I2C client drivers register the address range to scan during the I2C master module probing. For example, the lm75 module registers eight bus addresses scanned during the ft260 module loading. In the case of ft260, the bus is scanned by ft260_i2c_read, but due to an excessive read completion timeout, it took about 40 seconds for the ft260 driver to scan the lm75 address range before exiting the probe function. Adjust the i2c_read timeout so it depends on the amount of data to read, reducing the lm75 address range scan time to about 200ms. The 25 ms per-report budget was checked on a UMFT260EV1A with a 24LC512 EEPROM by shrinking the timeout until reads began to fail: a 60-byte read still completes at 9 ms and times out at 7 ms, against 5.4 ms of wire time at 100 kHz, so the fixed USB, HID and scheduling overhead costs a few milliseconds. At the chip's slowest 60 kHz clock that chunk needs about 9 ms on the wire and a 180-byte chunk about 27 ms. Scale the wait by 25 ms per 60-byte HID payload so a last chunk of 61..180 bytes gets 50..75 ms, not the single-report 25 ms budget (reported by Sashiko). Signed-off-by: Michael Zaidman --- v2: last I2C read chunk timeout from rd_len (reported by Sashiko). --- drivers/hid/hid-ft260.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index e24f3151fdaf..f134fab08285 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -49,14 +50,20 @@ MODULE_PARM_DESC(debug, "Toggle FT260 debugging messages"); * The ft260 input report format defines 62 bytes for the data payload, but * when requested 62 bytes, the controller returns 60 and 2 in separate input * reports. To achieve better performance with the multi-report read data - * transfers, we set the maximum read payload length to a multiple of 60. + * transfers, we set the maximum read payload length to a multiple of + * FT260_RD_ONE_REPORT_MAX. * With a 100 kHz I2C clock, one 240 bytes read takes about 1/27 second, * which is excessive; On the other hand, some higher layer drivers like at24 * or optoe limit the i2c reads to 128 bytes. To not block other drivers out * of I2C for potentially troublesome amounts of time, we select the maximum * read payload length to be 180 bytes. */ +#define FT260_RD_ONE_REPORT_MAX 60 #define FT260_RD_DATA_MAX 180 + +/* Time in ms to wait for a single HID input report at ONE_REPORT_MAX */ +#define FT260_RD_ONE_REPORT_TO 25 + #define FT260_WR_I2C_DATA_MAX 60 #define FT260_WR_UART_DATA_MAX 62 #define FT260_GPIOCHIP "ft260_gpio" @@ -722,8 +729,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, u16 len, u8 flag) { u16 rd_len; - u16 rd_data_max = 60; - int timeout, ret = 0; + u16 rd_data_max = FT260_RD_ONE_REPORT_MAX; + int timeout, timeout_jiffies, ret = 0; struct ft260_i2c_read_request_report rep; struct hid_device *hdev = dev->hdev; unsigned long irqflags; @@ -748,6 +755,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, } else { rd_len = rd_data_max; } + timeout = FT260_RD_ONE_REPORT_TO * + DIV_ROUND_UP(rd_len, FT260_RD_ONE_REPORT_MAX); rd_data_max = FT260_RD_DATA_MAX; rep.report = FT260_I2C_READ_REQ; @@ -772,8 +781,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, goto ft260_i2c_read_exit; } - timeout = msecs_to_jiffies(5000); - if (!wait_for_completion_timeout(&dev->wait, timeout)) { + timeout_jiffies = msecs_to_jiffies(timeout); + if (!wait_for_completion_timeout(&dev->wait, timeout_jiffies)) { ret = -ETIMEDOUT; ft260_i2c_reset(hdev); goto ft260_i2c_read_exit; -- 2.43.0