From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andreas Kemnade <andreas@kemnade.info>,
Johannes Kirchmair <johannes.kirchmair@skidata.com>,
Yuki Horii <yuuki198708@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-input@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 5/5] Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt
Date: Wed, 11 Nov 2026 22:50:37 -0800 [thread overview]
Message-ID: <20261112065037.1800467-6-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261112065037.1800467-1-dmitry.torokhov@gmail.com>
Request the threaded interrupt with IRQF_NO_AUTOEN so that the interrupt
line remains disabled after probe until the input device is opened by
user space. Explicitly initialize the stopped flag to true before
requesting the interrupt and drop the immediate tsc2007_stop() call.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/tsc2007_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index 1fb2c26189ba..7660504f58ff 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -270,17 +270,17 @@ static int tsc2007_input_configure(struct tsc2007 *ts)
input_set_abs_params(input_dev, ABS_PRESSURE, 0, MAX_12BIT,
ts->fuzzz, 0);
+ ts->stopped = true;
+
err = devm_request_threaded_irq(dev, ts->irq,
NULL, tsc2007_soft_irq,
- IRQF_ONESHOT,
+ IRQF_ONESHOT | IRQF_NO_AUTOEN,
dev->driver->name, ts);
if (err) {
dev_err(dev, "Failed to request irq %d: %d\n", ts->irq, err);
return err;
}
- tsc2007_stop(ts);
-
err = input_register_device(input_dev);
if (err) {
dev_err(dev, "Failed to register input device: %d\n", err);
--
2.56.0.567.gdb80ae8cd5-goog
prev parent reply other threads:[~2026-11-12 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 6:50 [PATCH 0/5] Input: tsc2007 - drop platform data support and cleanups Dmitry Torokhov
2026-11-12 6:50 ` [PATCH 1/5] Input: tsc2007 - drop platform data support Dmitry Torokhov
2026-11-12 6:50 ` [PATCH 2/5] Input: tsc2007 - remove unneeded memory barriers Dmitry Torokhov
2026-11-12 6:50 ` [PATCH 3/5] Input: tsc2007 - fix minor coding style issues Dmitry Torokhov
2026-11-12 6:50 ` [PATCH 4/5] Input: tsc2007 - do not register input device without IRQ Dmitry Torokhov
2026-11-12 6:50 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112065037.1800467-6-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=clamor95@gmail.com \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hns@goldelico.com \
--cc=johannes.kirchmair@skidata.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
--cc=yuuki198708@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox