From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jaewon Kim <jaewon02.kim@samsung.com>,
Hyunhee Kim <hyunhee.kim@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] Input: regulator-haptic - fix coding style issues
Date: Wed, 11 Nov 2026 22:51:15 -0800 [thread overview]
Message-ID: <20261112065115.1803973-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261112065115.1803973-1-dmitry.torokhov@gmail.com>
Fix minor coding style issues across the driver: add a comment
explaining mutex purpose, drop an unnecessary blank line after an open
brace, align function arguments with the open parenthesis, fix
whitespace in conditional checks, and use a space instead of a tab in
a return statement.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/regulator-haptic.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/input/misc/regulator-haptic.c b/drivers/input/misc/regulator-haptic.c
index d99f716ef44b..4ede90195366 100644
--- a/drivers/input/misc/regulator-haptic.c
+++ b/drivers/input/misc/regulator-haptic.c
@@ -23,7 +23,7 @@ struct regulator_haptic {
struct regulator *regulator;
struct work_struct work;
- struct mutex mutex;
+ struct mutex mutex; /* serializes voltage updates and suspend/resume */
bool active;
bool suspended;
@@ -38,7 +38,6 @@ static int regulator_haptic_toggle(struct regulator_haptic *haptic, bool on)
int error;
if (haptic->active != on) {
-
error = on ? regulator_enable(haptic->regulator) :
regulator_disable(haptic->regulator);
if (error) {
@@ -55,7 +54,7 @@ static int regulator_haptic_toggle(struct regulator_haptic *haptic, bool on)
}
static int regulator_haptic_set_voltage(struct regulator_haptic *haptic,
- unsigned int magnitude)
+ unsigned int magnitude)
{
u64 volt_mag_multi;
unsigned int intensity;
@@ -118,7 +117,7 @@ static int regulator_haptic_parse_dt(struct device *dev,
int error;
node = dev->of_node;
- if(!node) {
+ if (!node) {
dev_err(dev, "Missing device tree data\n");
return -EINVAL;
}
@@ -165,7 +164,7 @@ static int regulator_haptic_probe(struct platform_device *pdev)
input_dev = devm_input_allocate_device(&pdev->dev);
if (!input_dev)
- return -ENOMEM;
+ return -ENOMEM;
haptic->input_dev = input_dev;
haptic->input_dev->name = "regulator-haptic";
--
2.56.0.567.gdb80ae8cd5-goog
prev parent reply other threads:[~2026-11-12 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 6:51 [PATCH 0/2] Input: regulator-haptic - drop platform data support and style fixes Dmitry Torokhov
2026-11-12 6:51 ` [PATCH 1/2] Input: regulator-haptic - drop platform data support Dmitry Torokhov
2026-11-12 6:51 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112065115.1803973-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=cw00.choi@samsung.com \
--cc=hyunhee.kim@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox