From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794697735; b=2PczhZ+H/9AmQfsNu9l41mVQaT7xJy/S3Qs4n4If4DQFhg0z9YPtzTpuvO/dzGnDhpWo ZEyACrER/u5i5QKlI6HJMmG9s/czH2xhtnS6veCS48bp5CgGx7zGkIlta6nATbRJAytkO oRKwHIx5y3Ihcz7MY+N/o/17jL8sfBh8+YiWRInSiqy8hIXoNHUXXWzL2KV8m7MocYLQb iiZX9fpfe1uiQvG1Bq2Fm5pZwfBjg7l7KBwG2wP7gBBavgw9hDen1B6fioG7cY6MYA/0l SOYkyt7xqJdjppd4nAINlQexpdEFEVWArUMdWQqU1D7B/NwwedNVKgHCl0LSE/1dv5w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794697735; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=hh9ybCpP5y8fCdG/ue0SgeIlejwXAiQet93xa73o/ck=; b=G6wxL9bEZOtdRSSeW2vFMjFYuzJUiRFFLAMZVGa1pLhCwTJsNfGwNXLyzMjIezLJQ/Gh 719HJuZnQHDbHMHnyc4nDG0aTT8UjAF3st993SFeDjseuygDn+Qd93bs/uVo6kMXVOBHC nYDn5B4QGQ3Z7r1GHFT4WTwT4zDrraz/pmgTHAqneDE3sq/JNm0uveLwe7qenmcZhsGJy 5RGEhJAtsdRzNZbGLiBtpvHpaTcwWFK/kl8xNbZ9Y5uJwABOFrfbnk8+N0zTvkbQ0oxlY YfpJUe766v/KGDgl5E5HyGN+HiI6wnit+9Va7HVctn4Yx9fPfHoGEETrkQXcAEzHWgw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="jeFJb/c0"; arc=none smtp.remote-ip=209.85.221.45 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F1A60A2606 for ; Sat, 14 Nov 2026 23:08:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E0F1A60A2606 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jeFJb/c0 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-490d59c3f0aso782327f8f.1 for ; Sat, 14 Nov 2026 15:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794697733; x=1795302533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hh9ybCpP5y8fCdG/ue0SgeIlejwXAiQet93xa73o/ck=; b=jeFJb/c01M9tftwZV+FhKblIVrnpLKLb+K0qW29KG8tNYlpIt2M0ZA/r3nSu2sNB00 MwRBxF+fvkIJobYzGZlbR9zhP1oSohsw9+QLS/qLiDoNr215xRcFwSxqToxY1PgEr75G yYxSxbq6ZprH62dUFNhBIkEqmEUTIkYo0m3OKc18rbjj+64lwlFKnKcFeT/TuI2fIxO8 PRtGSohTG4gGxMjlnn1dqiOCGxe2BYWtY9zeyiN91yQZltWhb0tuB8CrrBgn1XoUZV6A PZzeLPUWEFUUBdoh7wkx6yS4wTgfvAuxvZ7LbaWK0TgMCAYSd3RO1Vkt4JkvyslI6ypC 8d8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794697733; x=1795302533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hh9ybCpP5y8fCdG/ue0SgeIlejwXAiQet93xa73o/ck=; b=sKdJH5YjxscFn8X5xj5KP037qqm6yk2FgNBiVrg3w9JnLsY+28mmodtyc/JvontXWD u3RfJHjzn/DSAf7TWpU7vEV5HgHYg5oMbHQu5JcV6fCuqxdkBviWiMVOzDzQKG+/ZBpL HmRIfI9cTLYhVxwNXTy7OAGBHtaRHkOnbrgKp2qyKYJMnqGTE1JM96ji+zum4vZShCaG /7au/UO+2flHixD3QkMXkKYXpiS7JyXvp4zxezwXZwMeFtdB33WMfgE2LEuxMHpzNHN7 xhaM+9CDOV8Mlkoym089Yxo1AgNuLF9b5DmUyDvI6GWAWAIbSBZ5t+3y9poE7+EwaaJO e36w== X-Forwarded-Encrypted: i=1; AL+hErGd9ZksLXL0we8AQhcESHxnCANTqtbajubBGa3heDax4cNnen9CtSmyLNSqUUSssQ6fGbMk8v3ax7/JxA==@vger.kernel.org X-Gm-Message-State: APuU4Z9jvSQkel0EKoDYXhRNVbxBloN23vKuba4ud6glb5Hh9usSo0zn BoMGj0wyj7uQYCLX+0DlS4CYrilYsXjBYF/Dl64TgFZy93SE5f3r9ArR X-Gm-Gg: AYBFou15fUaHDn5kmTHkvJJ5mQIEReZysd96M9Rtr8wqTbhCyiXQ/t0DYKN8wxydqCn tPt91iUxOZ0CXtfUZdiHD/czgk1NT5JYhI8p94/MgJqY28hDZhZHThe6putUjzwkoWzJD5ilRSk LKl+KHM/68G1C0C6YATp3R7kQJXlXLSsRu3G/BnUEe6WqSZcARixrTkXbc6NPafVdbK89pptF1Z jhY9vPKw/5vUymtJV/cp5yUtsaGUEM+vyW8WUEHn6AoI8d0TQvwsJf1UHrgfgZp9HFv2qbwg4Z3 wsdfaNm7lWxzsa1g8LmerUGlJFsnGeY5ZoOZL4UzVLdJ5zGS+oz0MNc8hFeMVRzhuuhaoNNIoJZ q6nW8pQ2ambWpa58G3Gtcd8Liuk3UCJwxk9+ww6knhUvEqDjsiSFm+LKeH80KB3D7EiV0GYbTez hIp+9lmh71nFsm0StYP+C/cGnRLdXMUuCp7fsKxN5yAAa+FWUTasrCu7chpSddMUr0pbKdYpq1O sDcLqcH9s1ozaNBAv2pJ0motmWrwbUOx6uoL/xBebPaRWhm1LF6BYIu3mXAkonRsuDCpj9XTfzp 8ZMpPMLVjYqAU0bWmWwuGrRGt+g7 X-Received: by 2002:a05:6000:1a8a:b0:48b:f93:3b87 with SMTP id ffacd0b85a97d-49c726da6e1mr15621389f8f.30.1794697733385; Sat, 14 Nov 2026 15:08:53 -0800 (PST) Received: from m2.. ([37.142.149.161]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-49c5d03b10fsm14910018f8f.1.2026.11.14.15.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 15:08:53 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v3 13/16] HID: ft260: i2c: reject an I2C clock outside the supported range Date: Sun, 15 Nov 2026 01:07:57 +0200 Message-ID: <20261114230800.1344401-14-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261114230800.1344401-1-michael.zaidman@gmail.com> References: <20261114230800.1344401-1-michael.zaidman@gmail.com> X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The clock sysfs attribute passes any 16-bit value to the chip. The chip accepts it, reports it back in the I2C status report that clock_show reads, and runs the bus at the 100 kHz default. A read of 2048 bytes takes the same 0.298 s after writing 50, 3500 or 65535 as it does after writing 100, while 60 and 3400 give 0.387 s and 0.058 s. Userspace has no way to see that the value was not applied. Refuse a value outside the 60-3400 kHz range named in the datasheet section 4.4.16. ft260_uart_change_speed() checks the baud rate against FT260_UART_CFG_BAUD_MIN and FT260_UART_CFG_BAUD_MAX, but termios has no error return, so it falls back to 9600. A sysfs store can return an error, so the clock store refuses the value. FT260_WORD_ATTR_STORE() takes the parse function as a parameter now, so a word attribute with no range of its own keeps passing kstrtou16. Signed-off-by: Michael Zaidman --- drivers/hid/hid-ft260.c | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 5564ed62cc48..391128e4bb35 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -69,6 +69,11 @@ MODULE_PARM_DESC(debug, "Toggle FT260 debugging messages"); #define FT260_WR_I2C_DATA_MAX 60 #define FT260_WR_UART_DATA_MAX 60 + +/* I2C bus clock range in kHz, see the FT260 datasheet section 4.4.16 */ +#define FT260_I2C_CLOCK_MIN 60 +#define FT260_I2C_CLOCK_MAX 3400 + #define FT260_GPIOCHIP "ft260_gpio" #define FT260_GPIO_0_5_COUNT 6 #define FT260_GPIO_A_H_COUNT 8 @@ -1592,6 +1597,25 @@ static void ft260_attr_dummy_func(struct hid_device *hdev, u8 req, u16 value) { } +/* + * The chip takes any 16-bit value and reports it back in the I2C status + * report, but runs the bus at the 100 kHz default when the value is + * outside the documented range. The report gives no way to tell the two + * cases apart, so refuse the value here. + */ +static int ft260_i2c_clock_parse(const char *buf, unsigned int base, u16 *clock) +{ + int ret = kstrtou16(buf, base, clock); + + if (ret) + return ret; + + if (*clock < FT260_I2C_CLOCK_MIN || *clock > FT260_I2C_CLOCK_MAX) + return -EINVAL; + + return 0; +} + #define FT260_ATTR_SHOW(name, reptype, id, type, func) \ static ssize_t name##_show(struct device *kdev, \ struct device_attribute *attr, char *buf) \ @@ -1649,9 +1673,9 @@ static void ft260_attr_dummy_func(struct hid_device *hdev, u8 req, u16 value) FT260_ATTR_STORE(name, reptype, FT260_SYSTEM_SETTINGS, req, \ u8, kstrtou8, func, FT260_STORE_NATIVE) -#define FT260_WORD_ATTR_STORE(name, reptype, req, func) \ +#define FT260_WORD_ATTR_STORE(name, reptype, req, strtou, func) \ FT260_ATTR_STORE(name, reptype, FT260_SYSTEM_SETTINGS, req, \ - u16, kstrtou16, func, cpu_to_le16) + u16, strtou, func, cpu_to_le16) FT260_SSTAT_ATTR_SHOW(chip_mode); static DEVICE_ATTR_RO(chip_mode); @@ -1704,7 +1728,8 @@ static DEVICE_ATTR_RW(clock_ctl); FT260_I2CST_ATTR_SHOW(clock); FT260_WORD_ATTR_STORE(clock, ft260_set_i2c_speed_report, - FT260_SET_I2C_CLOCK_SPEED, ft260_attr_dummy_func); + FT260_SET_I2C_CLOCK_SPEED, ft260_i2c_clock_parse, + ft260_attr_dummy_func); static DEVICE_ATTR_RW(clock); static ssize_t i2c_reset_store(struct device *kdev, -- 2.43.0