From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794697720; b=yXbbWeWdnGkmdGxS4+l4Ql+4KY5VLZqkK5epCgpNC9ZBf2Osd0v47UCFaRGglNybN4N0 kNiK8ipDLp8O1qL40e+2EvDpQohCvzSgBftQt3zcEMR0eOVG8lQeGsEFdTSOD/1R8bCTI ThO1wc62/TiCIKA0RL4okhDEadf11Ip2RA/9nN7+RI1g2C+3XbkGZpLGxlGRqo6KWA1FN cdFzkpFCGoGlqqz71RThBC+3W8C7YAwMn8t7nyYv6aL1d7YcdL15ik4q8Z8SODA+nR59i GcJjkPSPhdAYpPriRHGlLeFlp5jS5xm2YD7o9UHSLfISjnd2FZIqzSCpB5gCi/qBuLQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794697720; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=6gQE3IU+t2cIqdtVZhrTpEEYl5O5vhKOK1Q7R6X/tsg=; b=hmcM+ul7Q8oWUvHHpMTRZ7hqcr/vPpHcqfFso11VcoTLOdopX5q/PWO8c5lQ3AtFbB9i PZihy0TtEez2SqYZ1aYD5M3LFNdRmTcheo/53aSmbwydeYekJjDcAR65+lApiCAQ/fQfL ETrRbdTu79wlByo7RLVP8tQbQf5ttWcEwWRSNXt8DeIQpz6dti2ht2k6BmfoiUra+cPYQ FjoMGZNVvQ0H+cqUFscAr8Qi1kvKAB5wuSPnS6xQxJrnSj+31KiFGSsKNelMEAFkxsoHH UZAuEaeHXtU2TE6Opu3a/X63yO2HSeDCvZlm/KAVxS8CBsybtJyNl9zyTLu5zKv6WQA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DzSqjZd2; arc=none smtp.remote-ip=209.85.128.46 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350B760A263C for ; Sat, 14 Nov 2026 23:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 350B760A263C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DzSqjZd2 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4bb666304fdso3504365e9.0 for ; Sat, 14 Nov 2026 15:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794697719; x=1795302519; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6gQE3IU+t2cIqdtVZhrTpEEYl5O5vhKOK1Q7R6X/tsg=; b=DzSqjZd223Xa2elVAQbBkL6ejqVgE4nK5Yshf20ooHKziJQK2mgAEAXDKFgmVWyiSO nvKfNG6QmenzeaFXtWwoRLOAaH9ZcSxrlIAwL8mkpCirGe2nAx3S7j0x9qHIY8iv93o1 udRKrfiuqFz7gRZ4sSRBLO382WKomnZYUdKJv7cpxeec3qzeQjF+vE8TP9VC81m0w0kn 2OocJCXx2gFPpO3GS5le07hQKTb3fpdDiOO659DvFBekV3WFLiJ6x/ywAgBxzaGHB9dE rfINzOwENIrjTD/n8Jtc1ev1zXxRmQmhqX91w+Fj0XAi7H7sgTXrMEz1XR9KeKjaDQor DINQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794697719; x=1795302519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6gQE3IU+t2cIqdtVZhrTpEEYl5O5vhKOK1Q7R6X/tsg=; b=RoaHfBbh3PNcGQjdxY+addUycb6kTejcTydBcQOTsJ0+5K61GYdq4W0RxSda4GWQcR YFeinrpD7RjJkU5XOZ+F196F7cBTwGJftj70+EfNHB9ig5C+y5jSkKaQAoIPHAusE0gH nrLQayBB0YeI/hQbKtUq69tQXZX5I8XVSzZCLuyX7BwiWZQLTejb52p2DEIfXTctb8gl x/yZo2yA4u3H2BjL5/818sIUHdmtYcNPhWPSCw/VWvviGnOr+VEXLSTD3ubURbDtHa53 7acJ/QUN3m45n/WeEcoq6qej4aCyynkfOYZpATd/1JfDn2lQE0UVdSQlyyZf7fF2TjpM wQcA== X-Forwarded-Encrypted: i=1; AL+hErHhoH/4kHYoZiQNCFhQBPQZEaqAl3eO/eCA9p56sZyJTArqjpPuHWkFYX8EHZ+12ubLVhEx1gsJgpjkhw==@vger.kernel.org X-Gm-Message-State: APuU4Z/GNq+LsBEMe7Zynj2RITztXfQjyJcooSs3tlCekxMuJE8aZTGD gZn+t9JxYctuFEtvtGvqsAmwlqEqU4tyfZ19FVGRJzSj7BdrPUH3MnNRSb3DNMRMYcY= X-Gm-Gg: AYBFou0VenEEt3DZDGw37ktw55GMJ8fmaGOB2qWKfR5kZuc+8nC5yGIYe0ryNk6ujb6 v1TjCbLBwNyJdmc17i2Anq4v8c/MAu0zgObV29HEtpuhzyxsX92W5Am55FAynYTj4DYmMJhjpwb 9382pytYUzi0+kKdy/aif2U+VzfhtbGxMJR7qJbUP1Fc3E+/R1rKr5oBu87FfYCv6qL1F1Hn58/ PTK8S0j4mIWDrtiG3ref38T/y9tMFlxqnuGTjYcWhFsqK009FsppREVv9UjQ1+uw3FkO2i2RXkB 30vSQCIh+82B5PCvoFBGapN/jGzwEwsuwIlP1/6UnqE5vCC6iXNoGkIvOupoG7e4R1ZhPgRiota efwzZ5IwgJQWF3OQ9HacQzxLgT5xlIxiiW6QPjszgErcJwVMvBVMaJvQzCmFGTxlba6HfgymNJ9 KEiGfcOBstcrJR4RTEiPR1g5um1P8k8IPdfJKG1OG6A8zOJp0lq14pCEsAjkegBiRyQ36CfQRli 6OBBLb+2UekuUZkT35qFMxm2jS1a3Wo6Rwc7S15/lPRJ2bzM1JZ69uxvbfLp4i2ZAVdxDALnmCm KCmAwTSWJtu0BTkTBm6h/bjiPubE X-Received: by 2002:a05:600c:588b:b0:4bb:643e:3b8a with SMTP id 5b1f17b1804b1-4bb643e3bd6mr54723335e9.17.1794697718472; Sat, 14 Nov 2026 15:08:38 -0800 (PST) Received: from m2.. ([37.142.149.161]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-49c5d03b10fsm14910018f8f.1.2026.11.14.15.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 15:08:37 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v3 06/16] HID: ft260: i2c: reduce bus-error message severity Date: Sun, 15 Nov 2026 01:07:50 +0200 Message-ID: <20261114230800.1344401-7-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261114230800.1344401-1-michael.zaidman@gmail.com> References: <20261114230800.1344401-1-michael.zaidman@gmail.com> X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver logged errors when the FT260 reported an I2C bus error or when ft260_i2c_write / ft260_smbus_write failed after such a status. That was meant to flag unexpected failures, but bus scans (i2cdetect, HWMON discovery, transceiver monitoring, and similar) hit missing devices routinely and should not fill dmesg with lines such as: ft260 0003:0403:6030.0001: ft260_i2c_write: failed with -5 Keep returning -EIO, but print those via ft260_dbg. Still use hid_err in ft260_hid_output_report_check_status for actual HID/USB transport failures, which are genuine errors. Drop the extra __func__ from the write-path ft260_dbg calls; the helper already prints the function name. Signed-off-by: Michael Zaidman --- v2: Fix for the issue reported by Sashiko: the write-path messages printed the function name twice, because ft260_dbg() already prints it. --- drivers/hid/hid-ft260.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 13dbff661fab..270481766e2c 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -577,7 +577,7 @@ static int ft260_xfer_status(struct ft260_device *dev, u8 bus_busy) * to 1, bit 1 is also set to 1. */ if (report.bus_status & FT260_I2C_STATUS_ERROR) { - hid_err(hdev, "i2c bus error: %#02x\n", report.bus_status); + ft260_dbg("i2c bus error: %#02x\n", report.bus_status); return -EIO; } @@ -611,6 +611,7 @@ static int ft260_hid_output_report_check_status(struct ft260_device *dev, ret = ft260_hid_output_report(hdev, data, len); if (ret < 0) { + hid_err(hdev, "%s: failed with %d\n", __func__, ret); ft260_i2c_reset(hdev); return ret; } @@ -650,7 +651,6 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, int len, u8 flag) { int ret, wr_len, idx = 0; - struct hid_device *hdev = dev->hdev; struct ft260_i2c_write_request_report *rep = (struct ft260_i2c_write_request_report *)dev->i2c_wr_buf; @@ -681,7 +681,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, wr_len + 4); if (ret < 0) { - hid_err(hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("failed with %d\n", ret); return ret; } @@ -697,7 +697,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, u8 *data, u8 data_len, u8 flag) { - int ret = 0; + int ret; int len = 4; struct ft260_i2c_write_request_report *rep = @@ -722,7 +722,7 @@ static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, len); if (ret < 0) - hid_err(dev->hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("failed with %d\n", ret); return ret; } -- 2.43.0