Re: [PATCH v3] Input: synaptics - support the touchpad LED on RMI function $30

[ahmad baghereslami <ahmad.b1995@gmail.com>]

On Sat, 14 Nov 2026 09:24:32 +0000, sashiko-bot@kernel.org wrote:
> led_trigger_set(led_cdev, NULL) calls led_set_brightness(led_cdev,
> LED_OFF), which invokes synaptics_rmi_led_set() and sets priv->rmi_led_on
> to false.  cancel_delayed_work_sync() then cancels the pending work before
> it can write to the touchpad, and the check on priv->rmi_led_on is false,
> so __synaptics_rmi_led_set(psmouse, false) is skipped and the hardware LED
> stays on.

Right. The same happens without a trigger when the brightness is set
to 0 just before an unbind: the work cannot take psmouse_mutex, so it
is cancelled before it reaches the touchpad.

v4 will turn the LED off in synaptics_rmi_led_unregister() whatever
rmi_led_on says, as synaptics_rmi_led_init() does. I will wait a few
days for other comments on v3 before sending it.

Thanks,
Ahmad