Linux Input/HID development
 help / color / mirror / Atom feed
From: Emfox Zhou <emfox@debian.org>
To: Even Xu <even.xu@intel.com>, Xinpeng Sun <xinpeng.sun@intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 0/2] HID: intel-thc-hid: PRD tables under a drain
Date: Tue, 17 Nov 2026 18:27:24 +0800	[thread overview]
Message-ID: <20261117102726.271503-1-emfox@debian.org> (raw)

The PRD tables lose capacity when a frame is left unread, and a drain can
reach a ring that a reset already rewound. Rebuild the tables before the
engine that reads them starts, hold every path that stops an engine or
moves its pointers under the lock the drain takes, and stop the drain from
treating an empty read as a frame.

Patch 1 does the ring side in the core. Patch 2 fixes the two callers that
go by the buffer instead of the length they were given.

Changes in v6:

  - The stop, the rewind and the release hold the lock as well: a drain
    that had already passed the flag could still read an entry of a ring
    whose pointer had moved, and the teardown could free the tables under
    it.

  - quickspi and quicki2c no longer process a read that returned nothing.

Link to v5: https://lore.kernel.org/r/20261117093212.4122283-1-emfox@debian.org

Emfox Zhou (2):
  HID: intel-thc-hid: intel-thc: restore PRD table capacity
  HID: intel-thc-hid: quickspi, quicki2c: skip an empty read

 .../intel-quicki2c/pci-quicki2c.c             |  3 +
 .../intel-quickspi/pci-quickspi.c             |  3 +
 .../intel-thc-hid/intel-thc/intel-thc-dma.c   | 89 ++++++++++++++++++-
 .../intel-thc-hid/intel-thc/intel-thc-dma.h   |  8 ++
 4 files changed, 99 insertions(+), 4 deletions(-)


base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3

             reply	other threads:[~2026-11-17 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:27 Emfox Zhou [this message]
2026-11-17 10:27 ` [PATCH v6 1/2] HID: intel-thc-hid: intel-thc: restore PRD table capacity Emfox Zhou
2026-11-17 10:27 ` [PATCH v6 2/2] HID: intel-thc-hid: quickspi, quicki2c: skip an empty read Emfox Zhou
2026-11-17 10:36   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117102726.271503-1-emfox@debian.org \
    --to=emfox@debian.org \
    --cc=bentiss@kernel.org \
    --cc=even.xu@intel.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xinpeng.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox