From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794945913; b=LIPV6Cvp30T6gArQUQStuiFrGPNcHE3/E+j/x99YdRLzpg0s4rAifNdvZuTHVTQbuIVx jL/Gk5+r9G1Um6fgN692loYqn0NWkOMVyaXc17vOwwslppPz4sNSkaiHYOPF/GfnmK1qz 5pdh35FpO7eCjanf2XqMzN4+NrSuTVgw79KRyg/zp9M1/UzRKP+hLqMHReaKBtgySFITI AVsdng+J2Uld4DJVuAoo6xCg4ZDAL+LvyA3mF9KqLORmmc92nkSuJ4yRoPXZF3Uy7TzDg xqbqHesH/hekp5QkC6iX4KSvxx9KNy3kW3gO84GL+yY/w0sn7JQ+F8yOY2m/ZaUYkjw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794945913; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=TCa0RnoydsxVLT03DHyYOZOOaLc5gZ6BJdmvsECF/XY=; b=TbYEsZpNVK7w7JODqZTwNJGxrG2bLTItcOCb7kr+nK2GotmF349CWwsgYKuBZavNVE00 e8E86dwu/rY16WdOIaObP/dQjwBsf0+HcRTQ0eDhfHiy1M32sZk7GZV4oXH6MTuK0JdVe 2WHEg4ssZ0JUULhQlKj0DxtZLHRKbpOEtxYDJjW6ZgDSvF45nDpwRuJhKDEoXA+VZ2vVR B6A9l+YJsDJhva13u/IEaywOpogWeJnI6NSjSB5Fk5gYjUQZYnOtdxbEsocgrBmY/Jygg z5xk16dzVrPdLDI67PP85GaPRjRo0vIc/MXcqSW98hwP9OKK22ZG7Wnn9CpSK9vCLLg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=yqUGQQpu; arc=none smtp.remote-ip=209.85.128.50 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B2360A383C for ; Tue, 17 Nov 2026 20:05:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 70B2360A383C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=yqUGQQpu Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4a207b02a2cso1773685e9.1 for ; Tue, 17 Nov 2026 12:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794945911; x=1795550711; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TCa0RnoydsxVLT03DHyYOZOOaLc5gZ6BJdmvsECF/XY=; b=yqUGQQpuFJfvOn1h42r+LKmqo0q175gJjUF3epjGfvLDK5HX26guRRThmenDneYDkC 9sThMksbVW4v5LHTnhemmT3QBDdgqwZIcfrAzbxN5CSp4OSD7fmvjTeY/a43YIMkfDII RI9UGb6JQxo7G5y8LapHWcLjjoJLO8VQnk533f2krl1DgWNJVCRabC7hRQvvXrTLK/rI sv9/S+OybdFtEWsteLjFYS97fnZHOGu/ns78MjRvAQpB7VeeInOtZBxOkyBp2yghk1gf FP0Dod+NFxC4hVsgZTaC0/8aTqe4qPVfz/F88mzAWdyjzx3ltItTmMyy1tq2kgHVyIjD tvTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794945911; x=1795550711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TCa0RnoydsxVLT03DHyYOZOOaLc5gZ6BJdmvsECF/XY=; b=V+bsgMM8+7be4Qqc3i/J/1iyz34ZTgiprAI8ATfBw3hbsrApMc3UOiLp6fyhijN05P FLQg1E7UYC84wIeqsLWFTcrIrAScDLoP0TOH41/5lfWFTiNiOlQmHsG1Lc/+J+CpAoTE iLDdAuR1zaoYAf8Q+8zAs5wRZ6ZTcQPp+iVxxECRu+ooV8nnv4bHZYOENXaVJdxMp/d3 DjGkjakE+x7Vvfg/YHMVF8f+8HDRMV8/vW+gkHnD5hWClR/TAup3dCXaxMiqbNbw6TL8 WMDmX+JkI3R/yL0u3ccpjgD+7I7qBrsXNm3mq/uTRH8YdUwD714qzprUU13NHdR5F/Oi iFog== X-Forwarded-Encrypted: i=1; AL+hErEuUkBvmTs+bi157XNrDfGD5sKa9m10RXumhsrT8FvrpyNmnrQrJqdrmWfEfhrPMn+4oFXqlkJ335c11Q==@vger.kernel.org X-Gm-Message-State: APuU4Z87vT8KoPqSULFQykPhwFO4Ss2rxaFIVhV1PMXT+j0bMMKao00j adw6FDRjH6peTWxP8mUfO9VkCmvpUAT1/CsGV/MFshsclGOOGCSPH6hc X-Gm-Gg: AYBFou34BGSiRdg93+lWLM7rzMvD4X72M0zIHOUc4jCGS0PHTso4/2sCi4rFlyLIJqC r76+k1YQKVKJ1RmEzjTA7QaoTEe4WqmrqVfVmPo+MTnJaABHi3uIgnPsm29ATQqf6to7aqR05ev OM3f9hE2EfrSGZ15jve0hprPoYGu+8ri68VaFc7WeVPYJHTZlr8CIbO/zBjDwoX1Bn7URqfDk5P KOrdKy8wBikxhHtD2ELG1i5Gj0V+PyMdIEr8ZUEHQ1Od3wRA7cpVItVm9zFlRt2iceCELA0rzW/ Qh/EzMTXnpsEgWwEUyFZX6THEAnd/KN2/Rb6lg1NwoKNIJ/zUaK8S6PA7ZQtIbNr+23beHunBw4 KJFOYLrFinvTkBtZYiN2ArtB8/aDP4nymeVwsYAuQr1W0IKz4X7GC3t0vl5YRtOnFPcVBRMlg4F QfK7jYXzO/Dfz20aX+0ZlpnqhpJiv9qaClgwiZOyxl0ysWp+jx7mbIT0VKZJDMG71J3J6vH1nGM gndUh8LJ3PZ2fjPmXupvbBJOOSASvma24HvV0R384oI2GOV1jV/Vwqbs82OxBDvZnFQrmXqEijA dnig+W4zam5LBQJ3nDVEL9M4+GWZyT3ERaEbv7ee38LhDCmqwg== X-Received: by 2002:a05:600c:3107:b0:4a1:825a:56fd with SMTP id 5b1f17b1804b1-4bb7da47d19mr4644125e9.32.1794945910693; Tue, 17 Nov 2026 12:05:10 -0800 (PST) Received: from m2.. ([37.142.154.208]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4a64b60940csm625528f8f.0.2026.11.17.12.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 12:05:10 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v4 04/16] HID: ft260: i2c: reduce driver module loading time Date: Tue, 17 Nov 2026 22:04:10 +0200 Message-ID: <20261117200423.19561-5-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261117200423.19561-1-michael.zaidman@gmail.com> References: <20261117200423.19561-1-michael.zaidman@gmail.com> X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The HWMON class I2C client drivers register the address range to scan during the I2C master module probing. For example, the lm75 module registers eight bus addresses scanned during the ft260 module loading. In the case of ft260, the bus is scanned by ft260_i2c_read, but due to an excessive read completion timeout, it took about 40 seconds for the ft260 driver to scan the lm75 address range before exiting the probe function. Adjust the i2c_read timeout so it depends on the amount of data to read, reducing the lm75 address range scan time to about 200ms. The 25 ms per-report budget was checked on a UMFT260EV1A with a 24LC512 EEPROM by shrinking the timeout until reads began to fail: a 60-byte read still completes at 9 ms and times out at 7 ms, against 5.4 ms of wire time at 100 kHz, so the fixed USB, HID and scheduling overhead costs a few milliseconds. At the chip's slowest 60 kHz clock that chunk needs about 9 ms on the wire and a 180-byte chunk about 27 ms. Scale the wait by 25 ms per 60-byte HID payload so a last chunk of 61..180 bytes gets 50..75 ms, not the single-report 25 ms budget. Signed-off-by: Michael Zaidman --- v2: Fix for the issue reported by Sashiko: the timeout of the last I2C read chunk is computed from rd_len, so a chunk of 61..180 bytes gets 50..75 ms, not 25 ms. --- drivers/hid/hid-ft260.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index acd92248256f..1b31b484a11b 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -49,14 +50,20 @@ MODULE_PARM_DESC(debug, "Toggle FT260 debugging messages"); * The ft260 input report format defines 62 bytes for the data payload, but * when requested 62 bytes, the controller returns 60 and 2 in separate input * reports. To achieve better performance with the multi-report read data - * transfers, we set the maximum read payload length to a multiple of 60. + * transfers, we set the maximum read payload length to a multiple of + * FT260_RD_ONE_REPORT_MAX. * With a 100 kHz I2C clock, one 240 bytes read takes about 1/27 second, * which is excessive; On the other hand, some higher layer drivers like at24 * or optoe limit the i2c reads to 128 bytes. To not block other drivers out * of I2C for potentially troublesome amounts of time, we select the maximum * read payload length to be 180 bytes. */ +#define FT260_RD_ONE_REPORT_MAX 60 #define FT260_RD_DATA_MAX 180 + +/* Time in ms to wait for a single HID input report at ONE_REPORT_MAX */ +#define FT260_RD_ONE_REPORT_TO 25 + #define FT260_WR_I2C_DATA_MAX 60 #define FT260_WR_UART_DATA_MAX 60 #define FT260_GPIOCHIP "ft260_gpio" @@ -726,8 +733,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, u16 len, u8 flag) { u16 rd_len; - u16 rd_data_max = 60; - int timeout, ret = 0; + u16 rd_data_max = FT260_RD_ONE_REPORT_MAX; + int timeout, timeout_jiffies, ret = 0; struct ft260_i2c_read_request_report rep; struct hid_device *hdev = dev->hdev; unsigned long irqflags; @@ -752,6 +759,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, } else { rd_len = rd_data_max; } + timeout = FT260_RD_ONE_REPORT_TO * + DIV_ROUND_UP(rd_len, FT260_RD_ONE_REPORT_MAX); rd_data_max = FT260_RD_DATA_MAX; rep.report = FT260_I2C_READ_REQ; @@ -776,8 +785,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, goto ft260_i2c_read_exit; } - timeout = msecs_to_jiffies(5000); - if (!wait_for_completion_timeout(&dev->wait, timeout)) { + timeout_jiffies = msecs_to_jiffies(timeout); + if (!wait_for_completion_timeout(&dev->wait, timeout_jiffies)) { ret = -ETIMEDOUT; ft260_i2c_reset(hdev); goto ft260_i2c_read_exit; -- 2.43.0