From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.170 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795164072; b=mS+iwrWGlTgpjVeXmhvIsL/smP10tnn/Ycci1yonconsYzkvpzzGrPZBB8V8N7ON5hr6 MSTVV1JluELVXMdNtHMnlw1qmrTS13BymgD97TaX4lLSGHWpYy7ogJj5B8CjvfhJzirGw nHtCimwztm1BkYxt6mAfZZc88EPI+DRNlQ0WKmnN8m7fUvOUzkGqCUBwPHPF0pT0JVPLC XfXW3IgjBk1heWunw6qMCnudiRsqLuMI+7BaBsw0ggb50IiIOLuf3x+MYFxDmZbSVdQQI BafQhYrcq1009FBhnekibPEVA7mG9U/79q5PJXk0xgowuUCwyzqqoNpQ6JnzyAXkjqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795164072; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=5JmkSy5fCLJrcwW9MXRthyg4PvftEZNu25217SCypdI=; b=x6rU0dENHVA0ZEcYGq5OtAyZZqaXhgokhUog8ydzks+UEQtGWT11uawTo108r0goOhKJ /KAM+D7YuvKoAaEM0LbAktzvT4tjHizPfK1MmvIUK1au6qbcSzbRVnHBt2Lh4FxPBYSuu +ghJzB1DGxz++rkMYgoni+MCFJaIniJyeScYFCD39ykgPIbTDiTAk4pVdoLYTyz2nhlrX ZzBddCxA7leRB7HUZ6hAH+MWSwTO260VDW2EWbQNynZQXiJyoseppNGEiotUzGAB8zrsS XRy+711TDoRo0yIaUeeM9tgVeO0JX1+ZyKud8EVL7rj4WKvOYfIXeH9yQVyFNOoJ7/A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=zbJnG6vW; arc=none smtp.remote-ip=74.125.82.170 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB1360A5BDA for ; Fri, 20 Nov 2026 08:41:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2DB1360A5BDA Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=zbJnG6vW Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-385d8a00598so493755eec.1 for ; Fri, 20 Nov 2026 00:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795164071; x=1795768871; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5JmkSy5fCLJrcwW9MXRthyg4PvftEZNu25217SCypdI=; b=zbJnG6vW8lVZMjh5L4f0PdVf1iEJ9VeCYbzBPHkz3LATPTp1G8XVGDo6x+wOAbGCNt GwDlraIDjV0qPITMpDxzCimJJ6hgch0pIl28QTc6CIQUnq0DqJkSNvgcUkOdMt9wpy+V ez6ot6IQczbLY4dkipXMwBfoP7VLZkDByyJ8kVhlrR79EtFyaG6wLJgDnEDfyVUgHTv6 5TVp3YgENAXeWXoHEnTG9IHHovkjUWF002Z28SkO+YZ96eWhtj+fABI25Y8md7ANdjXk LiTPrNar9df66kntBvXaXwSHyr28YpGtGzO9QkQbYSIPCc3GJJ8zepXVSy3x5EmNUog0 j2RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795164071; x=1795768871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5JmkSy5fCLJrcwW9MXRthyg4PvftEZNu25217SCypdI=; b=NnLUCBSEgY+yVNP2Dcxza4rbnz4l7ikelBOpiZxJVMiaM/jp2GmzXH2wtrweYFA5gD MddBkj9EfDkrCbP+vM93xnNSFy98h8BAXFTHxiwcdo0mHEfsXA0Sw4kfraH0aOgTOeB6 3+svFXrI6NyUm1FLSU1u3UTiuNYZqs1VLYTZb40T+l8y/q3ZnOCAeaPxui0KcFC5LkYX z6c2XYA73uGEsO9deYgaAEcJbrl8+scA9YyAQYdPDvi9JL/FQA1WxMWoXT4ZAnFK7PMB xZszttmiiFRtCffXcrTx/BeXpw1Rbgy87EZ0X+DZL6MH1XbXbRtqsCnt3dgh2D09GUCP 3Kug== X-Forwarded-Encrypted: i=1; AL+hErFg/Brga4M8CxEGhwI9XnpJ2VJv/Rkt0pxMcXLOXs8RRr6HM3Oeep4KYKs0y9Nmi+cRsWlBwaSlk0x3Rg==@vger.kernel.org X-Gm-Message-State: APuU4Z8fCik+bGjkzCGzxC7byyyZNWSERxkAEukR9Vp1o6rnbot3oOFn DC/4ENXohdhjp964/3q5kK2PaWky6JzQfviDFGEUO7eywpO8bfGqAEoX X-Gm-Gg: AZFdTZcekPSVcsDdlAPoLd2r15y+5/RzooR2v7qHAE1D2L3fkvDIEDtUjBqqKuodmxq PgO0yhPTFRmTyZMDQijLPxyGNV7pTbO4ugAfF41wvMrWdfHdpK4y2lfjIFGnLWbhhqOf76mIfZ0 32cNFZV2/WYJtbI3ztu7bpAkCjRbod9OoJoHYjjFx3LpE/f5hPEGY+Twsr0IH3kI16NfY6jgoAP kIoEMuwXE4gdBu8pdal0Yesdjbuu+DOtrX81JK80VHrGtUs+7hTCcdSLEqGzbbADfutVsCEpCMZ lgUxCwymexNOttgTQiIt3mVcNjREDXWwgENQvifQqo3XaEvhNTzCaiW5idWFZl7UEy8V5e7UOqd 6A1oifrJrfeqe/ZtQFjmaAx+sQvcOKu1XYXmxcKVxHvKv57ar+KDU7y/DkEWIAriGWe+fvwgdTk EW5C0s7bQedLSd9N5yYk91OSuXrNaoBVLyGqxKCfQT4YjlQt46XCzeI/Y30bUaz5xmr4iT6j2Vh dN2T1GQi6LL0SvHj0fDqCpNECdgGkhMRmvu9Uj4TooqnmDEzePp5S/egiCjraql3/CM1+8+j50N zMUsacyzincQMH+s+hpt1KwGrDkcpn2hKyAs0QhgWQDTWj4LHHzc/Mt97C1C6YlqV/Qqiq1o+K3 3tJDXKHzriywq4LCavg== X-Received: by 2002:a05:693c:8083:b0:375:e4de:96d3 with SMTP id 5a478bee46e88-3857083f7d3mr2158131eec.31.1795164071311; Fri, 20 Nov 2026 00:41:11 -0800 (PST) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:ea97:e47d:2ebc:210c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-385677c371esm5793181eec.23.2026.11.20.00.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 00:41:10 -0800 (PST) From: Dmitry Torokhov Date: Fri, 20 Nov 2026 00:40:57 -0800 Subject: [PATCH v3 09/14] HID: logitech-hidpp: initialize response buffer before publishing send_receive_buf X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261120-hid-logitech-hidpp-v3-9-cfe2caa1d0eb@gmail.com> References: <20261120-hid-logitech-hidpp-v3-0-cfe2caa1d0eb@gmail.com> In-Reply-To: <20261120-hid-logitech-hidpp-v3-0-cfe2caa1d0eb@gmail.com> To: Jiri Kosina , Benjamin Tissoires , Gideon Heinz Cc: =?utf-8?q?Filipe_La=C3=ADns?= , Bastien Nocera , Hans de Goede , Edwin Velds , Stuart Hayhurst , Andrey Smirnov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.17-dev-6b8b8 __do_hidpp_send_message_sync() publishes send_receive_buf before initializing the response buffer. hidpp_raw_hidpp_event() runs in IRQ or softirq context without taking send_mutex whenever the mutex is locked, reading question and answer from send_receive_buf. If an incoming report arrives after send_receive_buf is published but before response is populated, hidpp_match_answer() inspects uninitialized memory. Initialize response with the outgoing message and clear answer_available before publishing send_receive_buf with release semantics, clear the pointer with WRITE_ONCE() on completion, and read it once with acquire semantics in the event handler. Fixes: 2f31c5252910 ("HID: Introduce hidpp, a module to handle Logitech hid++ devices") Tested-by: Gideon Heinz Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-logitech-hidpp.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index c486488efe99..16dcd79059d5 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -300,14 +300,17 @@ static int __do_hidpp_send_message_sync(struct hidpp_device *hidpp, __must_hold(&hidpp->send_mutex); - hidpp->send_receive_buf = response; - hidpp->answer_available = false; - /* * So that we can later validate the answer when it arrives * in hidpp_raw_event */ *response = *message; + hidpp->answer_available = false; + /* + * Pairs with smp_load_acquire() in hidpp_raw_hidpp_event() to ensure + * the response buffer initialization is visible before publishing. + */ + smp_store_release(&hidpp->send_receive_buf, response); ret = __hidpp_send_report(hidpp->hid_dev, message); if (ret) { @@ -342,7 +345,7 @@ static int __do_hidpp_send_message_sync(struct hidpp_device *hidpp, ret = 0; out: - hidpp->send_receive_buf = NULL; + WRITE_ONCE(hidpp->send_receive_buf, NULL); return ret; } @@ -4148,12 +4151,16 @@ static int hidpp_raw_hidpp_event(struct hidpp_device *hidpp, u8 *data, * previously sent command. */ if (unlikely(mutex_is_locked(&hidpp->send_mutex))) { - question = hidpp->send_receive_buf; - answer = hidpp->send_receive_buf; - + /* + * Pairs with smp_store_release() in __do_hidpp_send_message_sync() + * to ensure the initialized response buffer is observed. + */ + question = smp_load_acquire(&hidpp->send_receive_buf); if (!question) return 0; + answer = question; + /* * Check for a correct hidpp20 answer or the corresponding * error -- 2.56.1.750.gf70dc682cf-goog