linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Achatz <erazor_de@users.sourceforge.net>
To: jkosina@suse.cz, erazor_de@users.sourceforge.net
Cc: rdunlap@xenotime.net, gregkh@suse.de, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation
Date: Thu, 9 Dec 2010 14:44:06 +0100 (CET)	[thread overview]
Message-ID: <2069123096.22885.1291902246397.JavaMail.ngmail@webmail07.arcor-online.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1012091430130.508@pobox.suse.cz>

 


----- Original Nachricht ----
Von:     Jiri Kosina <jkosina@suse.cz>
An:      Stefan Achatz <erazor_de@users.sourceforge.net>
Datum:   09.12.2010 14:30
Betreff: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs
 attribute creation

> On Fri, 26 Nov 2010, Stefan Achatz wrote:
> 
> > Adding sysfs attributes to an already created device raises no userland
> > notification.
> > 
> > Instead of fiddling around in the depths of busses and devices I reuse
> the
> > event char device (module hid-roccat). This device gets now created with
> > a hardware specific class that contains the device attributes.
> 
> Hi Stefan,
> 
> I have applied the series, and removed the #pragma pack ugliness. Thanks,

Hello Jiri,
Using my patch replacing the #pragma pack with the __packed macro would have saved you some time:
https://lkml.org/lkml/2010/11/27/14

Just for the future: Whats better using the verbose version __attribute__ ((__packed__)) or the macro
__packed as I did?

Thanks, Stefan

  parent reply	other threads:[~2010-12-09 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1290801444.18750.161.camel@neuromancer>
2010-12-09 13:30 ` [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation Jiri Kosina
2010-12-09 13:44 ` Stefan Achatz [this message]
2010-12-09 13:52   ` Aw: " Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2069123096.22885.1291902246397.JavaMail.ngmail@webmail07.arcor-online.net \
    --to=erazor_de@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=jkosina@suse.cz \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).