* Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation
[not found] <1290801444.18750.161.camel@neuromancer>
@ 2010-12-09 13:30 ` Jiri Kosina
2010-12-09 13:44 ` Aw: " Stefan Achatz
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2010-12-09 13:30 UTC (permalink / raw)
To: Stefan Achatz
Cc: Randy Dunlap, Greg Kroah-Hartman, linux-doc, linux-kernel,
linux-input, netdev
On Fri, 26 Nov 2010, Stefan Achatz wrote:
> Adding sysfs attributes to an already created device raises no userland
> notification.
>
> Instead of fiddling around in the depths of busses and devices I reuse the
> event char device (module hid-roccat). This device gets now created with
> a hardware specific class that contains the device attributes.
Hi Stefan,
I have applied the series, and removed the #pragma pack ugliness. Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation
[not found] <1290801444.18750.161.camel@neuromancer>
2010-12-09 13:30 ` [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation Jiri Kosina
@ 2010-12-09 13:44 ` Stefan Achatz
2010-12-09 13:52 ` Jiri Kosina
1 sibling, 1 reply; 3+ messages in thread
From: Stefan Achatz @ 2010-12-09 13:44 UTC (permalink / raw)
To: jkosina, erazor_de
Cc: rdunlap, gregkh, linux-doc, linux-kernel, linux-input, netdev
----- Original Nachricht ----
Von: Jiri Kosina <jkosina@suse.cz>
An: Stefan Achatz <erazor_de@users.sourceforge.net>
Datum: 09.12.2010 14:30
Betreff: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs
attribute creation
> On Fri, 26 Nov 2010, Stefan Achatz wrote:
>
> > Adding sysfs attributes to an already created device raises no userland
> > notification.
> >
> > Instead of fiddling around in the depths of busses and devices I reuse
> the
> > event char device (module hid-roccat). This device gets now created with
> > a hardware specific class that contains the device attributes.
>
> Hi Stefan,
>
> I have applied the series, and removed the #pragma pack ugliness. Thanks,
Hello Jiri,
Using my patch replacing the #pragma pack with the __packed macro would have saved you some time:
https://lkml.org/lkml/2010/11/27/14
Just for the future: Whats better using the verbose version __attribute__ ((__packed__)) or the macro
__packed as I did?
Thanks, Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation
2010-12-09 13:44 ` Aw: " Stefan Achatz
@ 2010-12-09 13:52 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2010-12-09 13:52 UTC (permalink / raw)
To: Stefan Achatz
Cc: rdunlap, gregkh, linux-doc, linux-kernel, linux-input, netdev
On Thu, 9 Dec 2010, Stefan Achatz wrote:
> > I have applied the series, and removed the #pragma pack ugliness. Thanks,
>
> Hello Jiri,
> Using my patch replacing the #pragma pack with the __packed macro would
> have saved you some time: https://lkml.org/lkml/2010/11/27/14
Ah, missed that. Never mind.
> Just for the future: Whats better using the verbose version
> __attribute__ ((__packed__)) or the macro __packed as I did?
I don't think I really care deeply here.
For some rationale why these shortcuts exist, please see commit
82ddcb0405704.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-09 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1290801444.18750.161.camel@neuromancer>
2010-12-09 13:30 ` [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation Jiri Kosina
2010-12-09 13:44 ` Aw: " Stefan Achatz
2010-12-09 13:52 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).