From: Aditya Garg <adityagarg1208@gmail.com>
To: Benjamin Tissoires <bentiss@kernel.org>
Cc: admin@kodeit.net, benjamin.tissoires@redhat.com,
GARGADITYA08@live.com, jikos@kernel.org, jkosina@suse.com,
kekrby@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, orlandoch.dev@gmail.com
Subject: Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar
Date: Tue, 25 Mar 2025 23:01:31 +0530 [thread overview]
Message-ID: <219B5F93-611D-48FA-A4D9-F9B71401A57D@gmail.com> (raw)
In-Reply-To: <bzb6rk7q7rs27kbonihpfftkgueievpux7vpqjgrgsud5pf5g2@tuxymj7vk3it>
> On 25 Mar 2025, at 10:59 PM, Benjamin Tissoires <bentiss@kernel.org> wrote:
>
> On Mar 25 2025, Aditya Garg wrote:
>> Yes I can move hid_find_field to the original location as well. But, I would not want to devm_kzalloc as well unnecessarily if the touchbar is in the basic mode instead of drm mode which will cause this -ENODEV to be executed right?
>
> It shouldn't matter. hid_core calls devres_open_group() before calling
> .probe(), and calls devres_release_group() on failure. So yes, we'll
> allocate a piece of memory and release it after, but it's not something
> uncommon.
Fair. I'll send a v2
next prev parent reply other threads:[~2025-03-25 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 17:01 [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar Aditya Garg
2025-03-25 17:05 ` Aditya Garg
2025-03-25 17:29 ` Benjamin Tissoires
2025-03-25 17:31 ` Aditya Garg [this message]
2025-03-25 18:05 ` Aditya Garg
2025-03-26 9:54 ` Jiri Kosina
2025-03-26 13:39 ` Aditya Garg
-- strict thread matches above, loose matches on Subject: below --
2025-03-10 9:10 [PATCH RESEND 0/5] HID: multitouch: Add support for Touch Bars on x86 MacBook Pros Aditya Garg
2025-03-10 9:14 ` [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar Aditya Garg
2025-03-25 13:13 ` Benjamin Tissoires
2025-03-25 13:38 ` Aditya Garg
2025-03-25 16:11 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=219B5F93-611D-48FA-A4D9-F9B71401A57D@gmail.com \
--to=adityagarg1208@gmail.com \
--cc=GARGADITYA08@live.com \
--cc=admin@kodeit.net \
--cc=benjamin.tissoires@redhat.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=jkosina@suse.com \
--cc=kekrby@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orlandoch.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox