From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62DFC25B0C for ; Thu, 11 Aug 2022 06:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233889AbiHKGVl (ORCPT ); Thu, 11 Aug 2022 02:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233893AbiHKGVl (ORCPT ); Thu, 11 Aug 2022 02:21:41 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDD0804A8 for ; Wed, 10 Aug 2022 23:21:39 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id y23so18275622ljh.12 for ; Wed, 10 Aug 2022 23:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=lyTs0msMVRVl1NUIwPFvCz6xKYL3ajDC0cSoOz8c7XI=; b=FDV+lVhjw2kjDqTw4xfkooXjCluNrUuws4Xo5sbG5kfTLntDeDFgHP+PGT4OmaGMAQ cP20yptfuT0hLFAlcJ8UlBjqxXhvcaxEOCK6dIBAdQjqwXKvi57z4JtK+Xo/Q996qfiA VpD8Q8hFnyu06jHrhOGHMvzP0ygb6w1Hmw4KcVTFjQwb6vSh/oOGo5yQcKEM9kuegtx6 lvUUouNQ4njGlvJTQOo/NPafJ99G/faXb6FwndWk0ZNA+CBIYhZlbjaNgw5tgr/qs4qb nfYlFAK179k+PGlmniTnKrWiFc2nCPq1J/BHXMuHly89aeNYK3h+s4Rafx+mjVn6F6Fv Noig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=lyTs0msMVRVl1NUIwPFvCz6xKYL3ajDC0cSoOz8c7XI=; b=USu0KpP0SI7wsaNoui/C9ulgKdCBWYI8NqG4cZcLCAnjbVmpfzq0bdZaivOwDDJVhM /r4zVEPf7d0jnwQi14tmnJM0gZTJUydeKwbpUOfVAOjAdszfR7J+f5YZAemjZSxY0ENd v8P4LlyiYdmxYUmztQpabYooiAo4Du4uG7MgC2U66zSRjoJ20PE+g8zv1eYydqyHYLsz sjyyo0j8+1MrB7E39MTSIcLuQJ66RDwJuPxYwUVqUs+DZZdEPcOS/LlZU7p6fj6JLQ7K 7NoJy0jPRnP3vp7Z02Km1UebGam8598Ru1lcge4dJin/sJ3gu6GIdtYMKfhOGVhHgRyP H7tw== X-Gm-Message-State: ACgBeo1QQTN3nRPG4pmaaLFy0J/SiAFO1XyoJmrggBQHeB8pbER89GNG MLX3/ldr5BgEjI2oLuf2/hjUAg== X-Google-Smtp-Source: AA6agR5PfCABBMzNdydhDAoRM7n+bYDqAckQIGcBfUqUJzialeclBQo6ABctsz1WRiMUt4Tcp3sWiw== X-Received: by 2002:a2e:a411:0:b0:25e:5798:9fd with SMTP id p17-20020a2ea411000000b0025e579809fdmr9591658ljn.502.1660198897767; Wed, 10 Aug 2022 23:21:37 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id a5-20020a056512390500b0048aeafde9b8sm589362lfu.108.2022.08.10.23.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 23:21:36 -0700 (PDT) Message-ID: <219a875c-f46c-fde9-4370-4168d440e614@linaro.org> Date: Thu, 11 Aug 2022 09:21:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] dt-bindings: input: ariel-pwrbutton: use spi-peripheral-props.yaml Content-Language: en-US To: Dmitry Torokhov , Rob Herring Cc: linux-kernel@vger.kernel.org, Lubomir Rintel , Rob Herring , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-input@vger.kernel.org References: <20220727164230.385614-1-krzysztof.kozlowski@linaro.org> <20220728151942.GA903363-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 11/08/2022 01:57, Dmitry Torokhov wrote: > On Thu, Jul 28, 2022 at 09:19:42AM -0600, Rob Herring wrote: >> On Wed, 27 Jul 2022 18:42:30 +0200, Krzysztof Kozlowski wrote: >>> Instead of listing directly properties typical for SPI peripherals, >>> reference the spi-peripheral-props.yaml schema. This allows using all >>> properties typical for SPI-connected devices, even these which device >>> bindings author did not tried yet. >>> >>> Remove the spi-* properties which now come via spi-peripheral-props.yaml >>> schema, except for the cases when device schema adds some constraints >>> like maximum frequency. >>> >>> While changing additionalProperties->unevaluatedProperties, put it in >>> typical place, just before example DTS.a >>> >>> The binding references also input.yaml and lists explicitly allowed >>> properties, thus here reference only spi-peripheral-props.yaml for >>> purpose of documenting the SPI slave device and bringing >>> spi-max-frequency type validation. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> Technically, this depends on [1] merged to SPI tree, if we want to >>> preserve existing behavior of not allowing SPI CPHA and CPOL in each of >>> schemas in this patch. > > Could we merge this through SPI tree as well? > >>> >>> If this patch comes independently via different tree, the SPI CPHA and >>> CPOL will be allowed for brief period of time, before [1] is merged. >>> This will not have negative impact, just DT schema checks will be >>> loosened for that period. >>> >>> [1] https://lore.kernel.org/all/20220722191539.90641-2-krzysztof.kozlowski@linaro.org/ >>> --- >>> Documentation/devicetree/bindings/input/ariel-pwrbutton.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >> >> Acked-by: Rob Herring > > Acked-by: Dmitry Torokhov > There is no dependency anymore (and actually that time it was not really dependency), so you can take it freely for next cycle. Best regards, Krzysztof