Re: [PATCH v7 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

[Werner Sembach <wse@tuxedocomputers.com>]

Am 16.04.25 um 21:13 schrieb ALOK TIWARI:
>
>
> On 16-04-2025 22:41, Werner Sembach wrote:
>> +    for (unsigned int i = 0; i < rep->lamp_count; ++i) {
>> +        if (rep->lamp_id[i] > driver_data->lamp_count) {
>> +            hid_dbg(hdev, "Out of bounds lamp_id in 
>> lamp_multi_update_report. Skippng whole report!\n");
>> +            return sizeof(*rep);
>> +        }
>
> typo -Skippng
thx for spotting
>
>> +
>> +        for (unsigned int j = i + 1; j < rep->lamp_count; ++j) {
>> +            if (rep->lamp_id[i] == rep->lamp_id[j]) {
>> +                hid_dbg(hdev, "Duplicate lamp_id in 
>> lamp_multi_update_report. Skippng whole report!\n");
>> +                return sizeof(*rep);
>> +            }
>> +        }
>> +    }
>
>
> Thanks,
> Alok