From: Pavel Herrmann <morpheus.ibis@gmail.com>
To: Stanislav Brabec <utx@penguin.cz>
Cc: Marek Vasut <marek.vasut@gmail.com>,
linux-arm-kernel@lists.infradead.org,
zaurus-devel@lists.linuxtogo.org,
spi-devel-general@lists.sourceforge.net,
Igor Grinberg <grinberg@compulab.co.il>,
vapier@gentoo.org, khilman@deeprootsystems.com,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
pavel@ucw.cz, linux-input@vger.kernel.org, eric.y.miao@gmail.com,
akpm@linux-foundation.org, broonie@opensource.wolfsonmicro.com
Subject: Re: kernel panic in spi_complete() on spitz (PXA270)
Date: Thu, 30 Jun 2011 17:36:57 +0200 [thread overview]
Message-ID: <22208110.jIqhYvKY9h@bloomfield> (raw)
In-Reply-To: <201106301709.48818.marek.vasut@gmail.com>
On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote:
> Then I tried to apply "[PATCH] MAX1111: Fix race condition causing NULL
> pointer exception", connected charger that periodically disconnects and
> not seen the crash again. No OOPS was seen after ~100 reconnects.
>
> So I guess that MAX1111 AC voltage reading (via SPI) was involved in an
> incorrect moment and race happened there and your MAX1111 race condition
> fix fixes it.
Hi,
Are you using the first or second version of the patch? if the former, please
use v2 (sent a few days later), which has solved the same problem by using a
mutex instead of allocating message data on stack (which is not good for DMA)
as for the backstory, this crash ocurrs when a short (measured in time spent)
message was enqueued after a long message, so that the short one finished first
(the actual bug was present even if the long one finished first, but in that
case there was double complete() on the one completion instead of a NULL
dereference)
Pavel
next prev parent reply other threads:[~2011-06-30 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1308845380.4533.54.camel@oct.suse.cz>
2011-06-30 11:52 ` kernel panic in spi_complete() on spitz (PXA270) Marek Vasut
[not found] ` <201106301352.21684.marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-30 14:45 ` Stanislav Brabec
2011-06-30 15:09 ` Marek Vasut
2011-06-30 15:36 ` Pavel Herrmann [this message]
2011-06-30 16:22 ` Stanislav Brabec
2011-06-30 15:25 ` Igor Grinberg
2011-06-30 15:59 ` Mark Brown
[not found] ` <4E0C957F.8080807-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-06-30 16:13 ` Stanislav Brabec
2011-06-30 17:40 ` Igor Grinberg
2011-06-30 18:01 ` Mark Brown
2011-06-30 20:50 ` Igor Grinberg
[not found] ` <4E0CE189.1020000-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-06-30 22:20 ` Stanislav Brabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22208110.jIqhYvKY9h@bloomfield \
--to=morpheus.ibis@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=pavel@ucw.cz \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=utx@penguin.cz \
--cc=vapier@gentoo.org \
--cc=zaurus-devel@lists.linuxtogo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).