From: "Michal Malý" <madcatxster@gmail.com>
To: linux-input@vger.kernel.org
Cc: jkosina@suse.cz, simon@mungewell.org
Subject: [PATCHv2 3/3] Cleanup: Fix a compile error in hid-lg4ff and remove an extra include in hid-lg.h
Date: Wed, 14 Mar 2012 18:41:51 +0100 [thread overview]
Message-ID: <2265349.gN1B18tWc4@qosmio-x300> (raw)
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
My mind was apparently wandering around a bit which lead to a compile error in
hid-lg4ff.
I also forgot to remove the spinlock.h include from hid-lg.h I am sorry about
this mess...
Signed-off-by: Michal Malý <madcatxster@gmail.com>
>From 61bbb9d5be1d8957ad8c6b63a4a6b911cb8aa12e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20Mal=C3=BD?= <madcatxster@gmail.com>
Date: Wed, 14 Mar 2012 18:34:33 +0100
Subject: [PATCH 3/3] HID: hid-lg4ff: Fix hid_err call, hid-lg: Remove a
superfluous include
---
drivers/hid/hid-lg.h | 2 --
drivers/hid/hid-lg4ff.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid/hid-lg.h b/drivers/hid/hid-lg.h
index 500457b..d64cf8d 100644
--- a/drivers/hid/hid-lg.h
+++ b/drivers/hid/hid-lg.h
@@ -1,8 +1,6 @@
#ifndef __HID_LG_H
#define __HID_LG_H
-#include <linux/spinlock.h>
-
struct lg_drv_data {
unsigned long quirks;
void *device_props; /* Device specific properties */
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index f70ae41..1145292 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -481,7 +481,7 @@ int lg4ff_deinit(struct hid_device *hid)
}
if (!found) {
- dbg_err("Device entry not found!\n");
+ hid_err(hid, "Device entry not found!\n");
return -1;
}
--
1.7.9.4
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next reply other threads:[~2012-03-14 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 17:41 Michal Malý [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-14 17:41 [PATCHv2 3/3] Cleanup: Fix a compile error in hid-lg4ff and remove an extra include in hid-lg.h Michal Malý
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2265349.gN1B18tWc4@qosmio-x300 \
--to=madcatxster@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).